All of lore.kernel.org
 help / color / mirror / Atom feed
From: Razmik Karapetyan <Razmik.Karapetyan@synopsys.com>
To: John Youn <John.Youn@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Razmik Karapetyan <Razmik.Karapetyan@synopsys.com>
Subject: [PATCH v2] usb: dwc2: Remove unnecessary debug prints
Date: Wed, 6 Dec 2017 17:57:32 +0400	[thread overview]
Message-ID: <6ac2983d-9664-4584-bb51-bf6f4b54ec78@US01WEHTC1.internal.synopsys.com> (raw)

Removed unnecessary debug prints about DMA mode for host side
from dwc2_gahbcfg_init() function.

Signed-off-by: Razmik Karapetyan <razmik@synopsys.com>
---
 drivers/usb/dwc2/hcd.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 614bb9603def..fafbba4e79e8 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -308,22 +308,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
 		break;
 	}
 
-	dev_dbg(hsotg->dev, "host_dma:%d dma_desc_enable:%d\n",
-		hsotg->params.host_dma,
-		hsotg->params.dma_desc_enable);
-
-	if (hsotg->params.host_dma) {
-		if (hsotg->params.dma_desc_enable)
-			dev_dbg(hsotg->dev, "Using Descriptor DMA mode\n");
-		else
-			dev_dbg(hsotg->dev, "Using Buffer DMA mode\n");
-	} else {
-		dev_dbg(hsotg->dev, "Using Slave mode\n");
-		hsotg->params.dma_desc_enable = false;
-	}
-
 	if (hsotg->params.host_dma)
 		ahbcfg |= GAHBCFG_DMA_EN;
+	else
+		hsotg->params.dma_desc_enable = false;
 
 	dwc2_writel(ahbcfg, hsotg->regs + GAHBCFG);
 
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Razmik Karapetyan <Razmik.Karapetyan@synopsys.com>
To: John Youn <John.Youn@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Razmik Karapetyan <Razmik.Karapetyan@synopsys.com>
Subject: [v2] usb: dwc2: Remove unnecessary debug prints
Date: Wed, 6 Dec 2017 17:57:32 +0400	[thread overview]
Message-ID: <6ac2983d-9664-4584-bb51-bf6f4b54ec78@US01WEHTC1.internal.synopsys.com> (raw)

Removed unnecessary debug prints about DMA mode for host side
from dwc2_gahbcfg_init() function.

Signed-off-by: Razmik Karapetyan <razmik@synopsys.com>
---
 drivers/usb/dwc2/hcd.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 614bb9603def..fafbba4e79e8 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -308,22 +308,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
 		break;
 	}
 
-	dev_dbg(hsotg->dev, "host_dma:%d dma_desc_enable:%d\n",
-		hsotg->params.host_dma,
-		hsotg->params.dma_desc_enable);
-
-	if (hsotg->params.host_dma) {
-		if (hsotg->params.dma_desc_enable)
-			dev_dbg(hsotg->dev, "Using Descriptor DMA mode\n");
-		else
-			dev_dbg(hsotg->dev, "Using Buffer DMA mode\n");
-	} else {
-		dev_dbg(hsotg->dev, "Using Slave mode\n");
-		hsotg->params.dma_desc_enable = false;
-	}
-
 	if (hsotg->params.host_dma)
 		ahbcfg |= GAHBCFG_DMA_EN;
+	else
+		hsotg->params.dma_desc_enable = false;
 
 	dwc2_writel(ahbcfg, hsotg->regs + GAHBCFG);
 

             reply	other threads:[~2017-12-06 13:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 13:57 Razmik Karapetyan [this message]
2017-12-06 13:57 ` [v2] usb: dwc2: Remove unnecessary debug prints Razmik Karapetyan
2017-12-07 19:17 ` [PATCH v2] " Joe Perches
2017-12-07 19:17   ` [v2] " Joe Perches
2017-12-07 19:18   ` [PATCH v2] " Joe Perches
2017-12-07 19:18     ` [v2] " Joe Perches
2017-12-08  7:55     ` [PATCH v2] " Razmik Karapetyan
2017-12-08  7:55       ` [v2] " Razmik Karapetyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ac2983d-9664-4584-bb51-bf6f4b54ec78@US01WEHTC1.internal.synopsys.com \
    --to=razmik.karapetyan@synopsys.com \
    --cc=John.Youn@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.