* [PATCH v2] usb: dwc2: Remove unnecessary debug prints
@ 2017-12-06 13:57 ` Razmik Karapetyan
0 siblings, 0 replies; 8+ messages in thread
From: Razmik Karapetyan @ 2017-12-06 13:57 UTC (permalink / raw)
To: John Youn, Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
Cc: Razmik Karapetyan
Removed unnecessary debug prints about DMA mode for host side
from dwc2_gahbcfg_init() function.
Signed-off-by: Razmik Karapetyan <razmik@synopsys.com>
---
drivers/usb/dwc2/hcd.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 614bb9603def..fafbba4e79e8 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -308,22 +308,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
break;
}
- dev_dbg(hsotg->dev, "host_dma:%d dma_desc_enable:%d\n",
- hsotg->params.host_dma,
- hsotg->params.dma_desc_enable);
-
- if (hsotg->params.host_dma) {
- if (hsotg->params.dma_desc_enable)
- dev_dbg(hsotg->dev, "Using Descriptor DMA mode\n");
- else
- dev_dbg(hsotg->dev, "Using Buffer DMA mode\n");
- } else {
- dev_dbg(hsotg->dev, "Using Slave mode\n");
- hsotg->params.dma_desc_enable = false;
- }
-
if (hsotg->params.host_dma)
ahbcfg |= GAHBCFG_DMA_EN;
+ else
+ hsotg->params.dma_desc_enable = false;
dwc2_writel(ahbcfg, hsotg->regs + GAHBCFG);
--
2.11.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [v2] usb: dwc2: Remove unnecessary debug prints
@ 2017-12-06 13:57 ` Razmik Karapetyan
0 siblings, 0 replies; 8+ messages in thread
From: Razmik Karapetyan @ 2017-12-06 13:57 UTC (permalink / raw)
To: John Youn, Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
Cc: Razmik Karapetyan
Removed unnecessary debug prints about DMA mode for host side
from dwc2_gahbcfg_init() function.
Signed-off-by: Razmik Karapetyan <razmik@synopsys.com>
---
drivers/usb/dwc2/hcd.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 614bb9603def..fafbba4e79e8 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -308,22 +308,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
break;
}
- dev_dbg(hsotg->dev, "host_dma:%d dma_desc_enable:%d\n",
- hsotg->params.host_dma,
- hsotg->params.dma_desc_enable);
-
- if (hsotg->params.host_dma) {
- if (hsotg->params.dma_desc_enable)
- dev_dbg(hsotg->dev, "Using Descriptor DMA mode\n");
- else
- dev_dbg(hsotg->dev, "Using Buffer DMA mode\n");
- } else {
- dev_dbg(hsotg->dev, "Using Slave mode\n");
- hsotg->params.dma_desc_enable = false;
- }
-
if (hsotg->params.host_dma)
ahbcfg |= GAHBCFG_DMA_EN;
+ else
+ hsotg->params.dma_desc_enable = false;
dwc2_writel(ahbcfg, hsotg->regs + GAHBCFG);
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] usb: dwc2: Remove unnecessary debug prints
@ 2017-12-07 19:17 ` Joe Perches
0 siblings, 0 replies; 8+ messages in thread
From: Joe Perches @ 2017-12-07 19:17 UTC (permalink / raw)
To: Razmik Karapetyan, John Youn, Felipe Balbi, Greg Kroah-Hartman,
linux-usb, linux-kernel
On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote:
> Removed unnecessary debug prints about DMA mode for host side
> from dwc2_gahbcfg_init() function.
What other functionality makes these unnecessary?
If any, it's nice to de
^ permalink raw reply [flat|nested] 8+ messages in thread
* [v2] usb: dwc2: Remove unnecessary debug prints
@ 2017-12-07 19:17 ` Joe Perches
0 siblings, 0 replies; 8+ messages in thread
From: Joe Perches @ 2017-12-07 19:17 UTC (permalink / raw)
To: Razmik Karapetyan, John Youn, Felipe Balbi, Greg Kroah-Hartman,
linux-usb, linux-kernel
On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote:
> Removed unnecessary debug prints about DMA mode for host side
> from dwc2_gahbcfg_init() function.
What other functionality makes these unnecessary?
If any, it's nice to de
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] usb: dwc2: Remove unnecessary debug prints
@ 2017-12-07 19:18 ` Joe Perches
0 siblings, 0 replies; 8+ messages in thread
From: Joe Perches @ 2017-12-07 19:18 UTC (permalink / raw)
To: Razmik Karapetyan, John Youn, Felipe Balbi, Greg Kroah-Hartman,
linux-usb, linux-kernel
On Thu, 2017-12-07 at 11:17 -0800, Joe Perches wrote:
> On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote:
> > Removed unnecessary debug prints about DMA mode for host side
> > from dwc2_gahbcfg_init() function.
>
> What other functionality makes these unnecessary?
> If any, it's nice to de
... describe it in the changelog.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [v2] usb: dwc2: Remove unnecessary debug prints
@ 2017-12-07 19:18 ` Joe Perches
0 siblings, 0 replies; 8+ messages in thread
From: Joe Perches @ 2017-12-07 19:18 UTC (permalink / raw)
To: Razmik Karapetyan, John Youn, Felipe Balbi, Greg Kroah-Hartman,
linux-usb, linux-kernel
On Thu, 2017-12-07 at 11:17 -0800, Joe Perches wrote:
> On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote:
> > Removed unnecessary debug prints about DMA mode for host side
> > from dwc2_gahbcfg_init() function.
>
> What other functionality makes these unnecessary?
> If any, it's nice to de
... describe it in the changelog.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] usb: dwc2: Remove unnecessary debug prints
@ 2017-12-08 7:55 ` Razmik Karapetyan
0 siblings, 0 replies; 8+ messages in thread
From: Razmik Karapetyan @ 2017-12-08 7:55 UTC (permalink / raw)
To: Joe Perches, Razmik Karapetyan, John Youn, Felipe Balbi,
Greg Kroah-Hartman, linux-usb, linux-kernel
On 12/7/2017 11:18 PM, Joe Perches wrote:
> On Thu, 2017-12-07 at 11:17 -0800, Joe Perches wrote:
>> On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote:
>>> Removed unnecessary debug prints about DMA mode for host side
>>> from dwc2_gahbcfg_init() function.
>>
>> What other functionality makes these unnecessary?
>> If any, it's nice to de
>
> ... describe it in the changelog.
>
Hi Joe,
No any other functionality makes them unnecessary.
In the driver we have debug info about DMA type only for host side, so
operating in device mode DMA type can be different and those debug
prints ("Using Buffer\Descriptor DMA mode\n") can cause confusions.
We can add debug prints for device mode also, but it is preferable to
have less debug info in the log.
Thanks,
Razmik
^ permalink raw reply [flat|nested] 8+ messages in thread* [v2] usb: dwc2: Remove unnecessary debug prints
@ 2017-12-08 7:55 ` Razmik Karapetyan
0 siblings, 0 replies; 8+ messages in thread
From: Razmik Karapetyan @ 2017-12-08 7:55 UTC (permalink / raw)
To: Joe Perches, Razmik Karapetyan, John Youn, Felipe Balbi,
Greg Kroah-Hartman, linux-usb, linux-kernel
On 12/7/2017 11:18 PM, Joe Perches wrote:
> On Thu, 2017-12-07 at 11:17 -0800, Joe Perches wrote:
>> On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote:
>>> Removed unnecessary debug prints about DMA mode for host side
>>> from dwc2_gahbcfg_init() function.
>>
>> What other functionality makes these unnecessary?
>> If any, it's nice to de
>
> ... describe it in the changelog.
>
Hi Joe,
No any other functionality makes them unnecessary.
In the driver we have debug info about DMA type only for host side, so
operating in device mode DMA type can be different and those debug
prints ("Using Buffer\Descriptor DMA mode\n") can cause confusions.
We can add debug prints for device mode also, but it is preferable to
have less debug info in the log.
Thanks,
Razmik
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-12-08 7:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-06 13:57 [PATCH v2] usb: dwc2: Remove unnecessary debug prints Razmik Karapetyan
2017-12-06 13:57 ` [v2] " Razmik Karapetyan
2017-12-07 19:17 ` [PATCH v2] " Joe Perches
2017-12-07 19:17 ` [v2] " Joe Perches
2017-12-07 19:18 ` [PATCH v2] " Joe Perches
2017-12-07 19:18 ` [v2] " Joe Perches
2017-12-08 7:55 ` [PATCH v2] " Razmik Karapetyan
2017-12-08 7:55 ` [v2] " Razmik Karapetyan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.