All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: Regressions in build process introduced since August
Date: Wed, 18 Nov 2020 20:50:47 +0100	[thread overview]
Message-ID: <6ae1dcc4-591c-5fc2-9423-d80b9b16e777@weilnetz.de> (raw)
In-Reply-To: <20201118153416.GG229461@redhat.com>

Am 18.11.20 um 16:34 schrieb Daniel P. Berrangé:

> On Sun, Nov 15, 2020 at 11:57:25AM +0100, Stefan Weil wrote:
>> *** Setting INSTALLER no longer handled
>>
>> meson.build sets a hard name for the Windows installer executable: installer
>> = 'qemu-setup-' + meson.project_version() + '.exe'.
>>
>> Previously the installer name could be changed by running `make installer
>> INSTALLER=qemu-setup-something.exe`. This no longer works. Is there an
>> alternative solution how the name of the installer executable can be set? Or
>> how could I reimplement the lost functionality?
> Why were you needing to override the name ?  Was this so that you can
> give distinct names to the Win32 vs Win64 installer exes ?
>
> If so, would it be better if QEMU used a distinct filename for the
> Win32 vs Win64 installers automatically, to avoid need to override
> at all ?


I now use installer names like qemu-w64-setup-20201118.exe since about 6 
years, so yes, my names include w32 or w64 to show whether they contain 
32 or 64 bit binaries, and they also contain a date instead of the QEMU 
version.

For my build process I now create the default name and rename it later. 
That solves the problem for me.

Stefan





      reply	other threads:[~2020-11-18 19:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-15 10:57 Regressions in build process introduced since August Stefan Weil
2020-11-17 17:50 ` Stefano Garzarella
2020-11-17 18:01   ` Paolo Bonzini
2020-11-17 19:57     ` Stefan Weil
2020-11-21 10:25     ` Stefan Weil
2020-11-21 11:09       ` Stefan Weil
2020-11-21 11:25         ` Stefan Weil
2020-11-21 11:31           ` Paolo Bonzini
2020-11-23 13:55         ` Paolo Bonzini
2020-11-23 14:40           ` Stefan Weil
2020-11-23 15:28             ` Paolo Bonzini
2020-11-23 15:28             ` Daniel P. Berrangé
2020-11-23 15:41               ` Daniel P. Berrangé
2020-11-23 16:20                 ` Paolo Bonzini
2020-11-23 18:17                   ` Stefan Weil
2020-11-18 15:34 ` Daniel P. Berrangé
2020-11-18 19:50   ` Stefan Weil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ae1dcc4-591c-5fc2-9423-d80b9b16e777@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.