All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, Stefan Weil <sw@weilnetz.de>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: Regressions in build process introduced since August
Date: Tue, 17 Nov 2020 19:01:18 +0100	[thread overview]
Message-ID: <a6c8de1a-da41-1a4a-8907-790c2467a0b0@redhat.com> (raw)
In-Reply-To: <20201117175030.eqz5run2m7qmx5qt@steredhat>

On 17/11/20 18:50, Stefano Garzarella wrote:
> Running `configure [...] --extra-cflags="-I /xyz"` results in
> compiler flags `-I [...] /xyz`, so the `-I` and `/xyz` are separated
> by other compiler flags which obviously cannot work as expected. I
> could work around that by removing the space and using a pattern like
> `-I/xyz`.
> 
> This regression is not restricted to builds targeting Windows.

I'll take a look at fixing this (in meson).

> meson.build sets a hard name for the Windows installer executable: 
> installer = 'qemu-setup-' + meson.project_version() + '.exe'.
> 
> Previously the installer name could be changed by running `make 
> installer INSTALLER=qemu-setup-something.exe`. This no longer works.
> Is there an alternative solution how the name of the installer
> executable can be set? Or how could I reimplement the lost
> functionality?

No, there's no way to do this apart from patching meson.build.

Thanks,

Paolo



  reply	other threads:[~2020-11-17 18:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-15 10:57 Regressions in build process introduced since August Stefan Weil
2020-11-17 17:50 ` Stefano Garzarella
2020-11-17 18:01   ` Paolo Bonzini [this message]
2020-11-17 19:57     ` Stefan Weil
2020-11-21 10:25     ` Stefan Weil
2020-11-21 11:09       ` Stefan Weil
2020-11-21 11:25         ` Stefan Weil
2020-11-21 11:31           ` Paolo Bonzini
2020-11-23 13:55         ` Paolo Bonzini
2020-11-23 14:40           ` Stefan Weil
2020-11-23 15:28             ` Paolo Bonzini
2020-11-23 15:28             ` Daniel P. Berrangé
2020-11-23 15:41               ` Daniel P. Berrangé
2020-11-23 16:20                 ` Paolo Bonzini
2020-11-23 18:17                   ` Stefan Weil
2020-11-18 15:34 ` Daniel P. Berrangé
2020-11-18 19:50   ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6c8de1a-da41-1a4a-8907-790c2467a0b0@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.