All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: Regressions in build process introduced since August
Date: Sat, 21 Nov 2020 12:09:56 +0100	[thread overview]
Message-ID: <d69b024e-9762-2b27-b558-0c60b3e96811@weilnetz.de> (raw)
In-Reply-To: <ee31c6f2-19dd-f3f6-d916-f04490909dd8@weilnetz.de>

Am 21.11.20 um 11:25 schrieb Stefan Weil:

> Hi,
>
> I just noticed another regression:
>
> A cross build targeting Windows no longer detects VNC JPEG support. 
> Using pkg-config like in the patch below would fix that (and also 
> works for native builds on Debian GNU Linux).
>
> Maybe the current find_library ignores --extra-cflags and 
> --extra-ldflags? That would explain why it fails to find the required 
> header and library files. Other checks would fail then, too.
>
> Regards,
>
> Stefan
>
>
> --- a/meson.build
> +++ b/meson.build
> @@ -649,9 +649,8 @@ if get_option('vnc').enabled()
>    vnc = declare_dependency() # dummy dependency
>    png = dependency('libpng', required: get_option('vnc_png'),
>                     method: 'pkg-config', static: enable_static)
> -  jpeg = cc.find_library('jpeg', has_headers: ['jpeglib.h'],
> -                         required: get_option('vnc_jpeg'),
> -                         static: enable_static)
> +  jpeg = dependency('libpng', required: get_option('vnc_jpeg'),

Copy+paste error:

s/libpng/libjpeg/

> + method: 'pkg-config', static: enable_static)
>    sasl = cc.find_library('sasl2', has_headers: ['sasl/sasl.h'],
>                           required: get_option('vnc_sasl'),
>                           static: enable_static)


  reply	other threads:[~2020-11-21 11:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-15 10:57 Regressions in build process introduced since August Stefan Weil
2020-11-17 17:50 ` Stefano Garzarella
2020-11-17 18:01   ` Paolo Bonzini
2020-11-17 19:57     ` Stefan Weil
2020-11-21 10:25     ` Stefan Weil
2020-11-21 11:09       ` Stefan Weil [this message]
2020-11-21 11:25         ` Stefan Weil
2020-11-21 11:31           ` Paolo Bonzini
2020-11-23 13:55         ` Paolo Bonzini
2020-11-23 14:40           ` Stefan Weil
2020-11-23 15:28             ` Paolo Bonzini
2020-11-23 15:28             ` Daniel P. Berrangé
2020-11-23 15:41               ` Daniel P. Berrangé
2020-11-23 16:20                 ` Paolo Bonzini
2020-11-23 18:17                   ` Stefan Weil
2020-11-18 15:34 ` Daniel P. Berrangé
2020-11-18 19:50   ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d69b024e-9762-2b27-b558-0c60b3e96811@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.