From: Lucas Stach <l.stach@pengutronix.de> To: Robin Gong <yibin.gong@nxp.com>, vkoul@kernel.org, mark.rutland@arm.com, broonie@kernel.org, robh+dt@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, shawnguo@kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, martin.fuzzey@flowbird.group, u.kleine-koenig@pengutronix.de, dan.j.williams@intel.com, matthias.schiffer@ew.tq-group.com, frieder.schrempf@kontron.de, m.felsch@pengutronix.de, xiaoning.wang@nxp.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v14 07/12] spi: imx: fix ERR009165 Date: Fri, 09 Jul 2021 11:35:35 +0200 [thread overview] Message-ID: <6cacef63be4c6335b8bfa26043c3f787c9affd41.camel@pengutronix.de> (raw) In-Reply-To: <1617809456-17693-8-git-send-email-yibin.gong@nxp.com> Am Mittwoch, dem 07.04.2021 um 23:30 +0800 schrieb Robin Gong: > Change to XCH mode even in dma mode, please refer to the below > errata: > https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > Acked-by: Mark Brown <broonie@kernel.org> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/spi/spi-imx.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c > index 4fe767a..cf235b9 100644 > --- a/drivers/spi/spi-imx.c > +++ b/drivers/spi/spi-imx.c > @@ -593,8 +593,8 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx, > ctrl |= mx51_ecspi_clkdiv(spi_imx, t->speed_hz, &clk); > spi_imx->spi_bus_clk = clk; > > - if (spi_imx->usedma) > - ctrl |= MX51_ECSPI_CTRL_SMC; > + /* ERR009165: work in XHC mode as PIO */ > + ctrl &= ~MX51_ECSPI_CTRL_SMC; > > writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL); > > @@ -625,7 +625,7 @@ static void mx51_setup_wml(struct spi_imx_data *spi_imx) > * and enable DMA request. > */ > writel(MX51_ECSPI_DMA_RX_WML(spi_imx->wml - 1) | > - MX51_ECSPI_DMA_TX_WML(spi_imx->wml) | > + MX51_ECSPI_DMA_TX_WML(0) | > MX51_ECSPI_DMA_RXT_WML(spi_imx->wml) | > MX51_ECSPI_DMA_TEDEN | MX51_ECSPI_DMA_RXDEN | > MX51_ECSPI_DMA_RXTDEN, spi_imx->base + MX51_ECSPI_DMA); > @@ -1234,10 +1234,6 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx, > { > int ret; > > - /* use pio mode for i.mx6dl chip TKT238285 */ > - if (of_machine_is_compatible("fsl,imx6dl")) > - return 0; > - > spi_imx->wml = spi_imx->devtype_data->fifo_size / 2; > > /* Prepare for TX DMA: */
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: Robin Gong <yibin.gong@nxp.com>, vkoul@kernel.org, mark.rutland@arm.com, broonie@kernel.org, robh+dt@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, shawnguo@kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, martin.fuzzey@flowbird.group, u.kleine-koenig@pengutronix.de, dan.j.williams@intel.com, matthias.schiffer@ew.tq-group.com, frieder.schrempf@kontron.de, m.felsch@pengutronix.de, xiaoning.wang@nxp.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v14 07/12] spi: imx: fix ERR009165 Date: Fri, 09 Jul 2021 11:35:35 +0200 [thread overview] Message-ID: <6cacef63be4c6335b8bfa26043c3f787c9affd41.camel@pengutronix.de> (raw) In-Reply-To: <1617809456-17693-8-git-send-email-yibin.gong@nxp.com> Am Mittwoch, dem 07.04.2021 um 23:30 +0800 schrieb Robin Gong: > Change to XCH mode even in dma mode, please refer to the below > errata: > https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > Acked-by: Mark Brown <broonie@kernel.org> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/spi/spi-imx.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c > index 4fe767a..cf235b9 100644 > --- a/drivers/spi/spi-imx.c > +++ b/drivers/spi/spi-imx.c > @@ -593,8 +593,8 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx, > ctrl |= mx51_ecspi_clkdiv(spi_imx, t->speed_hz, &clk); > spi_imx->spi_bus_clk = clk; > > - if (spi_imx->usedma) > - ctrl |= MX51_ECSPI_CTRL_SMC; > + /* ERR009165: work in XHC mode as PIO */ > + ctrl &= ~MX51_ECSPI_CTRL_SMC; > > writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL); > > @@ -625,7 +625,7 @@ static void mx51_setup_wml(struct spi_imx_data *spi_imx) > * and enable DMA request. > */ > writel(MX51_ECSPI_DMA_RX_WML(spi_imx->wml - 1) | > - MX51_ECSPI_DMA_TX_WML(spi_imx->wml) | > + MX51_ECSPI_DMA_TX_WML(0) | > MX51_ECSPI_DMA_RXT_WML(spi_imx->wml) | > MX51_ECSPI_DMA_TEDEN | MX51_ECSPI_DMA_RXDEN | > MX51_ECSPI_DMA_RXTDEN, spi_imx->base + MX51_ECSPI_DMA); > @@ -1234,10 +1234,6 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx, > { > int ret; > > - /* use pio mode for i.mx6dl chip TKT238285 */ > - if (of_machine_is_compatible("fsl,imx6dl")) > - return 0; > - > spi_imx->wml = spi_imx->devtype_data->fifo_size / 2; > > /* Prepare for TX DMA: */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-09 9:35 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-07 15:30 [PATCH v14 00/12] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 03/12] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:24 ` Lucas Stach 2021-07-09 9:24 ` Lucas Stach 2021-07-12 3:20 ` Robin Gong 2021-07-12 3:20 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:32 ` Lucas Stach 2021-07-09 9:32 ` Lucas Stach 2021-04-07 15:30 ` [PATCH v14 07/12] spi: imx: fix ERR009165 Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:35 ` Lucas Stach [this message] 2021-07-09 9:35 ` Lucas Stach 2021-04-07 15:30 ` [PATCH v14 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:41 ` Lucas Stach 2021-07-09 9:41 ` Lucas Stach 2021-07-12 3:48 ` Robin Gong 2021-07-12 3:48 ` Robin Gong 2021-07-12 9:30 ` Lucas Stach 2021-07-12 9:30 ` Lucas Stach 2021-07-13 9:12 ` Robin Gong 2021-07-13 9:12 ` Robin Gong 2021-07-13 9:30 ` Lucas Stach 2021-07-13 9:30 ` Lucas Stach 2021-04-07 15:30 ` [PATCH v14 09/12] dmaengine: imx-sdma: remove ERR009165 " Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:44 ` Lucas Stach 2021-07-09 9:44 ` Lucas Stach 2021-07-12 4:03 ` Robin Gong 2021-07-12 4:03 ` Robin Gong 2021-07-12 9:33 ` Lucas Stach 2021-07-12 9:33 ` Lucas Stach 2021-07-13 9:14 ` Robin Gong 2021-07-13 9:14 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 10/12] dma: imx-sdma: add i.mx6ul compatible name Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 11/12] dmaengine: imx-sdma: add uart rom script Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:55 ` Lucas Stach 2021-07-09 9:55 ` Lucas Stach 2021-04-07 15:30 ` [PATCH v14 12/12] dmaengine: imx-sdma: add terminated list for freed descriptor in worker Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-12 9:39 ` Vinod Koul 2021-04-12 9:39 ` Vinod Koul 2021-04-13 5:05 ` Robin Gong 2021-04-13 5:05 ` Robin Gong 2021-06-15 6:06 ` Vinod Koul 2021-06-15 6:06 ` Vinod Koul 2021-07-09 9:55 ` Lucas Stach 2021-07-09 9:55 ` Lucas Stach 2021-06-11 13:51 ` [PATCH v14 00/12] add ecspi ERR009165 for i.mx6/7 soc family Fabio Estevam 2021-06-11 13:51 ` Fabio Estevam 2021-06-15 1:55 ` Robin Gong 2021-06-15 1:55 ` Robin Gong 2021-06-15 6:07 ` Vinod Koul 2021-06-15 6:07 ` Vinod Koul 2021-06-15 6:36 ` Robin Gong 2021-06-15 6:36 ` Robin Gong 2021-06-15 12:07 ` Vinod Koul 2021-06-15 12:07 ` Vinod Koul 2021-06-15 14:10 ` Robin Gong 2021-06-15 14:10 ` Robin Gong 2021-06-16 10:16 ` Vinod Koul 2021-06-16 10:16 ` Vinod Koul 2021-06-16 10:44 ` Robin Gong 2021-06-16 10:44 ` Robin Gong 2021-06-15 2:12 ` Fabio Estevam 2021-06-15 2:12 ` Fabio Estevam 2021-06-15 2:17 ` Robin Gong 2021-06-15 2:17 ` Robin Gong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6cacef63be4c6335b8bfa26043c3f787c9affd41.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=frieder.schrempf@kontron.de \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=m.felsch@pengutronix.de \ --cc=mark.rutland@arm.com \ --cc=martin.fuzzey@flowbird.group \ --cc=matthias.schiffer@ew.tq-group.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=vkoul@kernel.org \ --cc=will.deacon@arm.com \ --cc=xiaoning.wang@nxp.com \ --cc=yibin.gong@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.