From: Robin Gong <yibin.gong@nxp.com> To: Lucas Stach <l.stach@pengutronix.de>, "vkoul@kernel.org" <vkoul@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "broonie@kernel.org" <broonie@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "will.deacon@arm.com" <will.deacon@arm.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "festevam@gmail.com" <festevam@gmail.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "martin.fuzzey@flowbird.group" <martin.fuzzey@flowbird.group>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "dan.j.williams@intel.com" <dan.j.williams@intel.com>, "matthias.schiffer@ew.tq-group.com" <matthias.schiffer@ew.tq-group.com>, "frieder.schrempf@kontron.de" <frieder.schrempf@kontron.de>, "m.felsch@pengutronix.de" <m.felsch@pengutronix.de>, Clark Wang <xiaoning.wang@nxp.com> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH v14 09/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Date: Tue, 13 Jul 2021 09:14:42 +0000 [thread overview] Message-ID: <VE1PR04MB6688E4BEA6B45A40C46DDEC689149@VE1PR04MB6688.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1159a6b7f30402b07aaa5654bd98bfaa95457960.camel@pengutronix.de> On 12/07/21 17:33 Lucas Stach <l.stach@pengutronix.de> wrote: > Am Montag, dem 12.07.2021 um 04:03 +0000 schrieb Robin Gong: > > On 09/07/21 17:45 Lucas Stach <l.stach@pengutronix.de> wrote: > > > Am Mittwoch, dem 07.04.2021 um 23:30 +0800 schrieb Robin Gong: > > > > ECSPI issue fixed from i.mx6ul at hardware level, no need > > > > ERR009165 anymore on those chips such as i.mx8mq. > > > > > > > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > > > > Acked-by: Vinod Koul <vkoul@kernel.org> > > > > --- > > > > drivers/dma/imx-sdma.c | 26 +++++++++++++++++++++++++- > > > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index > > > > 86bd383..af85116 100644 > > > > --- a/drivers/dma/imx-sdma.c > > > > +++ b/drivers/dma/imx-sdma.c > > > > @@ -422,6 +422,13 @@ struct sdma_driver_data { > > > > int num_events; > > > > struct sdma_script_start_addrs *script_addrs; > > > > bool check_ratio; > > > > + /* > > > > + * ecspi ERR009165 fixed should be done in sdma script > > > > + * and it has been fixed in soc from i.mx6ul. > > > > + * please get more information from the below link: > > > > + * > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww > > > w.n > xp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&data=04%7C01%7C > > > > yibin.gong%40nxp.com%7Cc950b1bdb6544eda369408d942be35d9%7C686ea > > > > 1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637614206980361737%7CU > > > > nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6 > > > > Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=6iT6%2FbzJHyWnkhkDynY > > > wmK9nn2hgCDy1GyzELeEk9K8%3D&reserved=0 > > > > + */ > > > > + bool ecspi_fixed; > > > > }; > > > > > > > > struct sdma_engine { > > > > @@ -542,6 +549,13 @@ static struct sdma_driver_data sdma_imx6q = { > > > > .script_addrs = &sdma_script_imx6q, }; > > > > > > > > +static struct sdma_driver_data sdma_imx6ul = { > > > > + .chnenbl0 = SDMA_CHNENBL0_IMX35, > > > > + .num_events = 48, > > > > + .script_addrs = &sdma_script_imx6q, > > > > + .ecspi_fixed = true, > > > > +}; > > > > + > > > > static struct sdma_script_start_addrs sdma_script_imx7d = { > > > > .ap_2_ap_addr = 644, > > > > .uart_2_mcu_addr = 819, > > > > @@ -575,6 +589,7 @@ static const struct of_device_id sdma_dt_ids[] = { > > > > { .compatible = "fsl,imx31-sdma", .data = &sdma_imx31, }, > > > > { .compatible = "fsl,imx25-sdma", .data = &sdma_imx25, }, > > > > { .compatible = "fsl,imx7d-sdma", .data = &sdma_imx7d, }, > > > > + { .compatible = "fsl,imx6ul-sdma", .data = &sdma_imx6ul, }, > > > > { .compatible = "fsl,imx8mq-sdma", .data = &sdma_imx8mq, }, > > > > { /* sentinel */ } > > > > }; > > > > @@ -1144,8 +1159,17 @@ static int sdma_config_channel(struct > > > > dma_chan > > > *chan) > > > > if (sdmac->peripheral_type == IMX_DMATYPE_ASRC_SP || > > > > sdmac->peripheral_type == IMX_DMATYPE_ASRC) > > > > sdma_set_watermarklevel_for_p2p(sdmac); > > > > - } else > > > > + } else { > > > > + /* > > > > + * ERR009165 fixed from i.mx6ul, no errata need, > > > > + * set bit31 to let sdma script skip the errata. > > > > + */ > > > > + if (sdmac->peripheral_type == IMX_DMATYPE_CSPI && > > > > + sdmac->direction == DMA_MEM_TO_DEV && > > > > + sdmac->sdma->drvdata->ecspi_fixed) > > > > + __set_bit(31, &sdmac->watermark_level); > > > > > > Hm, I don't care much either way, but couldn't we just return the > > > regular mcu_2_app script in sdma_get_pc when ecspi_fixed == true? > > > Seems like this would be a simpler and more targeted code change. > > Yes, return mcu_2_app if ecspi_fixed == true also works, but since > > sdma firmware have already been here to fix ERR009165 on most of > > legacy i.mx6/7/8 chips, so choosing firmware/ram script to do like > > ROM/mcu_2_app is okay too since both ram script and rom script in case of > ecspi_fixed are almost same. > > > Actually, while thinking some more about this: it is preferable to return > mcu_2_app in the ecspi_fixed case, as this allows proper DMA support on the > fixed SoCs without loading the firmware. The way you do it here still requires > the RAM firmware to be loaded in order to get DMA support at all. Okay, will change to mcu_2_app v15. > > > > > > > > > __set_bit(sdmac->event_id0, sdmac->event_mask); > > > > + } > > > > > > > > /* Address */ > > > > sdmac->shp_addr = sdmac->per_address; > > > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Robin Gong <yibin.gong@nxp.com> To: Lucas Stach <l.stach@pengutronix.de>, "vkoul@kernel.org" <vkoul@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "broonie@kernel.org" <broonie@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "will.deacon@arm.com" <will.deacon@arm.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "festevam@gmail.com" <festevam@gmail.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "martin.fuzzey@flowbird.group" <martin.fuzzey@flowbird.group>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "dan.j.williams@intel.com" <dan.j.williams@intel.com>, "matthias.schiffer@ew.tq-group.com" <matthias.schiffer@ew.tq-group.com>, "frieder.schrempf@kontron.de" <frieder.schrempf@kontron.de>, "m.felsch@pengutronix.de" <m.felsch@pengutronix.de>, Clark Wang <xiaoning.wang@nxp.com> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH v14 09/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Date: Tue, 13 Jul 2021 09:14:42 +0000 [thread overview] Message-ID: <VE1PR04MB6688E4BEA6B45A40C46DDEC689149@VE1PR04MB6688.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1159a6b7f30402b07aaa5654bd98bfaa95457960.camel@pengutronix.de> On 12/07/21 17:33 Lucas Stach <l.stach@pengutronix.de> wrote: > Am Montag, dem 12.07.2021 um 04:03 +0000 schrieb Robin Gong: > > On 09/07/21 17:45 Lucas Stach <l.stach@pengutronix.de> wrote: > > > Am Mittwoch, dem 07.04.2021 um 23:30 +0800 schrieb Robin Gong: > > > > ECSPI issue fixed from i.mx6ul at hardware level, no need > > > > ERR009165 anymore on those chips such as i.mx8mq. > > > > > > > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > > > > Acked-by: Vinod Koul <vkoul@kernel.org> > > > > --- > > > > drivers/dma/imx-sdma.c | 26 +++++++++++++++++++++++++- > > > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index > > > > 86bd383..af85116 100644 > > > > --- a/drivers/dma/imx-sdma.c > > > > +++ b/drivers/dma/imx-sdma.c > > > > @@ -422,6 +422,13 @@ struct sdma_driver_data { > > > > int num_events; > > > > struct sdma_script_start_addrs *script_addrs; > > > > bool check_ratio; > > > > + /* > > > > + * ecspi ERR009165 fixed should be done in sdma script > > > > + * and it has been fixed in soc from i.mx6ul. > > > > + * please get more information from the below link: > > > > + * > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww > > > w.n > xp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&data=04%7C01%7C > > > > yibin.gong%40nxp.com%7Cc950b1bdb6544eda369408d942be35d9%7C686ea > > > > 1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637614206980361737%7CU > > > > nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6 > > > > Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=6iT6%2FbzJHyWnkhkDynY > > > wmK9nn2hgCDy1GyzELeEk9K8%3D&reserved=0 > > > > + */ > > > > + bool ecspi_fixed; > > > > }; > > > > > > > > struct sdma_engine { > > > > @@ -542,6 +549,13 @@ static struct sdma_driver_data sdma_imx6q = { > > > > .script_addrs = &sdma_script_imx6q, }; > > > > > > > > +static struct sdma_driver_data sdma_imx6ul = { > > > > + .chnenbl0 = SDMA_CHNENBL0_IMX35, > > > > + .num_events = 48, > > > > + .script_addrs = &sdma_script_imx6q, > > > > + .ecspi_fixed = true, > > > > +}; > > > > + > > > > static struct sdma_script_start_addrs sdma_script_imx7d = { > > > > .ap_2_ap_addr = 644, > > > > .uart_2_mcu_addr = 819, > > > > @@ -575,6 +589,7 @@ static const struct of_device_id sdma_dt_ids[] = { > > > > { .compatible = "fsl,imx31-sdma", .data = &sdma_imx31, }, > > > > { .compatible = "fsl,imx25-sdma", .data = &sdma_imx25, }, > > > > { .compatible = "fsl,imx7d-sdma", .data = &sdma_imx7d, }, > > > > + { .compatible = "fsl,imx6ul-sdma", .data = &sdma_imx6ul, }, > > > > { .compatible = "fsl,imx8mq-sdma", .data = &sdma_imx8mq, }, > > > > { /* sentinel */ } > > > > }; > > > > @@ -1144,8 +1159,17 @@ static int sdma_config_channel(struct > > > > dma_chan > > > *chan) > > > > if (sdmac->peripheral_type == IMX_DMATYPE_ASRC_SP || > > > > sdmac->peripheral_type == IMX_DMATYPE_ASRC) > > > > sdma_set_watermarklevel_for_p2p(sdmac); > > > > - } else > > > > + } else { > > > > + /* > > > > + * ERR009165 fixed from i.mx6ul, no errata need, > > > > + * set bit31 to let sdma script skip the errata. > > > > + */ > > > > + if (sdmac->peripheral_type == IMX_DMATYPE_CSPI && > > > > + sdmac->direction == DMA_MEM_TO_DEV && > > > > + sdmac->sdma->drvdata->ecspi_fixed) > > > > + __set_bit(31, &sdmac->watermark_level); > > > > > > Hm, I don't care much either way, but couldn't we just return the > > > regular mcu_2_app script in sdma_get_pc when ecspi_fixed == true? > > > Seems like this would be a simpler and more targeted code change. > > Yes, return mcu_2_app if ecspi_fixed == true also works, but since > > sdma firmware have already been here to fix ERR009165 on most of > > legacy i.mx6/7/8 chips, so choosing firmware/ram script to do like > > ROM/mcu_2_app is okay too since both ram script and rom script in case of > ecspi_fixed are almost same. > > > Actually, while thinking some more about this: it is preferable to return > mcu_2_app in the ecspi_fixed case, as this allows proper DMA support on the > fixed SoCs without loading the firmware. The way you do it here still requires > the RAM firmware to be loaded in order to get DMA support at all. Okay, will change to mcu_2_app v15. > > > > > > > > > __set_bit(sdmac->event_id0, sdmac->event_mask); > > > > + } > > > > > > > > /* Address */ > > > > sdmac->shp_addr = sdmac->per_address; > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-13 9:14 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-07 15:30 [PATCH v14 00/12] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 03/12] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:24 ` Lucas Stach 2021-07-09 9:24 ` Lucas Stach 2021-07-12 3:20 ` Robin Gong 2021-07-12 3:20 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:32 ` Lucas Stach 2021-07-09 9:32 ` Lucas Stach 2021-04-07 15:30 ` [PATCH v14 07/12] spi: imx: fix ERR009165 Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:35 ` Lucas Stach 2021-07-09 9:35 ` Lucas Stach 2021-04-07 15:30 ` [PATCH v14 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:41 ` Lucas Stach 2021-07-09 9:41 ` Lucas Stach 2021-07-12 3:48 ` Robin Gong 2021-07-12 3:48 ` Robin Gong 2021-07-12 9:30 ` Lucas Stach 2021-07-12 9:30 ` Lucas Stach 2021-07-13 9:12 ` Robin Gong 2021-07-13 9:12 ` Robin Gong 2021-07-13 9:30 ` Lucas Stach 2021-07-13 9:30 ` Lucas Stach 2021-04-07 15:30 ` [PATCH v14 09/12] dmaengine: imx-sdma: remove ERR009165 " Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:44 ` Lucas Stach 2021-07-09 9:44 ` Lucas Stach 2021-07-12 4:03 ` Robin Gong 2021-07-12 4:03 ` Robin Gong 2021-07-12 9:33 ` Lucas Stach 2021-07-12 9:33 ` Lucas Stach 2021-07-13 9:14 ` Robin Gong [this message] 2021-07-13 9:14 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 10/12] dma: imx-sdma: add i.mx6ul compatible name Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-07 15:30 ` [PATCH v14 11/12] dmaengine: imx-sdma: add uart rom script Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-07-09 9:55 ` Lucas Stach 2021-07-09 9:55 ` Lucas Stach 2021-04-07 15:30 ` [PATCH v14 12/12] dmaengine: imx-sdma: add terminated list for freed descriptor in worker Robin Gong 2021-04-07 15:30 ` Robin Gong 2021-04-12 9:39 ` Vinod Koul 2021-04-12 9:39 ` Vinod Koul 2021-04-13 5:05 ` Robin Gong 2021-04-13 5:05 ` Robin Gong 2021-06-15 6:06 ` Vinod Koul 2021-06-15 6:06 ` Vinod Koul 2021-07-09 9:55 ` Lucas Stach 2021-07-09 9:55 ` Lucas Stach 2021-06-11 13:51 ` [PATCH v14 00/12] add ecspi ERR009165 for i.mx6/7 soc family Fabio Estevam 2021-06-11 13:51 ` Fabio Estevam 2021-06-15 1:55 ` Robin Gong 2021-06-15 1:55 ` Robin Gong 2021-06-15 6:07 ` Vinod Koul 2021-06-15 6:07 ` Vinod Koul 2021-06-15 6:36 ` Robin Gong 2021-06-15 6:36 ` Robin Gong 2021-06-15 12:07 ` Vinod Koul 2021-06-15 12:07 ` Vinod Koul 2021-06-15 14:10 ` Robin Gong 2021-06-15 14:10 ` Robin Gong 2021-06-16 10:16 ` Vinod Koul 2021-06-16 10:16 ` Vinod Koul 2021-06-16 10:44 ` Robin Gong 2021-06-16 10:44 ` Robin Gong 2021-06-15 2:12 ` Fabio Estevam 2021-06-15 2:12 ` Fabio Estevam 2021-06-15 2:17 ` Robin Gong 2021-06-15 2:17 ` Robin Gong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VE1PR04MB6688E4BEA6B45A40C46DDEC689149@VE1PR04MB6688.eurprd04.prod.outlook.com \ --to=yibin.gong@nxp.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=frieder.schrempf@kontron.de \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=m.felsch@pengutronix.de \ --cc=mark.rutland@arm.com \ --cc=martin.fuzzey@flowbird.group \ --cc=matthias.schiffer@ew.tq-group.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=vkoul@kernel.org \ --cc=will.deacon@arm.com \ --cc=xiaoning.wang@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.