* [PATCH] Monotonic time test: Don't force static compilation of time_test
@ 2010-03-23 18:13 Lucas Meneghel Rodrigues
2010-03-23 18:25 ` Martin Bligh
0 siblings, 1 reply; 6+ messages in thread
From: Lucas Meneghel Rodrigues @ 2010-03-23 18:13 UTC (permalink / raw)
To: autotest; +Cc: kvm
The Makefile for the monotonic_test C program forces static
compilation of the object files. Since we are compiling the
code already, not having a static binary doesn't make much
of a difference on the systems we are running this test.
As the static compilation might fail in some boxes, just remove
this constraint from the Makefile.
Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
---
client/tests/monotonic_time/src/Makefile | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/client/tests/monotonic_time/src/Makefile b/client/tests/monotonic_time/src/Makefile
index 56aa7b6..2121ec4 100644
--- a/client/tests/monotonic_time/src/Makefile
+++ b/client/tests/monotonic_time/src/Makefile
@@ -1,7 +1,6 @@
CC= cc
CFLAGS= -O -std=gnu99 -Wall
-LDFLAGS=-static
LIBS= -lpthread -lrt
PROG= time_test
--
1.6.6.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Monotonic time test: Don't force static compilation of time_test
2010-03-23 18:13 [PATCH] Monotonic time test: Don't force static compilation of time_test Lucas Meneghel Rodrigues
@ 2010-03-23 18:25 ` Martin Bligh
2010-03-23 20:13 ` Michael Davidson
2010-03-23 20:56 ` [Autotest] " Lucas Meneghel Rodrigues
0 siblings, 2 replies; 6+ messages in thread
From: Martin Bligh @ 2010-03-23 18:25 UTC (permalink / raw)
To: Lucas Meneghel Rodrigues; +Cc: autotest, Michael Davidson, kvm
+cc:md (he wrote the test).
On Tue, Mar 23, 2010 at 11:13 AM, Lucas Meneghel Rodrigues
<lmr@redhat.com> wrote:
> The Makefile for the monotonic_test C program forces static
> compilation of the object files. Since we are compiling the
> code already, not having a static binary doesn't make much
> of a difference on the systems we are running this test.
>
> As the static compilation might fail in some boxes, just remove
> this constraint from the Makefile.
I presume this was to fix some Google interdependency.
Is it actually breaking something? If not, seems safer to leave it?
If so, we'll have to fix one end or the other ;-)
> Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
> ---
> client/tests/monotonic_time/src/Makefile | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/client/tests/monotonic_time/src/Makefile b/client/tests/monotonic_time/src/Makefile
> index 56aa7b6..2121ec4 100644
> --- a/client/tests/monotonic_time/src/Makefile
> +++ b/client/tests/monotonic_time/src/Makefile
> @@ -1,7 +1,6 @@
> CC= cc
>
> CFLAGS= -O -std=gnu99 -Wall
> -LDFLAGS=-static
> LIBS= -lpthread -lrt
>
> PROG= time_test
> --
> 1.6.6.1
>
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Monotonic time test: Don't force static compilation of time_test
2010-03-23 18:25 ` Martin Bligh
@ 2010-03-23 20:13 ` Michael Davidson
2010-03-23 20:56 ` [Autotest] " Lucas Meneghel Rodrigues
1 sibling, 0 replies; 6+ messages in thread
From: Michael Davidson @ 2010-03-23 20:13 UTC (permalink / raw)
To: Martin Bligh; +Cc: autotest, kvm
[-- Attachment #1.1: Type: text/plain, Size: 1944 bytes --]
This sounds fine to me - since the test is normally being built on the
machine on which it is going to be run there is no need to build a
static linked binary.
I suspect that the --static in the Makefile is just a throwback to some
point in time at which I was building the test on a development machine
and running it on a number of test systems which were not guaranteed
to have a compatible set of shared libraries on them,
md
On Tue, Mar 23, 2010 at 11:25 AM, Martin Bligh <mbligh@google.com> wrote:
> +cc:md (he wrote the test).
>
> On Tue, Mar 23, 2010 at 11:13 AM, Lucas Meneghel Rodrigues
> <lmr@redhat.com> wrote:
> > The Makefile for the monotonic_test C program forces static
> > compilation of the object files. Since we are compiling the
> > code already, not having a static binary doesn't make much
> > of a difference on the systems we are running this test.
> >
> > As the static compilation might fail in some boxes, just remove
> > this constraint from the Makefile.
>
> I presume this was to fix some Google interdependency.
> Is it actually breaking something? If not, seems safer to leave it?
> If so, we'll have to fix one end or the other ;-)
>
> > Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
> > ---
> > client/tests/monotonic_time/src/Makefile | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/client/tests/monotonic_time/src/Makefile
> b/client/tests/monotonic_time/src/Makefile
> > index 56aa7b6..2121ec4 100644
> > --- a/client/tests/monotonic_time/src/Makefile
> > +++ b/client/tests/monotonic_time/src/Makefile
> > @@ -1,7 +1,6 @@
> > CC= cc
> >
> > CFLAGS= -O -std=gnu99 -Wall
> > -LDFLAGS=-static
> > LIBS= -lpthread -lrt
> >
> > PROG= time_test
> > --
> > 1.6.6.1
> >
> > _______________________________________________
> > Autotest mailing list
> > Autotest@test.kernel.org
> > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
> >
>
[-- Attachment #1.2: Type: text/html, Size: 2675 bytes --]
[-- Attachment #2: Type: text/plain, Size: 152 bytes --]
_______________________________________________
Autotest mailing list
Autotest@test.kernel.org
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Autotest] [PATCH] Monotonic time test: Don't force static compilation of time_test
2010-03-23 18:25 ` Martin Bligh
2010-03-23 20:13 ` Michael Davidson
@ 2010-03-23 20:56 ` Lucas Meneghel Rodrigues
2010-03-23 21:15 ` Martin Bligh
2010-03-24 1:16 ` Jason Wang
1 sibling, 2 replies; 6+ messages in thread
From: Lucas Meneghel Rodrigues @ 2010-03-23 20:56 UTC (permalink / raw)
To: Martin Bligh; +Cc: autotest, Michael Davidson, kvm
On Tue, Mar 23, 2010 at 3:25 PM, Martin Bligh <mbligh@google.com> wrote:
> +cc:md (he wrote the test).
>
> On Tue, Mar 23, 2010 at 11:13 AM, Lucas Meneghel Rodrigues
> <lmr@redhat.com> wrote:
>> The Makefile for the monotonic_test C program forces static
>> compilation of the object files. Since we are compiling the
>> code already, not having a static binary doesn't make much
>> of a difference on the systems we are running this test.
>>
>> As the static compilation might fail in some boxes, just remove
>> this constraint from the Makefile.
>
> I presume this was to fix some Google interdependency.
> Is it actually breaking something? If not, seems safer to leave it?
> If so, we'll have to fix one end or the other ;-)
Yes, I can't get a static build on a Fedora 13 box by no means, that's
why I looked into what was going wrong and cooked this patch. If
someone has any suggestions of what I need to do to work around this,
let me know.
>> Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
>> ---
>> client/tests/monotonic_time/src/Makefile | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/client/tests/monotonic_time/src/Makefile b/client/tests/monotonic_time/src/Makefile
>> index 56aa7b6..2121ec4 100644
>> --- a/client/tests/monotonic_time/src/Makefile
>> +++ b/client/tests/monotonic_time/src/Makefile
>> @@ -1,7 +1,6 @@
>> CC= cc
>>
>> CFLAGS= -O -std=gnu99 -Wall
>> -LDFLAGS=-static
>> LIBS= -lpthread -lrt
>>
>> PROG= time_test
>> --
>> 1.6.6.1
>>
>> _______________________________________________
>> Autotest mailing list
>> Autotest@test.kernel.org
>> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>>
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>
--
Lucas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Autotest] [PATCH] Monotonic time test: Don't force static compilation of time_test
2010-03-23 20:56 ` [Autotest] " Lucas Meneghel Rodrigues
@ 2010-03-23 21:15 ` Martin Bligh
2010-03-24 1:16 ` Jason Wang
1 sibling, 0 replies; 6+ messages in thread
From: Martin Bligh @ 2010-03-23 21:15 UTC (permalink / raw)
To: Lucas Meneghel Rodrigues; +Cc: autotest, Michael Davidson, kvm
On Tue, Mar 23, 2010 at 1:56 PM, Lucas Meneghel Rodrigues
<lmr@redhat.com> wrote:
> On Tue, Mar 23, 2010 at 3:25 PM, Martin Bligh <mbligh@google.com> wrote:
>> +cc:md (he wrote the test).
>>
>> On Tue, Mar 23, 2010 at 11:13 AM, Lucas Meneghel Rodrigues
>> <lmr@redhat.com> wrote:
>>> The Makefile for the monotonic_test C program forces static
>>> compilation of the object files. Since we are compiling the
>>> code already, not having a static binary doesn't make much
>>> of a difference on the systems we are running this test.
>>>
>>> As the static compilation might fail in some boxes, just remove
>>> this constraint from the Makefile.
>>
>> I presume this was to fix some Google interdependency.
>> Is it actually breaking something? If not, seems safer to leave it?
>> If so, we'll have to fix one end or the other ;-)
>
> Yes, I can't get a static build on a Fedora 13 box by no means, that's
> why I looked into what was going wrong and cooked this patch. If
> someone has any suggestions of what I need to do to work around this,
> let me know.
OK, sounds like Michael is happy - and there's a real problem to fix.
LGTM - go ahead and apply it.
Thanks,
M.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Autotest] [PATCH] Monotonic time test: Don't force static compilation of time_test
2010-03-23 20:56 ` [Autotest] " Lucas Meneghel Rodrigues
2010-03-23 21:15 ` Martin Bligh
@ 2010-03-24 1:16 ` Jason Wang
1 sibling, 0 replies; 6+ messages in thread
From: Jason Wang @ 2010-03-24 1:16 UTC (permalink / raw)
To: Lucas Meneghel Rodrigues; +Cc: Martin Bligh, autotest, Michael Davidson, kvm
Lucas Meneghel Rodrigues wrote:
> On Tue, Mar 23, 2010 at 3:25 PM, Martin Bligh <mbligh@google.com> wrote:
>
>> +cc:md (he wrote the test).
>>
>> On Tue, Mar 23, 2010 at 11:13 AM, Lucas Meneghel Rodrigues
>> <lmr@redhat.com> wrote:
>>
>>> The Makefile for the monotonic_test C program forces static
>>> compilation of the object files. Since we are compiling the
>>> code already, not having a static binary doesn't make much
>>> of a difference on the systems we are running this test.
>>>
>>> As the static compilation might fail in some boxes, just remove
>>> this constraint from the Makefile.
>>>
>> I presume this was to fix some Google interdependency.
>> Is it actually breaking something? If not, seems safer to leave it?
>> If so, we'll have to fix one end or the other ;-)
>>
>
> Yes, I can't get a static build on a Fedora 13 box by no means, that's
> why I looked into what was going wrong and cooked this patch. If
> someone has any suggestions of what I need to do to work around this,
> let me know.
>
>
I met the same problem and there should be no difference when not using
the static build.
>>> Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
>>> ---
>>> client/tests/monotonic_time/src/Makefile | 1 -
>>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/client/tests/monotonic_time/src/Makefile b/client/tests/monotonic_time/src/Makefile
>>> index 56aa7b6..2121ec4 100644
>>> --- a/client/tests/monotonic_time/src/Makefile
>>> +++ b/client/tests/monotonic_time/src/Makefile
>>> @@ -1,7 +1,6 @@
>>> CC= cc
>>>
>>> CFLAGS= -O -std=gnu99 -Wall
>>> -LDFLAGS=-static
>>> LIBS= -lpthread -lrt
>>>
>>> PROG= time_test
>>> --
>>> 1.6.6.1
>>>
>>> _______________________________________________
>>> Autotest mailing list
>>> Autotest@test.kernel.org
>>> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>>>
>>>
>> _______________________________________________
>> Autotest mailing list
>> Autotest@test.kernel.org
>> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>>
>>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-03-24 1:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-23 18:13 [PATCH] Monotonic time test: Don't force static compilation of time_test Lucas Meneghel Rodrigues
2010-03-23 18:25 ` Martin Bligh
2010-03-23 20:13 ` Michael Davidson
2010-03-23 20:56 ` [Autotest] " Lucas Meneghel Rodrigues
2010-03-23 21:15 ` Martin Bligh
2010-03-24 1:16 ` Jason Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.