From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Eric Blake <eblake@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>,
"mlevitsk@redhat.com" <mlevitsk@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: Re: [PATCH v3 2/4] bitmap: Enforce maximum bitmap name length
Date: Fri, 15 Nov 2019 15:47:03 +0000 [thread overview]
Message-ID: <6d54c6eb-4f28-6a5d-81e1-a175e34f3cf8@virtuozzo.com> (raw)
In-Reply-To: <0a25974f-f9cd-07a1-4cb7-2bbd4dfe4375@virtuozzo.com>
15.11.2019 18:03, Vladimir Sementsov-Ogievskiy wrote:
> 14.11.2019 5:46, Eric Blake wrote:
>> We document that for qcow2 persistent bitmaps, the name cannot exceed
>> 1023 bytes. It is inconsistent if transient bitmaps do not have to
>> abide by the same limit, and it is unlikely that any existing client
>> even cares about using bitmap names this long. It's time to codify
>> that ALL bitmaps managed by qemu (whether persistent in qcow2 or not)
>> have a documented maximum length.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
>
One doubt:
Is it good idea to include string larger than 4K into error message
(in next patch too)? I doubt that such message would be
readable, and I think that most possible source of such message is
some kind of memory corruption, so the whole message would be garbage,
which may contain special symbols which may look bad or even break
output.
--
Best regards,
Vladimir
next prev parent reply other threads:[~2019-11-15 15:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 2:46 [PATCH v3 for-4.2 0/4] Better NBD string length handling Eric Blake
2019-11-14 2:46 ` [PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names Eric Blake
2019-11-14 2:59 ` Eric Blake
2019-11-14 10:04 ` Maxim Levitsky
2019-11-14 13:33 ` Eric Blake
2019-11-15 15:15 ` Maxim Levitsky
2019-11-15 14:59 ` Vladimir Sementsov-Ogievskiy
2019-11-14 2:46 ` [PATCH v3 2/4] bitmap: Enforce maximum bitmap name length Eric Blake
2019-11-14 10:04 ` Maxim Levitsky
2019-11-15 15:04 ` Vladimir Sementsov-Ogievskiy
2019-11-15 15:47 ` Vladimir Sementsov-Ogievskiy [this message]
2019-11-15 16:33 ` Eric Blake
2019-11-15 17:09 ` Vladimir Sementsov-Ogievskiy
2019-11-14 2:46 ` [PATCH v3 3/4] nbd: Don't send oversize strings Eric Blake
2019-11-14 10:04 ` Maxim Levitsky
2019-11-15 17:08 ` Vladimir Sementsov-Ogievskiy
2019-11-15 21:30 ` Eric Blake
2019-11-14 2:46 ` [PATCH v3 for-5.0 4/4] nbd: Allow description when creating NBD blockdev Eric Blake
2019-11-14 2:57 ` [PATCH v3 for-4.2 0/4] Better NBD string length handling no-reply
2019-11-14 3:00 ` no-reply
2019-11-14 3:04 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d54c6eb-4f28-6a5d-81e1-a175e34f3cf8@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.