From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: vsementsov@virtuozzo.com, qemu-block@nongnu.org, mlevitsk@redhat.com
Subject: Re: [PATCH v3 for-4.2 0/4] Better NBD string length handling
Date: Wed, 13 Nov 2019 21:04:22 -0600 [thread overview]
Message-ID: <bd14b1ba-07a8-6194-fa7a-4f61b77675e9@redhat.com> (raw)
In-Reply-To: <157370043192.25875.12348439356190898901@37313f22b938>
On 11/13/19 9:00 PM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20191114024635.11363-1-eblake@redhat.com/
>
>
> from /tmp/qemu-test/src/include/qemu/osdep.h:140,
> from /tmp/qemu-test/src/nbd/server.c:20:
> /tmp/qemu-test/src/nbd/server.c: In function 'nbd_negotiate_handle_export_name':
> /usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: 'name' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> g_free (*pp);
> ^~~~~~~~~~~~
> /tmp/qemu-test/src/nbd/server.c:435:22: note: 'name' was declared here
> g_autofree char *name;
> ^~~~
Ha - I posted the fix to that one minute before patchew flagged it.
Still, I'm not sure why my gcc didn't flag this locally, while the mingw
builder did.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2019-11-14 3:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 2:46 [PATCH v3 for-4.2 0/4] Better NBD string length handling Eric Blake
2019-11-14 2:46 ` [PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names Eric Blake
2019-11-14 2:59 ` Eric Blake
2019-11-14 10:04 ` Maxim Levitsky
2019-11-14 13:33 ` Eric Blake
2019-11-15 15:15 ` Maxim Levitsky
2019-11-15 14:59 ` Vladimir Sementsov-Ogievskiy
2019-11-14 2:46 ` [PATCH v3 2/4] bitmap: Enforce maximum bitmap name length Eric Blake
2019-11-14 10:04 ` Maxim Levitsky
2019-11-15 15:04 ` Vladimir Sementsov-Ogievskiy
2019-11-15 15:47 ` Vladimir Sementsov-Ogievskiy
2019-11-15 16:33 ` Eric Blake
2019-11-15 17:09 ` Vladimir Sementsov-Ogievskiy
2019-11-14 2:46 ` [PATCH v3 3/4] nbd: Don't send oversize strings Eric Blake
2019-11-14 10:04 ` Maxim Levitsky
2019-11-15 17:08 ` Vladimir Sementsov-Ogievskiy
2019-11-15 21:30 ` Eric Blake
2019-11-14 2:46 ` [PATCH v3 for-5.0 4/4] nbd: Allow description when creating NBD blockdev Eric Blake
2019-11-14 2:57 ` [PATCH v3 for-4.2 0/4] Better NBD string length handling no-reply
2019-11-14 3:00 ` no-reply
2019-11-14 3:04 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd14b1ba-07a8-6194-fa7a-4f61b77675e9@redhat.com \
--to=eblake@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.