* [Question Resend] About z3fold page migration
@ 2020-10-12 14:00 linmiaohe
2020-10-12 14:04 ` Matthew Wilcox
0 siblings, 1 reply; 3+ messages in thread
From: linmiaohe @ 2020-10-12 14:00 UTC (permalink / raw)
To: akpm, Vitaly Wool; +Cc: linux-mm, linux-kernel
Hi all:
Many thanks for brilliant z3fold code. I am reading it and have some questions about it. It's very nice of you if you can explain it for me.
1.page->private is used in z3fold but PagePrivate flag is never set, should we SetPagePrivate for it?
2.Since PagePrivate flag is never set, why we ClearPagePrivate in free_z3fold_page and z3fold_page_migrate?
3.Should we add page to the unbuddied list in z3fold_page_putback() when zhdr->refcount does not reach 0 since we remove it from unbuddied list
in z3fold_page_isolate? Or When we will add page to the unbuddied list after z3fold_page_putback?
Thanks a lot in advance. And waiting for your kindly reply. :)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Question Resend] About z3fold page migration
2020-10-12 14:00 [Question Resend] About z3fold page migration linmiaohe
@ 2020-10-12 14:04 ` Matthew Wilcox
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2020-10-12 14:04 UTC (permalink / raw)
To: linmiaohe; +Cc: akpm, Vitaly Wool, linux-mm, linux-kernel
On Mon, Oct 12, 2020 at 02:00:17PM +0000, linmiaohe wrote:
> Hi all:
>
> Many thanks for brilliant z3fold code. I am reading it and have some questions about it. It's very nice of you if you can explain it for me.
> 1.page->private is used in z3fold but PagePrivate flag is never set, should we SetPagePrivate for it?
No. SetPagePrivate and page->private are related in interesting and
complicated ways. I'm working on some documentation for it at the moment,
but the short answer is: no.
> 2.Since PagePrivate flag is never set, why we ClearPagePrivate in free_z3fold_page and z3fold_page_migrate?
That's probably a bug.
> 3.Should we add page to the unbuddied list in z3fold_page_putback() when zhdr->refcount does not reach 0 since we remove it from unbuddied list
> in z3fold_page_isolate? Or When we will add page to the unbuddied list after z3fold_page_putback?
This one I do not know the answer to.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Question Resend] About z3fold page migration
@ 2020-10-13 1:46 linmiaohe
0 siblings, 0 replies; 3+ messages in thread
From: linmiaohe @ 2020-10-13 1:46 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: akpm, Vitaly Wool, linux-mm, linux-kernel
Matthew Wilcox <willy@infradead.org> wrote:
> On Mon, Oct 12, 2020 at 02:00:17PM +0000, linmiaohe wrote:
>> Hi all:
>>
>> Many thanks for brilliant z3fold code. I am reading it and have some questions about it. It's very nice of you if you can explain it for me.
>> 1.page->private is used in z3fold but PagePrivate flag is never set, should we SetPagePrivate for it?
>
>No. SetPagePrivate and page->private are related in interesting and complicated ways. I'm working on some documentation for it at the moment, but the short answer is: no.
I can't wait to read your document. PagePrivate confuses me now.
>
>> 2.Since PagePrivate flag is never set, why we ClearPagePrivate in free_z3fold_page and z3fold_page_migrate?
>
>That's probably a bug.
>
>
>> 3.Should we add page to the unbuddied list in z3fold_page_putback()
>> when zhdr->refcount does not reach 0 since we remove it from unbuddied list in z3fold_page_isolate? Or When we will add page to the unbuddied list after z3fold_page_putback?
>
>This one I do not know the answer to.
>
Many thanks for your reply. Enjoy your day! ;)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-13 2:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12 14:00 [Question Resend] About z3fold page migration linmiaohe
2020-10-12 14:04 ` Matthew Wilcox
2020-10-13 1:46 linmiaohe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.