All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
	mikey@neuling.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, npiggin@gmail.com,
	naveen.n.rao@linux.vnet.ibm.com,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH 4/5] Powerpc/hw-breakpoint: Optimize disable path
Date: Wed, 19 Jun 2019 11:44:50 +0530	[thread overview]
Message-ID: <6eb4afef-3277-a920-70d2-cadf34a05be6@linux.ibm.com> (raw)
In-Reply-To: <6e7c6054-b152-40db-c7d3-89901949460f@c-s.fr>



On 6/18/19 12:01 PM, Christophe Leroy wrote:
>> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
>> index f002d2ffff86..265fac9fb3a4 100644
>> --- a/arch/powerpc/kernel/process.c
>> +++ b/arch/powerpc/kernel/process.c
>> @@ -793,10 +793,22 @@ static inline int set_dabr(struct arch_hw_breakpoint *brk)
>>       return __set_dabr(dabr, dabrx);
>>   }
>>   +static int disable_dawr(void)
>> +{
>> +    if (ppc_md.set_dawr)
>> +        return ppc_md.set_dawr(0, 0);
>> +
>> +    mtspr(SPRN_DAWRX, 0);
> 
> And SPRN_DAWR ?

Setting DAWRx with 0 should be enough to disable the breakpoint.


WARNING: multiple messages have this Message-ID (diff)
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	mikey@neuling.org, linux-kernel@vger.kernel.org,
	npiggin@gmail.com, paulus@samba.org,
	naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/5] Powerpc/hw-breakpoint: Optimize disable path
Date: Wed, 19 Jun 2019 11:44:50 +0530	[thread overview]
Message-ID: <6eb4afef-3277-a920-70d2-cadf34a05be6@linux.ibm.com> (raw)
In-Reply-To: <6e7c6054-b152-40db-c7d3-89901949460f@c-s.fr>



On 6/18/19 12:01 PM, Christophe Leroy wrote:
>> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
>> index f002d2ffff86..265fac9fb3a4 100644
>> --- a/arch/powerpc/kernel/process.c
>> +++ b/arch/powerpc/kernel/process.c
>> @@ -793,10 +793,22 @@ static inline int set_dabr(struct arch_hw_breakpoint *brk)
>>       return __set_dabr(dabr, dabrx);
>>   }
>>   +static int disable_dawr(void)
>> +{
>> +    if (ppc_md.set_dawr)
>> +        return ppc_md.set_dawr(0, 0);
>> +
>> +    mtspr(SPRN_DAWRX, 0);
> 
> And SPRN_DAWR ?

Setting DAWRx with 0 should be enough to disable the breakpoint.


  reply	other threads:[~2019-06-19  6:15 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18  4:27 [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Code refactor Ravi Bangoria
2019-06-18  4:27 ` Ravi Bangoria
2019-06-18  4:27 ` [PATCH 1/5] Powerpc/hw-breakpoint: Replace stale do_dabr() with do_break() Ravi Bangoria
2019-06-18  4:27   ` Ravi Bangoria
2019-06-18  6:02   ` Michael Neuling
2019-06-18  6:02     ` Michael Neuling
2019-06-18  6:14   ` Christophe Leroy
2019-06-18  6:14     ` Christophe Leroy
2019-06-18  4:27 ` [PATCH 2/5] Powerpc/hw-breakpoint: Refactor hw_breakpoint_arch_parse() Ravi Bangoria
2019-06-18  4:27   ` Ravi Bangoria
2019-06-18  6:21   ` Christophe Leroy
2019-06-18  6:21     ` Christophe Leroy
2019-06-18  7:10     ` Ravi Bangoria
2019-06-18  7:10       ` Ravi Bangoria
2019-06-18  4:27 ` [PATCH 3/5] Powerpc/hw-breakpoint: Refactor set_dawr() Ravi Bangoria
2019-06-18  4:27   ` Ravi Bangoria
2019-06-18  6:11   ` Michael Neuling
2019-06-18  6:11     ` Michael Neuling
2019-06-18  7:13     ` Ravi Bangoria
2019-06-18  7:13       ` Ravi Bangoria
2019-06-18  6:24   ` Christophe Leroy
2019-06-18  6:24     ` Christophe Leroy
2019-06-18  4:27 ` [PATCH 4/5] Powerpc/hw-breakpoint: Optimize disable path Ravi Bangoria
2019-06-18  4:27   ` Ravi Bangoria
2019-06-18  6:15   ` Michael Neuling
2019-06-18  6:15     ` Michael Neuling
2019-06-19  6:02     ` Ravi Bangoria
2019-06-19  6:02       ` Ravi Bangoria
2019-06-18  6:31   ` Christophe Leroy
2019-06-18  6:31     ` Christophe Leroy
2019-06-19  6:14     ` Ravi Bangoria [this message]
2019-06-19  6:14       ` Ravi Bangoria
2019-06-18  4:27 ` [PATCH 5/5] Powerpc/Watchpoint: Fix length calculation for unaligned target Ravi Bangoria
2019-06-18  4:27   ` Ravi Bangoria
2019-06-18  6:46   ` Christophe Leroy
2019-06-18  6:46     ` Christophe Leroy
2019-06-19  6:51     ` Ravi Bangoria
2019-06-19  6:51       ` Ravi Bangoria
2019-06-18 13:32   ` Michael Neuling
2019-06-18 13:32     ` Michael Neuling
2019-06-19  7:45     ` Ravi Bangoria
2019-06-19  7:45       ` Ravi Bangoria
2019-06-18  6:01 ` [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Code refactor Christophe Leroy
2019-06-18  6:01   ` Christophe Leroy
2019-06-18  6:17   ` Michael Neuling
2019-06-18  6:17     ` Michael Neuling
2019-06-19  7:47     ` Ravi Bangoria
2019-06-19  7:47       ` Ravi Bangoria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6eb4afef-3277-a920-70d2-cadf34a05be6@linux.ibm.com \
    --to=ravi.bangoria@linux.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.