From: Christophe Leroy <christophe.leroy@c-s.fr> To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>, mpe@ellerman.id.au Cc: benh@kernel.crashing.org, paulus@samba.org, mikey@neuling.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, npiggin@gmail.com, naveen.n.rao@linux.vnet.ibm.com Subject: Re: [PATCH 1/5] Powerpc/hw-breakpoint: Replace stale do_dabr() with do_break() Date: Tue, 18 Jun 2019 08:14:59 +0200 [thread overview] Message-ID: <ad944298-3418-cc94-c120-554ba0f03f0c@c-s.fr> (raw) In-Reply-To: <20190618042732.5582-2-ravi.bangoria@linux.ibm.com> The subject text should mention you are changing comments. Here it suggests you are changing code text. Le 18/06/2019 à 06:27, Ravi Bangoria a écrit : > do_dabr() was renamed with do_break() long ago. But I still see > some comments mentioning do_dabr(). Replace it. s/Replace it/Replace them/ Christophe > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > --- > arch/powerpc/kernel/hw_breakpoint.c | 2 +- > arch/powerpc/kernel/ptrace.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c > index a293a53b4365..1908e4fcc132 100644 > --- a/arch/powerpc/kernel/hw_breakpoint.c > +++ b/arch/powerpc/kernel/hw_breakpoint.c > @@ -232,7 +232,7 @@ int hw_breakpoint_handler(struct die_args *args) > * Return early after invoking user-callback function without restoring > * DABR if the breakpoint is from ptrace which always operates in > * one-shot mode. The ptrace-ed process will receive the SIGTRAP signal > - * generated in do_dabr(). > + * generated in do_break(). > */ > if (bp->overflow_handler == ptrace_triggered) { > perf_bp_event(bp, regs); > diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c > index 684b0b315c32..44b823e5e8c8 100644 > --- a/arch/powerpc/kernel/ptrace.c > +++ b/arch/powerpc/kernel/ptrace.c > @@ -2373,7 +2373,7 @@ void ptrace_triggered(struct perf_event *bp, > /* > * Disable the breakpoint request here since ptrace has defined a > * one-shot behaviour for breakpoint exceptions in PPC64. > - * The SIGTRAP signal is generated automatically for us in do_dabr(). > + * The SIGTRAP signal is generated automatically for us in do_break(). > * We don't have to do anything about that here > */ > attr = bp->attr; >
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@c-s.fr> To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>, mpe@ellerman.id.au Cc: mikey@neuling.org, linux-kernel@vger.kernel.org, npiggin@gmail.com, paulus@samba.org, naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/5] Powerpc/hw-breakpoint: Replace stale do_dabr() with do_break() Date: Tue, 18 Jun 2019 08:14:59 +0200 [thread overview] Message-ID: <ad944298-3418-cc94-c120-554ba0f03f0c@c-s.fr> (raw) In-Reply-To: <20190618042732.5582-2-ravi.bangoria@linux.ibm.com> The subject text should mention you are changing comments. Here it suggests you are changing code text. Le 18/06/2019 à 06:27, Ravi Bangoria a écrit : > do_dabr() was renamed with do_break() long ago. But I still see > some comments mentioning do_dabr(). Replace it. s/Replace it/Replace them/ Christophe > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > --- > arch/powerpc/kernel/hw_breakpoint.c | 2 +- > arch/powerpc/kernel/ptrace.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c > index a293a53b4365..1908e4fcc132 100644 > --- a/arch/powerpc/kernel/hw_breakpoint.c > +++ b/arch/powerpc/kernel/hw_breakpoint.c > @@ -232,7 +232,7 @@ int hw_breakpoint_handler(struct die_args *args) > * Return early after invoking user-callback function without restoring > * DABR if the breakpoint is from ptrace which always operates in > * one-shot mode. The ptrace-ed process will receive the SIGTRAP signal > - * generated in do_dabr(). > + * generated in do_break(). > */ > if (bp->overflow_handler == ptrace_triggered) { > perf_bp_event(bp, regs); > diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c > index 684b0b315c32..44b823e5e8c8 100644 > --- a/arch/powerpc/kernel/ptrace.c > +++ b/arch/powerpc/kernel/ptrace.c > @@ -2373,7 +2373,7 @@ void ptrace_triggered(struct perf_event *bp, > /* > * Disable the breakpoint request here since ptrace has defined a > * one-shot behaviour for breakpoint exceptions in PPC64. > - * The SIGTRAP signal is generated automatically for us in do_dabr(). > + * The SIGTRAP signal is generated automatically for us in do_break(). > * We don't have to do anything about that here > */ > attr = bp->attr; >
next prev parent reply other threads:[~2019-06-18 6:50 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-18 4:27 [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Code refactor Ravi Bangoria 2019-06-18 4:27 ` Ravi Bangoria 2019-06-18 4:27 ` [PATCH 1/5] Powerpc/hw-breakpoint: Replace stale do_dabr() with do_break() Ravi Bangoria 2019-06-18 4:27 ` Ravi Bangoria 2019-06-18 6:02 ` Michael Neuling 2019-06-18 6:02 ` Michael Neuling 2019-06-18 6:14 ` Christophe Leroy [this message] 2019-06-18 6:14 ` Christophe Leroy 2019-06-18 4:27 ` [PATCH 2/5] Powerpc/hw-breakpoint: Refactor hw_breakpoint_arch_parse() Ravi Bangoria 2019-06-18 4:27 ` Ravi Bangoria 2019-06-18 6:21 ` Christophe Leroy 2019-06-18 6:21 ` Christophe Leroy 2019-06-18 7:10 ` Ravi Bangoria 2019-06-18 7:10 ` Ravi Bangoria 2019-06-18 4:27 ` [PATCH 3/5] Powerpc/hw-breakpoint: Refactor set_dawr() Ravi Bangoria 2019-06-18 4:27 ` Ravi Bangoria 2019-06-18 6:11 ` Michael Neuling 2019-06-18 6:11 ` Michael Neuling 2019-06-18 7:13 ` Ravi Bangoria 2019-06-18 7:13 ` Ravi Bangoria 2019-06-18 6:24 ` Christophe Leroy 2019-06-18 6:24 ` Christophe Leroy 2019-06-18 4:27 ` [PATCH 4/5] Powerpc/hw-breakpoint: Optimize disable path Ravi Bangoria 2019-06-18 4:27 ` Ravi Bangoria 2019-06-18 6:15 ` Michael Neuling 2019-06-18 6:15 ` Michael Neuling 2019-06-19 6:02 ` Ravi Bangoria 2019-06-19 6:02 ` Ravi Bangoria 2019-06-18 6:31 ` Christophe Leroy 2019-06-18 6:31 ` Christophe Leroy 2019-06-19 6:14 ` Ravi Bangoria 2019-06-19 6:14 ` Ravi Bangoria 2019-06-18 4:27 ` [PATCH 5/5] Powerpc/Watchpoint: Fix length calculation for unaligned target Ravi Bangoria 2019-06-18 4:27 ` Ravi Bangoria 2019-06-18 6:46 ` Christophe Leroy 2019-06-18 6:46 ` Christophe Leroy 2019-06-19 6:51 ` Ravi Bangoria 2019-06-19 6:51 ` Ravi Bangoria 2019-06-18 13:32 ` Michael Neuling 2019-06-18 13:32 ` Michael Neuling 2019-06-19 7:45 ` Ravi Bangoria 2019-06-19 7:45 ` Ravi Bangoria 2019-06-18 6:01 ` [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Code refactor Christophe Leroy 2019-06-18 6:01 ` Christophe Leroy 2019-06-18 6:17 ` Michael Neuling 2019-06-18 6:17 ` Michael Neuling 2019-06-19 7:47 ` Ravi Bangoria 2019-06-19 7:47 ` Ravi Bangoria
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ad944298-3418-cc94-c120-554ba0f03f0c@c-s.fr \ --to=christophe.leroy@c-s.fr \ --cc=benh@kernel.crashing.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mikey@neuling.org \ --cc=mpe@ellerman.id.au \ --cc=naveen.n.rao@linux.vnet.ibm.com \ --cc=npiggin@gmail.com \ --cc=paulus@samba.org \ --cc=ravi.bangoria@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.