Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices

From: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>
To: Eric Blake <eblake@redhat.com>,
	Pradeep Jagadeesh <pradeepkiruvale@gmail.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Greg Kurz <groug@kaod.org>
Cc: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices
Date: Tue, 7 Feb 2017 11:34:28 +0100	[thread overview]
Message-ID: <6eb9d362-9d8f-6d63-e500-7039de074694@huawei.com> (raw)
In-Reply-To: <71b1733d-7638-5e27-e828-fad57f76f507@redhat.com>

On 2/6/2017 8:36 PM, Eric Blake wrote:
> On 02/03/2017 05:57 AM, Pradeep Jagadeesh wrote:
>> This patchset adds the throttle support for the 9p-local driver.
>> For now this functionality can be enabled only through qemu cli options.
>> QMP interface and support to other drivers need further extensions.
>
> This part is a bit scary - if 2.9 is released with just the cli option
> and not the QMP interface, then how does someone like libvirt introspect
> whether the feature is available for use?
I do have plans to extend the qmp interface for this feature.
Already started looking into it.Do not know, I can push it for 2.9. 
Because I am busy with some other work.
>
> Please make sure we don't reach 2.9 with only a half-baked feature;
> whether that means finishing the QMP work or temporarily disabling the
> cli additions until a later release can finish the work.
>