From: Eric Blake <eblake@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Pradeep Jagadeesh <pradeepkiruvale@gmail.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Alberto Garcia <berto@igalia.com>,
Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,
qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2 v16] fsdev: add IO throttle support to fsdev devices
Date: Wed, 22 Feb 2017 11:04:42 -0600 [thread overview]
Message-ID: <c3877ffd-4506-f8f3-57bc-0c00e4e3a6f4@redhat.com> (raw)
In-Reply-To: <20170222175917.53c27906@bahia.lan>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On 02/22/2017 10:59 AM, Greg Kurz wrote:
>>>> I see these parameter names as stable. There is little risk that they
>>>> would change.
>>
>> We just need to be sure that when we do add QMP, that it doesn't use
>> names that differ from the command line (blockdev is an example where we
>> weren't careful in 2.8, and had to rename things in 2.9 to be
>> consistent, and I want to avoid repeating that mistake).
>>
>
> Can you provide some pointers on what had to be fixed in blockdev ?
See for example commits f67409a, 4230e5d, 1a417e4 showing several cases
where we had to fix up inconsistencies.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-02-22 17:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 11:57 [Qemu-devel] [PATCH 0/2 v16] fsdev: add IO throttle support to fsdev devices Pradeep Jagadeesh
2017-02-03 11:57 ` [Qemu-devel] [PATCH 1/2 " Pradeep Jagadeesh
2017-02-03 12:21 ` Alberto Garcia
2017-02-06 19:36 ` Eric Blake
2017-02-06 23:15 ` Greg Kurz
2017-02-07 10:32 ` Greg Kurz
2017-02-07 15:56 ` Eric Blake
2017-02-07 16:29 ` Greg Kurz
2017-02-14 13:21 ` Stefan Hajnoczi
2017-02-22 13:41 ` Greg Kurz
2017-02-22 16:01 ` Eric Blake
2017-02-22 16:59 ` Greg Kurz
2017-02-22 17:04 ` Eric Blake [this message]
2017-02-07 6:18 ` Fam Zheng
2017-02-07 10:34 ` Pradeep Jagadeesh
2017-02-03 11:57 ` [Qemu-devel] [PATCH 2/2 v16] throttle: factor out duplicate code Pradeep Jagadeesh
2017-02-03 12:22 ` Alberto Garcia
2017-02-03 12:27 ` Pradeep Jagadeesh
2017-02-03 12:44 ` Alberto Garcia
2017-02-03 12:46 ` Pradeep Jagadeesh
2017-02-03 12:53 ` Alberto Garcia
2017-02-03 12:57 ` Pradeep Jagadeesh
2017-02-06 14:58 ` Greg Kurz
2017-02-06 15:19 ` Pradeep Jagadeesh
2017-02-03 12:02 ` [Qemu-devel] [PATCH 0/2 v16] fsdev: add IO throttle support to fsdev devices no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3877ffd-4506-f8f3-57bc-0c00e4e3a6f4@redhat.com \
--to=eblake@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=berto@igalia.com \
--cc=famz@redhat.com \
--cc=groug@kaod.org \
--cc=pradeep.jagadeesh@huawei.com \
--cc=pradeepkiruvale@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.