From: Dan Murphy <dmurphy@ti.com> To: Lee Jones <lee.jones@linaro.org> Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH 4/5] mfd: ti-lmu: Remove support for LM3697 Date: Thu, 4 Apr 2019 07:09:15 -0500 [thread overview] Message-ID: <6ebe491c-f124-2849-2e3a-0209dd5a2620@ti.com> (raw) In-Reply-To: <20190404081736.GM6830@dell> Lee Thanks for the review On 4/4/19 3:17 AM, Lee Jones wrote: > On Mon, 25 Mar 2019, Dan Murphy wrote: > >> Remove support for the LM3697 from the ti-lmu > > Bit of an odd place to insert a line feed. > I will fix in v2. >> driver in favor of a dedicated LED driver. >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> drivers/leds/Kconfig | 2 +- >> drivers/mfd/Kconfig | 2 +- >> drivers/mfd/ti-lmu.c | 17 ----------- >> include/linux/mfd/ti-lmu-register.h | 44 ----------------------------- >> include/linux/mfd/ti-lmu.h | 1 - >> 5 files changed, 2 insertions(+), 64 deletions(-) > > I'm fine with the patch. > > Can you edit drivers/leds/Kconfig as part of a separate patch please? > Keeping this in sync with this change is not critical and would add a > whole bunch of process which we can really do without. > Ack. I will add this when I add the LM3697 config in the Kconfig Dan -- ------------------ Dan Murphy
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com> To: Lee Jones <lee.jones@linaro.org> Cc: <robh+dt@kernel.org>, <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>, <linux-kernel@vger.kernel.org>, <linux-leds@vger.kernel.org> Subject: Re: [PATCH 4/5] mfd: ti-lmu: Remove support for LM3697 Date: Thu, 4 Apr 2019 07:09:15 -0500 [thread overview] Message-ID: <6ebe491c-f124-2849-2e3a-0209dd5a2620@ti.com> (raw) In-Reply-To: <20190404081736.GM6830@dell> Lee Thanks for the review On 4/4/19 3:17 AM, Lee Jones wrote: > On Mon, 25 Mar 2019, Dan Murphy wrote: > >> Remove support for the LM3697 from the ti-lmu > > Bit of an odd place to insert a line feed. > I will fix in v2. >> driver in favor of a dedicated LED driver. >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> drivers/leds/Kconfig | 2 +- >> drivers/mfd/Kconfig | 2 +- >> drivers/mfd/ti-lmu.c | 17 ----------- >> include/linux/mfd/ti-lmu-register.h | 44 ----------------------------- >> include/linux/mfd/ti-lmu.h | 1 - >> 5 files changed, 2 insertions(+), 64 deletions(-) > > I'm fine with the patch. > > Can you edit drivers/leds/Kconfig as part of a separate patch please? > Keeping this in sync with this change is not critical and would add a > whole bunch of process which we can really do without. > Ack. I will add this when I add the LM3697 config in the Kconfig Dan -- ------------------ Dan Murphy
next prev parent reply other threads:[~2019-04-04 12:09 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-25 14:23 [PATCH 0/5] TI LMU rework Dan Murphy 2019-03-25 14:23 ` Dan Murphy 2019-03-25 14:23 ` [PATCH 1/5] dt-bindings: mfd: Update the ramp up/down property Dan Murphy 2019-03-25 14:23 ` Dan Murphy 2019-04-04 8:19 ` Lee Jones 2019-04-04 12:07 ` Dan Murphy 2019-04-04 12:07 ` Dan Murphy 2019-03-25 14:24 ` [PATCH 2/5] leds: TI LMU: Add common code for TI LMU devices Dan Murphy 2019-03-25 14:24 ` Dan Murphy 2019-04-04 13:22 ` Pavel Machek 2019-03-25 14:24 ` [PATCH 3/5] dt-bindings: ti-lmu: Modify dt bindings for the LM3697 Dan Murphy 2019-03-25 14:24 ` Dan Murphy 2019-04-03 20:10 ` Jacek Anaszewski 2019-04-03 20:23 ` Dan Murphy 2019-04-03 20:23 ` Dan Murphy 2019-04-04 18:39 ` Jacek Anaszewski 2019-04-04 19:27 ` Dan Murphy 2019-04-04 19:27 ` Dan Murphy 2019-04-04 19:31 ` Jacek Anaszewski 2019-04-04 19:34 ` Dan Murphy 2019-04-04 19:34 ` Dan Murphy 2019-03-25 14:24 ` [PATCH 4/5] mfd: ti-lmu: Remove support for LM3697 Dan Murphy 2019-03-25 14:24 ` Dan Murphy 2019-04-04 8:17 ` Lee Jones 2019-04-04 8:18 ` Lee Jones 2019-04-04 12:09 ` Dan Murphy [this message] 2019-04-04 12:09 ` Dan Murphy 2019-03-25 14:24 ` [PATCH 5/5] leds: lm3697: Introduce the lm3697 driver Dan Murphy 2019-03-25 14:24 ` Dan Murphy 2019-04-13 20:06 ` Pavel Machek 2019-04-15 12:49 ` Dan Murphy 2019-04-15 12:49 ` Dan Murphy 2019-04-15 14:03 ` Pavel Machek 2019-04-15 19:53 ` Dan Murphy 2019-04-15 19:53 ` Dan Murphy 2019-04-03 12:02 ` [PATCH 0/5] TI LMU rework Dan Murphy 2019-04-03 12:02 ` Dan Murphy 2019-04-03 20:14 ` Jacek Anaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6ebe491c-f124-2849-2e3a-0209dd5a2620@ti.com \ --to=dmurphy@ti.com \ --cc=jacek.anaszewski@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.