From: Dan Murphy <dmurphy@ti.com> To: Pavel Machek <pavel@ucw.cz> Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH 5/5] leds: lm3697: Introduce the lm3697 driver Date: Mon, 15 Apr 2019 14:53:35 -0500 [thread overview] Message-ID: <ea9ac786-7303-5de3-9686-55589eed35ec@ti.com> (raw) In-Reply-To: <20190415140306.GA13084@amd> On 4/15/19 9:03 AM, Pavel Machek wrote: > >>>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig >>>> index 735009e73414..688bb9a6f275 100644 >>>> --- a/drivers/leds/Kconfig >>>> +++ b/drivers/leds/Kconfig >>>> @@ -776,9 +776,15 @@ config LEDS_NIC78BX >>>> To compile this driver as a module, choose M here: the module >>>> will be called leds-nic78bx. >>>> >>>> +config LEDS_LM3697 >>>> + tristate "LED driver for LM3697" >>>> + depends on LEDS_TI_LMU_COMMON >>>> + help >>>> + Say Y to enable the LM3697 LED driver for TI LMU devices. >>>> + This supports the LED device LM3697. >>>> + >>>> config LEDS_TI_LMU_COMMON >>>> tristate "LED driver for TI LMU" >>>> - depends on REGMAP >>>> help >>>> Say Y to enable the LED driver for TI LMU devices. >>>> This supports common features between the TI LM3532, LM3631, LM3632, > ... >>> Plus we'd normally expect "COMMON" first and then specific driver. Not >>> sure if Kconfig can handle it out-of-order... >> >> OK. Should I rename the ti_lmu file to leds-common-ti-lmu? > > Oh, no, that is not what I meant. > > You have > > config B > depends on A > > config A > > above. We really want > > config A > > config B > depends on A > Got it I will rearrange that in v2. >> This keeps the naming convention the same in the leds directory as well. >> >> FYI I will not add your acked-by on the LMU patch that introduced the code unless you approve. >> Since you found issues with the kconfig > > I did not review it in great detail, so no acked-by's, yet :-). Thanks Dan > Pavel >
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com> To: Pavel Machek <pavel@ucw.cz> Cc: <robh+dt@kernel.org>, <jacek.anaszewski@gmail.com>, <linux-kernel@vger.kernel.org>, <linux-leds@vger.kernel.org> Subject: Re: [PATCH 5/5] leds: lm3697: Introduce the lm3697 driver Date: Mon, 15 Apr 2019 14:53:35 -0500 [thread overview] Message-ID: <ea9ac786-7303-5de3-9686-55589eed35ec@ti.com> (raw) In-Reply-To: <20190415140306.GA13084@amd> On 4/15/19 9:03 AM, Pavel Machek wrote: > >>>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig >>>> index 735009e73414..688bb9a6f275 100644 >>>> --- a/drivers/leds/Kconfig >>>> +++ b/drivers/leds/Kconfig >>>> @@ -776,9 +776,15 @@ config LEDS_NIC78BX >>>> To compile this driver as a module, choose M here: the module >>>> will be called leds-nic78bx. >>>> >>>> +config LEDS_LM3697 >>>> + tristate "LED driver for LM3697" >>>> + depends on LEDS_TI_LMU_COMMON >>>> + help >>>> + Say Y to enable the LM3697 LED driver for TI LMU devices. >>>> + This supports the LED device LM3697. >>>> + >>>> config LEDS_TI_LMU_COMMON >>>> tristate "LED driver for TI LMU" >>>> - depends on REGMAP >>>> help >>>> Say Y to enable the LED driver for TI LMU devices. >>>> This supports common features between the TI LM3532, LM3631, LM3632, > ... >>> Plus we'd normally expect "COMMON" first and then specific driver. Not >>> sure if Kconfig can handle it out-of-order... >> >> OK. Should I rename the ti_lmu file to leds-common-ti-lmu? > > Oh, no, that is not what I meant. > > You have > > config B > depends on A > > config A > > above. We really want > > config A > > config B > depends on A > Got it I will rearrange that in v2. >> This keeps the naming convention the same in the leds directory as well. >> >> FYI I will not add your acked-by on the LMU patch that introduced the code unless you approve. >> Since you found issues with the kconfig > > I did not review it in great detail, so no acked-by's, yet :-). Thanks Dan > Pavel >
next prev parent reply other threads:[~2019-04-15 19:53 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-25 14:23 [PATCH 0/5] TI LMU rework Dan Murphy 2019-03-25 14:23 ` Dan Murphy 2019-03-25 14:23 ` [PATCH 1/5] dt-bindings: mfd: Update the ramp up/down property Dan Murphy 2019-03-25 14:23 ` Dan Murphy 2019-04-04 8:19 ` Lee Jones 2019-04-04 12:07 ` Dan Murphy 2019-04-04 12:07 ` Dan Murphy 2019-03-25 14:24 ` [PATCH 2/5] leds: TI LMU: Add common code for TI LMU devices Dan Murphy 2019-03-25 14:24 ` Dan Murphy 2019-04-04 13:22 ` Pavel Machek 2019-03-25 14:24 ` [PATCH 3/5] dt-bindings: ti-lmu: Modify dt bindings for the LM3697 Dan Murphy 2019-03-25 14:24 ` Dan Murphy 2019-04-03 20:10 ` Jacek Anaszewski 2019-04-03 20:23 ` Dan Murphy 2019-04-03 20:23 ` Dan Murphy 2019-04-04 18:39 ` Jacek Anaszewski 2019-04-04 19:27 ` Dan Murphy 2019-04-04 19:27 ` Dan Murphy 2019-04-04 19:31 ` Jacek Anaszewski 2019-04-04 19:34 ` Dan Murphy 2019-04-04 19:34 ` Dan Murphy 2019-03-25 14:24 ` [PATCH 4/5] mfd: ti-lmu: Remove support for LM3697 Dan Murphy 2019-03-25 14:24 ` Dan Murphy 2019-04-04 8:17 ` Lee Jones 2019-04-04 8:18 ` Lee Jones 2019-04-04 12:09 ` Dan Murphy 2019-04-04 12:09 ` Dan Murphy 2019-03-25 14:24 ` [PATCH 5/5] leds: lm3697: Introduce the lm3697 driver Dan Murphy 2019-03-25 14:24 ` Dan Murphy 2019-04-13 20:06 ` Pavel Machek 2019-04-15 12:49 ` Dan Murphy 2019-04-15 12:49 ` Dan Murphy 2019-04-15 14:03 ` Pavel Machek 2019-04-15 19:53 ` Dan Murphy [this message] 2019-04-15 19:53 ` Dan Murphy 2019-04-03 12:02 ` [PATCH 0/5] TI LMU rework Dan Murphy 2019-04-03 12:02 ` Dan Murphy 2019-04-03 20:14 ` Jacek Anaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ea9ac786-7303-5de3-9686-55589eed35ec@ti.com \ --to=dmurphy@ti.com \ --cc=jacek.anaszewski@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.