All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Frank Wang <frank.wang@rock-chips.com>,
	heiko@sntech.de, bmeng.cn@gmail.com,
	philipp.tomsich@theobroma-systems.com,
	klaus.goger@theobroma-systems.com, jagan@amarulasolutions.com,
	sjg@chromium.org, kever.yang@rock-chips.com
Cc: u-boot@lists.denx.de, linux-rockchip@lists.infradead.org,
	linux-amarula@amarulasolutions.com, marek.belisko@gmail.com,
	william.wu@rock-chips.com, jianing.ren@rock-chips.com,
	chenjh@rock-chips.com, wmc@rock-chips.com
Subject: Re: [PATCH v4 12/16] usb: dwc3: add make compatible for rockchip platform
Date: Tue, 12 May 2020 09:26:23 +0200	[thread overview]
Message-ID: <6f0482e0-eedc-b7e4-f6ab-cf82b26c22ec@denx.de> (raw)
In-Reply-To: <618d46f5-7970-9b27-e912-36f21b24a957@rock-chips.com>

On 5/12/20 3:08 AM, Frank Wang wrote:
> Hi Marek,
> 
> On 2020/5/11 17:48, Marek Vasut wrote:
>> On 5/11/20 9:57 AM, Frank Wang wrote:
>> [...]
>>
>>> @@ -394,6 +407,12 @@ static int dwc3_glue_probe(struct udevice *dev)
>>>       if (ret)
>>>           return ret;
>>>   +    if (glue->resets.count < 1) {
>> This condition is only true if count == 0 ?
>> What's the purpose of this test ?
> 
> For previous dts of the Linux kernel, the reset phandles were in
> dwc3-glue nodes, however, they are moved recently into dwc3 that is a
> child node of dwc3-glue.
> 
> So the above codes is to make compatible.

Why doesn't it check for count == 0 then ?

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v4 12/16] usb: dwc3: add make compatible for rockchip platform
Date: Tue, 12 May 2020 09:26:23 +0200	[thread overview]
Message-ID: <6f0482e0-eedc-b7e4-f6ab-cf82b26c22ec@denx.de> (raw)
In-Reply-To: <618d46f5-7970-9b27-e912-36f21b24a957@rock-chips.com>

On 5/12/20 3:08 AM, Frank Wang wrote:
> Hi Marek,
> 
> On 2020/5/11 17:48, Marek Vasut wrote:
>> On 5/11/20 9:57 AM, Frank Wang wrote:
>> [...]
>>
>>> @@ -394,6 +407,12 @@ static int dwc3_glue_probe(struct udevice *dev)
>>> ????? if (ret)
>>> ????????? return ret;
>>> ? +??? if (glue->resets.count < 1) {
>> This condition is only true if count == 0 ?
>> What's the purpose of this test ?
> 
> For previous dts of the Linux kernel, the reset phandles were in
> dwc3-glue nodes, however, they are moved recently into dwc3 that is a
> child node of dwc3-glue.
> 
> So the above codes is to make compatible.

Why doesn't it check for count == 0 then ?

  reply	other threads:[~2020-05-12  7:26 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11  7:53 [PATCH v4 00/16] Add Rockchip RK3399 USB3.0 Host support Frank Wang
2020-05-11  7:53 ` Frank Wang
2020-05-11  7:53 ` [PATCH v4 01/16] clk: rk3399: Enable/Disable the USB2PHY clk Frank Wang
2020-05-11  7:53   ` Frank Wang
     [not found] ` <20200511075330.26462-1-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2020-05-11  7:53   ` [PATCH v4 02/16] clk: rk3399: Set empty for TCPHY assigned-clocks Frank Wang
2020-05-11  7:53     ` Frank Wang
2020-05-11  7:53   ` [PATCH v4 03/16] clk: rk3399: Enable/Disable TCPHY clocks Frank Wang
2020-05-11  7:53     ` Frank Wang
2020-05-11  7:53   ` [PATCH v4 04/16] phy: rockchip: Add Rockchip USB2PHY driver Frank Wang
2020-05-11  7:53     ` Frank Wang
2020-05-11  7:55   ` [PATCH v4 05/16] arm64: dts: rk3399: Move u2phy into root port Frank Wang
2020-05-11  7:55     ` Frank Wang
     [not found]     ` <20200511075520.26557-1-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2020-05-11  7:55       ` [PATCH v4 06/16] phy: rockchip: Add Rockchip USB TypeC PHY driver Frank Wang
2020-05-11  7:55         ` Frank Wang
2020-05-11  7:55       ` [PATCH v4 07/16] usb: dwc3: add dis_enblslpm_quirk Frank Wang
2020-05-11  7:55         ` Frank Wang
2020-05-11  8:49         ` Jagan Teki
2020-05-11  8:49           ` Jagan Teki
2020-05-11  7:55       ` [PATCH v4 08/16] usb: dwc3: add dis_u2_freeclk_exists_quirk Frank Wang
2020-05-11  7:55         ` Frank Wang
2020-05-11  8:50         ` Jagan Teki
2020-05-11  8:50           ` Jagan Teki
2020-05-11  7:55       ` [PATCH v4 09/16] usb: dwc3: Add disable u2mac linestate check quirk Frank Wang
2020-05-11  7:55         ` Frank Wang
2020-05-11  7:57 ` [PATCH v4 10/16] usb: dwc3: Enable AutoRetry feature in the controller Frank Wang
2020-05-11  7:57   ` Frank Wang
     [not found]   ` <20200511075725.26665-1-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2020-05-11  7:57     ` [PATCH v4 11/16] usb: dwc3: amend UTMI/UTMIW phy interface setup Frank Wang
2020-05-11  7:57       ` Frank Wang
2020-05-11  7:57     ` [PATCH v4 12/16] usb: dwc3: add make compatible for rockchip platform Frank Wang
2020-05-11  7:57       ` Frank Wang
2020-05-11  9:48       ` Marek Vasut
2020-05-11  9:48         ` Marek Vasut
2020-05-12  1:08         ` Frank Wang
2020-05-12  1:08           ` Frank Wang
2020-05-12  7:26           ` Marek Vasut [this message]
2020-05-12  7:26             ` Marek Vasut
2020-05-13  0:47             ` Frank Wang
2020-05-13  0:47               ` Frank Wang
2020-05-13 11:41               ` Marek Vasut
2020-05-13 11:41                 ` Marek Vasut
2020-05-11  7:57     ` [PATCH v4 13/16] driver: usb: drop legacy rockchip xhci driver Frank Wang
2020-05-11  7:57       ` Frank Wang
2020-05-11  7:57     ` [PATCH v4 14/16] ARM: dts: rk3399-evb: usb3.0 host support Frank Wang
2020-05-11  7:57       ` Frank Wang
2020-05-11  7:58 ` [PATCH v4 15/16] configs: evb-rk3399: update support usb3.0 host Frank Wang
2020-05-11  7:58   ` Frank Wang
     [not found]   ` <20200511075830.26754-1-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2020-05-11  7:58     ` [PATCH v4 16/16] roc-rk3399-pc: Enable USB3.0 Host Frank Wang
2020-05-11  7:58       ` Frank Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f0482e0-eedc-b7e4-f6ab-cf82b26c22ec@denx.de \
    --to=marex@denx.de \
    --cc=bmeng.cn@gmail.com \
    --cc=chenjh@rock-chips.com \
    --cc=frank.wang@rock-chips.com \
    --cc=heiko@sntech.de \
    --cc=jagan@amarulasolutions.com \
    --cc=jianing.ren@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=klaus.goger@theobroma-systems.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=marek.belisko@gmail.com \
    --cc=philipp.tomsich@theobroma-systems.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=william.wu@rock-chips.com \
    --cc=wmc@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.