* RE: [PATCH] vdpa/mlx5: Fix wrong configuration of virtio_version_1_0 [not found] <20211230142024.142979-1-elic@nvidia.com> @ 2021-12-30 14:49 ` Parav Pandit via Virtualization 2022-01-04 2:43 ` Jason Wang 2022-01-04 13:28 ` Si-Wei Liu 1 sibling, 1 reply; 3+ messages in thread From: Parav Pandit via Virtualization @ 2021-12-30 14:49 UTC (permalink / raw) To: Eli Cohen, mst, jasowang, virtualization; +Cc: lvivier, eperezma, si-wei.liu > From: Eli Cohen <elic@nvidia.com> > Sent: Thursday, December 30, 2021 7:50 PM > > Remove overriding of virtio_version_1_0 which forced the virtqueue object to > version 1. > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 > devices") > Signed-off-by: Eli Cohen <elic@nvidia.com> > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c > b/drivers/vdpa/mlx5/net/mlx5_vnet.c > index 1eb473cb9d4d..e946a36bf7ee 100644 > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > @@ -871,8 +871,6 @@ static int create_virtqueue(struct mlx5_vdpa_net > *ndev, struct mlx5_vdpa_virtque > MLX5_SET(virtio_q, vq_ctx, umem_3_id, mvq->umem3.id); > MLX5_SET(virtio_q, vq_ctx, umem_3_size, mvq->umem3.size); > MLX5_SET(virtio_q, vq_ctx, pd, ndev->mvdev.res.pdn); > - if (MLX5_CAP_DEV_VDPA_EMULATION(ndev->mvdev.mdev, > eth_frame_offload_type)) > - MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0, 1); > > err = mlx5_cmd_exec(ndev->mvdev.mdev, in, inlen, out, sizeof(out)); > if (err) > -- > 2.34.1 Reviewed-by: Parav Pandit <parav@nvidia.com> _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vdpa/mlx5: Fix wrong configuration of virtio_version_1_0 2021-12-30 14:49 ` [PATCH] vdpa/mlx5: Fix wrong configuration of virtio_version_1_0 Parav Pandit via Virtualization @ 2022-01-04 2:43 ` Jason Wang 0 siblings, 0 replies; 3+ messages in thread From: Jason Wang @ 2022-01-04 2:43 UTC (permalink / raw) To: Parav Pandit Cc: lvivier, mst, virtualization, eperezma, si-wei.liu, Eli Cohen On Thu, Dec 30, 2021 at 10:49 PM Parav Pandit <parav@nvidia.com> wrote: > > > > From: Eli Cohen <elic@nvidia.com> > > Sent: Thursday, December 30, 2021 7:50 PM > > > > Remove overriding of virtio_version_1_0 which forced the virtqueue object to > > version 1. > > > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 > > devices") > > Signed-off-by: Eli Cohen <elic@nvidia.com> > > --- > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > index 1eb473cb9d4d..e946a36bf7ee 100644 > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > > @@ -871,8 +871,6 @@ static int create_virtqueue(struct mlx5_vdpa_net > > *ndev, struct mlx5_vdpa_virtque > > MLX5_SET(virtio_q, vq_ctx, umem_3_id, mvq->umem3.id); > > MLX5_SET(virtio_q, vq_ctx, umem_3_size, mvq->umem3.size); > > MLX5_SET(virtio_q, vq_ctx, pd, ndev->mvdev.res.pdn); > > - if (MLX5_CAP_DEV_VDPA_EMULATION(ndev->mvdev.mdev, > > eth_frame_offload_type)) > > - MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0, 1); > > > > err = mlx5_cmd_exec(ndev->mvdev.mdev, in, inlen, out, sizeof(out)); > > if (err) > > -- > > 2.34.1 > > Reviewed-by: Parav Pandit <parav@nvidia.com> > Acked-by: Jason Wang <jasowang@redhat.com> _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vdpa/mlx5: Fix wrong configuration of virtio_version_1_0 [not found] <20211230142024.142979-1-elic@nvidia.com> 2021-12-30 14:49 ` [PATCH] vdpa/mlx5: Fix wrong configuration of virtio_version_1_0 Parav Pandit via Virtualization @ 2022-01-04 13:28 ` Si-Wei Liu 1 sibling, 0 replies; 3+ messages in thread From: Si-Wei Liu @ 2022-01-04 13:28 UTC (permalink / raw) To: Eli Cohen, mst, jasowang, virtualization; +Cc: lvivier, eperezma On 12/30/2021 6:20 AM, Eli Cohen wrote: > Remove overriding of virtio_version_1_0 which forced the virtqueue > object to version 1. > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") > Signed-off-by: Eli Cohen <elic@nvidia.com> Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com> -Siwei > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c > index 1eb473cb9d4d..e946a36bf7ee 100644 > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > @@ -871,8 +871,6 @@ static int create_virtqueue(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtque > MLX5_SET(virtio_q, vq_ctx, umem_3_id, mvq->umem3.id); > MLX5_SET(virtio_q, vq_ctx, umem_3_size, mvq->umem3.size); > MLX5_SET(virtio_q, vq_ctx, pd, ndev->mvdev.res.pdn); > - if (MLX5_CAP_DEV_VDPA_EMULATION(ndev->mvdev.mdev, eth_frame_offload_type)) > - MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0, 1); > > err = mlx5_cmd_exec(ndev->mvdev.mdev, in, inlen, out, sizeof(out)); > if (err) _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-04 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211230142024.142979-1-elic@nvidia.com>
2021-12-30 14:49 ` [PATCH] vdpa/mlx5: Fix wrong configuration of virtio_version_1_0 Parav Pandit via Virtualization
2022-01-04 2:43 ` Jason Wang
2022-01-04 13:28 ` Si-Wei Liu
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.