All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keerthy <j-keerthy@ti.com>
To: Tony Lindgren <tony@atomide.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-gpio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-omap@vger.kernel.org,
	Haojian Zhuang <haojian.zhuang@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: pinctrl-single: Avoid divisions in context save/restore
Date: Fri, 8 Jun 2018 12:18:05 +0530	[thread overview]
Message-ID: <6f7fd157-8d49-d61d-c959-1f60c4dc5e8e@ti.com> (raw)
In-Reply-To: <20180608062602.GK5738@atomide.com>



On Friday 08 June 2018 11:56 AM, Tony Lindgren wrote:
> * Geert Uytterhoeven <geert+renesas@glider.be> [180607 13:40]:
>> The divisions (and multiplications) can be avoided by changing the loops
>> to use increments of mux_bytes instead of 1.
>> While at it, remove the unneeded casts when assigning void pointers.
>>
>> This saves +100 bytes of kernel size on arm32/arm64.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> Compile-tested only.
> 
> Makes sense to me:
> 
> Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Keerthy can you please test?

Tested on AM437x-gp-evm for Deep Sleep0.

Tested-by: Keerthy <j-keerthy@ti.com>
Reviewed-by: Keerthy <j-keerthy@ti.com>

Thanks Geert!

> 
> Regards,
> 
> Tony
> 

WARNING: multiple messages have this Message-ID (diff)
From: j-keerthy@ti.com (Keerthy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: pinctrl-single: Avoid divisions in context save/restore
Date: Fri, 8 Jun 2018 12:18:05 +0530	[thread overview]
Message-ID: <6f7fd157-8d49-d61d-c959-1f60c4dc5e8e@ti.com> (raw)
In-Reply-To: <20180608062602.GK5738@atomide.com>



On Friday 08 June 2018 11:56 AM, Tony Lindgren wrote:
> * Geert Uytterhoeven <geert+renesas@glider.be> [180607 13:40]:
>> The divisions (and multiplications) can be avoided by changing the loops
>> to use increments of mux_bytes instead of 1.
>> While at it, remove the unneeded casts when assigning void pointers.
>>
>> This saves +100 bytes of kernel size on arm32/arm64.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> Compile-tested only.
> 
> Makes sense to me:
> 
> Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Keerthy can you please test?

Tested on AM437x-gp-evm for Deep Sleep0.

Tested-by: Keerthy <j-keerthy@ti.com>
Reviewed-by: Keerthy <j-keerthy@ti.com>

Thanks Geert!

> 
> Regards,
> 
> Tony
> 

  reply	other threads:[~2018-06-08  6:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07 12:24 [PATCH] pinctrl: pinctrl-single: Avoid divisions in context save/restore Geert Uytterhoeven
2018-06-07 12:24 ` Geert Uytterhoeven
2018-06-08  6:26 ` Tony Lindgren
2018-06-08  6:26   ` Tony Lindgren
2018-06-08  6:48   ` Keerthy [this message]
2018-06-08  6:48     ` Keerthy
2018-06-14  8:33 ` Linus Walleij
2018-06-14  8:33   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f7fd157-8d49-d61d-c959-1f60c4dc5e8e@ti.com \
    --to=j-keerthy@ti.com \
    --cc=geert+renesas@glider.be \
    --cc=haojian.zhuang@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.