* [PATCH] arm64: dts: renesas: Add ports node to all adv7482 nodes
@ 2021-10-12 18:34 Niklas Söderlund
2021-10-13 14:57 ` Geert Uytterhoeven
2021-10-15 12:48 ` Kieran Bingham
0 siblings, 2 replies; 4+ messages in thread
From: Niklas Söderlund @ 2021-10-12 18:34 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-renesas-soc, Niklas Söderlund
The different port@ entries of the adv7482 nodes shall be encapsulated
in a ports node, add one. This change do not change how the driver
parses the DT and no driver change is needed.
The change however makes it possible to validate the source files with a
correct json-schema.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
.../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 40 +++++++-------
.../boot/dts/renesas/salvator-common.dtsi | 54 ++++++++++---------
2 files changed, 49 insertions(+), 45 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 9c7146084ea1c779..b051e2f3aceb5a17 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -423,37 +423,39 @@ video-receiver@70 {
compatible = "adi,adv7482";
reg = <0x70>;
- #address-cells = <1>;
- #size-cells = <0>;
-
interrupt-parent = <&gpio0>;
interrupt-names = "intrq1", "intrq2";
interrupts = <7 IRQ_TYPE_LEVEL_LOW>,
<17 IRQ_TYPE_LEVEL_LOW>;
- port@7 {
- reg = <7>;
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
- adv7482_ain7: endpoint {
- remote-endpoint = <&cvbs_con>;
+ port@7 {
+ reg = <7>;
+
+ adv7482_ain7: endpoint {
+ remote-endpoint = <&cvbs_con>;
+ };
};
- };
- port@8 {
- reg = <8>;
+ port@8 {
+ reg = <8>;
- adv7482_hdmi: endpoint {
- remote-endpoint = <&hdmi_in_con>;
+ adv7482_hdmi: endpoint {
+ remote-endpoint = <&hdmi_in_con>;
+ };
};
- };
- port@a {
- reg = <10>;
+ port@a {
+ reg = <10>;
- adv7482_txa: endpoint {
- clock-lanes = <0>;
- data-lanes = <1 2>;
- remote-endpoint = <&csi40_in>;
+ adv7482_txa: endpoint {
+ clock-lanes = <0>;
+ data-lanes = <1 2>;
+ remote-endpoint = <&csi40_in>;
+ };
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index eb1f3b82300b1601..5a55ed7a7efac181 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -524,47 +524,49 @@ video-receiver@70 {
reg-names = "main", "dpll", "cp", "hdmi", "edid", "repeater",
"infoframe", "cbus", "cec", "sdp", "txa", "txb" ;
- #address-cells = <1>;
- #size-cells = <0>;
-
interrupt-parent = <&gpio6>;
interrupt-names = "intrq1", "intrq2";
interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
<31 IRQ_TYPE_LEVEL_LOW>;
- port@7 {
- reg = <7>;
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
- adv7482_ain7: endpoint {
- remote-endpoint = <&cvbs_con>;
+ port@7 {
+ reg = <7>;
+
+ adv7482_ain7: endpoint {
+ remote-endpoint = <&cvbs_con>;
+ };
};
- };
- port@8 {
- reg = <8>;
+ port@8 {
+ reg = <8>;
- adv7482_hdmi: endpoint {
- remote-endpoint = <&hdmi_in_con>;
+ adv7482_hdmi: endpoint {
+ remote-endpoint = <&hdmi_in_con>;
+ };
};
- };
- port@a {
- reg = <10>;
+ port@a {
+ reg = <10>;
- adv7482_txa: endpoint {
- clock-lanes = <0>;
- data-lanes = <1 2 3 4>;
- remote-endpoint = <&csi40_in>;
+ adv7482_txa: endpoint {
+ clock-lanes = <0>;
+ data-lanes = <1 2 3 4>;
+ remote-endpoint = <&csi40_in>;
+ };
};
- };
- port@b {
- reg = <11>;
+ port@b {
+ reg = <11>;
- adv7482_txb: endpoint {
- clock-lanes = <0>;
- data-lanes = <1>;
- remote-endpoint = <&csi20_in>;
+ adv7482_txb: endpoint {
+ clock-lanes = <0>;
+ data-lanes = <1>;
+ remote-endpoint = <&csi20_in>;
+ };
};
};
};
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: renesas: Add ports node to all adv7482 nodes
2021-10-12 18:34 [PATCH] arm64: dts: renesas: Add ports node to all adv7482 nodes Niklas Söderlund
@ 2021-10-13 14:57 ` Geert Uytterhoeven
2021-10-13 15:55 ` Sergei Shtylyov
2021-10-15 12:48 ` Kieran Bingham
1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-10-13 14:57 UTC (permalink / raw)
To: Niklas Söderlund; +Cc: Geert Uytterhoeven, Linux-Renesas
Hi Niklas,
On Tue, Oct 12, 2021 at 8:34 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> The different port@ entries of the adv7482 nodes shall be encapsulated
> in a ports node, add one. This change do not change how the driver
does
> parses the DT and no driver change is needed.
>
> The change however makes it possible to validate the source files with a
> correct json-schema.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
arch/arm64/boot/dts/renesas/ebisu.dtsi, I assume? ;-)
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.16, with the above fixed.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: renesas: Add ports node to all adv7482 nodes
2021-10-13 14:57 ` Geert Uytterhoeven
@ 2021-10-13 15:55 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2021-10-13 15:55 UTC (permalink / raw)
To: Geert Uytterhoeven, Niklas Söderlund
Cc: Geert Uytterhoeven, Linux-Renesas
On 10/13/21 5:57 PM, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Tue, Oct 12, 2021 at 8:34 PM Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
>> The different port@ entries of the adv7482 nodes shall be encapsulated
>> in a ports node, add one. This change do not change how the driver
>
> does
It's tautological either way. ;-)
>> parses the DT and no driver change is needed.
>>
>> The change however makes it possible to validate the source files with a
>> correct json-schema.
>>
>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: Add ports node to all adv7482 nodes
2021-10-12 18:34 [PATCH] arm64: dts: renesas: Add ports node to all adv7482 nodes Niklas Söderlund
2021-10-13 14:57 ` Geert Uytterhoeven
@ 2021-10-15 12:48 ` Kieran Bingham
1 sibling, 0 replies; 4+ messages in thread
From: Kieran Bingham @ 2021-10-15 12:48 UTC (permalink / raw)
To: Geert Uytterhoeven, Niklas Söderlund
Cc: linux-renesas-soc, Niklas Söderlund
Quoting Niklas Söderlund (2021-10-12 19:34:31)
> The different port@ entries of the adv7482 nodes shall be encapsulated
> in a ports node, add one. This change do not change how the driver
> parses the DT and no driver change is needed.
>
> The change however makes it possible to validate the source files with a
> correct json-schema.
>
Nice to fix up the validation.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> .../arm64/boot/dts/renesas/r8a77990-ebisu.dts | 40 +++++++-------
> .../boot/dts/renesas/salvator-common.dtsi | 54 ++++++++++---------
> 2 files changed, 49 insertions(+), 45 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 9c7146084ea1c779..b051e2f3aceb5a17 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -423,37 +423,39 @@ video-receiver@70 {
> compatible = "adi,adv7482";
> reg = <0x70>;
>
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> interrupt-parent = <&gpio0>;
> interrupt-names = "intrq1", "intrq2";
> interrupts = <7 IRQ_TYPE_LEVEL_LOW>,
> <17 IRQ_TYPE_LEVEL_LOW>;
>
> - port@7 {
> - reg = <7>;
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - adv7482_ain7: endpoint {
> - remote-endpoint = <&cvbs_con>;
> + port@7 {
> + reg = <7>;
> +
> + adv7482_ain7: endpoint {
> + remote-endpoint = <&cvbs_con>;
> + };
> };
> - };
>
> - port@8 {
> - reg = <8>;
> + port@8 {
> + reg = <8>;
>
> - adv7482_hdmi: endpoint {
> - remote-endpoint = <&hdmi_in_con>;
> + adv7482_hdmi: endpoint {
> + remote-endpoint = <&hdmi_in_con>;
> + };
> };
> - };
>
> - port@a {
> - reg = <10>;
> + port@a {
> + reg = <10>;
>
> - adv7482_txa: endpoint {
> - clock-lanes = <0>;
> - data-lanes = <1 2>;
> - remote-endpoint = <&csi40_in>;
> + adv7482_txa: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2>;
> + remote-endpoint = <&csi40_in>;
> + };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index eb1f3b82300b1601..5a55ed7a7efac181 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -524,47 +524,49 @@ video-receiver@70 {
> reg-names = "main", "dpll", "cp", "hdmi", "edid", "repeater",
> "infoframe", "cbus", "cec", "sdp", "txa", "txb" ;
>
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> interrupt-parent = <&gpio6>;
> interrupt-names = "intrq1", "intrq2";
> interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
> <31 IRQ_TYPE_LEVEL_LOW>;
>
> - port@7 {
> - reg = <7>;
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - adv7482_ain7: endpoint {
> - remote-endpoint = <&cvbs_con>;
> + port@7 {
> + reg = <7>;
> +
> + adv7482_ain7: endpoint {
> + remote-endpoint = <&cvbs_con>;
> + };
> };
> - };
>
> - port@8 {
> - reg = <8>;
> + port@8 {
> + reg = <8>;
>
> - adv7482_hdmi: endpoint {
> - remote-endpoint = <&hdmi_in_con>;
> + adv7482_hdmi: endpoint {
> + remote-endpoint = <&hdmi_in_con>;
> + };
> };
> - };
>
> - port@a {
> - reg = <10>;
> + port@a {
> + reg = <10>;
>
> - adv7482_txa: endpoint {
> - clock-lanes = <0>;
> - data-lanes = <1 2 3 4>;
> - remote-endpoint = <&csi40_in>;
> + adv7482_txa: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&csi40_in>;
> + };
> };
> - };
>
> - port@b {
> - reg = <11>;
> + port@b {
> + reg = <11>;
>
> - adv7482_txb: endpoint {
> - clock-lanes = <0>;
> - data-lanes = <1>;
> - remote-endpoint = <&csi20_in>;
> + adv7482_txb: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1>;
> + remote-endpoint = <&csi20_in>;
> + };
> };
> };
> };
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-15 12:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12 18:34 [PATCH] arm64: dts: renesas: Add ports node to all adv7482 nodes Niklas Söderlund
2021-10-13 14:57 ` Geert Uytterhoeven
2021-10-13 15:55 ` Sergei Shtylyov
2021-10-15 12:48 ` Kieran Bingham
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.