* [PATCH v1 0/2] arm64: Support devapc on MediaTek MT6779 platform
@ 2020-12-23 8:44 ` Neal Liu
0 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 8:44 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger, Catalin Marinas, Will Deacon
Cc: Neal Liu, devicetree, linux-arm-kernel, linux-mediatek, lkml,
Hanks Chen, Jackson-kt Chang, wsd_upstream
This series adds DEVAPC (Device Access Permission Control) support on MediaTek MT6779 SoC platform.
*** BLURB HERE ***
Neal Liu (2):
arm64: dts: mt6779: Support devapc
arm64: configs: Support DEVAPC on MediaTek platforms
arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 ++++++++
arch/arm64/configs/defconfig | 1 +
2 files changed, 9 insertions(+)
--
2.18.0
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v1 0/2] arm64: Support devapc on MediaTek MT6779 platform
@ 2020-12-23 8:44 ` Neal Liu
0 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 8:44 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger, Catalin Marinas, Will Deacon
Cc: devicetree, wsd_upstream, Hanks Chen, lkml, linux-mediatek,
Neal Liu, Jackson-kt Chang, linux-arm-kernel
This series adds DEVAPC (Device Access Permission Control) support on MediaTek MT6779 SoC platform.
*** BLURB HERE ***
Neal Liu (2):
arm64: dts: mt6779: Support devapc
arm64: configs: Support DEVAPC on MediaTek platforms
arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 ++++++++
arch/arm64/configs/defconfig | 1 +
2 files changed, 9 insertions(+)
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v1 0/2] arm64: Support devapc on MediaTek MT6779 platform
@ 2020-12-23 8:44 ` Neal Liu
0 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 8:44 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger, Catalin Marinas, Will Deacon
Cc: devicetree, wsd_upstream, Hanks Chen, lkml, linux-mediatek,
Neal Liu, Jackson-kt Chang, linux-arm-kernel
This series adds DEVAPC (Device Access Permission Control) support on MediaTek MT6779 SoC platform.
*** BLURB HERE ***
Neal Liu (2):
arm64: dts: mt6779: Support devapc
arm64: configs: Support DEVAPC on MediaTek platforms
arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 ++++++++
arch/arm64/configs/defconfig | 1 +
2 files changed, 9 insertions(+)
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v1 1/2] arm64: dts: mt6779: Support devapc
2020-12-23 8:44 ` Neal Liu
(?)
@ 2020-12-23 8:44 ` Neal Liu
-1 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 8:44 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger, Catalin Marinas, Will Deacon
Cc: Neal Liu, devicetree, linux-arm-kernel, linux-mediatek, lkml,
Hanks Chen, Jackson-kt Chang, wsd_upstream
Signed-off-by: Neal Liu <neal.liu@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
index 370f309..52ecfc7 100644
--- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
@@ -189,6 +189,14 @@
#clock-cells = <1>;
};
+ devapc: devapc@10207000 {
+ compatible = "mediatek,mt6779-devapc";
+ reg = <0 0x10207000 0 0x1000>;
+ interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_LOW>;
+ clocks = <&infracfg_ao CLK_INFRA_DEVICE_APC>;
+ clock-names = "devapc-infra-clock";
+ };
+
uart0: serial@11002000 {
compatible = "mediatek,mt6779-uart",
"mediatek,mt6577-uart";
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v1 1/2] arm64: dts: mt6779: Support devapc
@ 2020-12-23 8:44 ` Neal Liu
0 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 8:44 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger, Catalin Marinas, Will Deacon
Cc: devicetree, wsd_upstream, Hanks Chen, lkml, linux-mediatek,
Neal Liu, Jackson-kt Chang, linux-arm-kernel
Signed-off-by: Neal Liu <neal.liu@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
index 370f309..52ecfc7 100644
--- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
@@ -189,6 +189,14 @@
#clock-cells = <1>;
};
+ devapc: devapc@10207000 {
+ compatible = "mediatek,mt6779-devapc";
+ reg = <0 0x10207000 0 0x1000>;
+ interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_LOW>;
+ clocks = <&infracfg_ao CLK_INFRA_DEVICE_APC>;
+ clock-names = "devapc-infra-clock";
+ };
+
uart0: serial@11002000 {
compatible = "mediatek,mt6779-uart",
"mediatek,mt6577-uart";
--
1.7.9.5
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v1 1/2] arm64: dts: mt6779: Support devapc
@ 2020-12-23 8:44 ` Neal Liu
0 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 8:44 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger, Catalin Marinas, Will Deacon
Cc: devicetree, wsd_upstream, Hanks Chen, lkml, linux-mediatek,
Neal Liu, Jackson-kt Chang, linux-arm-kernel
Signed-off-by: Neal Liu <neal.liu@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
index 370f309..52ecfc7 100644
--- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
@@ -189,6 +189,14 @@
#clock-cells = <1>;
};
+ devapc: devapc@10207000 {
+ compatible = "mediatek,mt6779-devapc";
+ reg = <0 0x10207000 0 0x1000>;
+ interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_LOW>;
+ clocks = <&infracfg_ao CLK_INFRA_DEVICE_APC>;
+ clock-names = "devapc-infra-clock";
+ };
+
uart0: serial@11002000 {
compatible = "mediatek,mt6779-uart",
"mediatek,mt6577-uart";
--
1.7.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
2020-12-23 8:44 ` Neal Liu
(?)
@ 2020-12-23 8:44 ` Neal Liu
-1 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 8:44 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger, Catalin Marinas, Will Deacon
Cc: Neal Liu, devicetree, linux-arm-kernel, linux-mediatek, lkml,
Hanks Chen, Jackson-kt Chang, wsd_upstream
Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
Signed-off-by: Neal Liu <neal.liu@mediatek.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 17a2df6..a373776 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
CONFIG_MTD_NAND_FSL_IFC=y
CONFIG_MTD_NAND_QCOM=y
CONFIG_MTD_SPI_NOR=y
+CONFIG_MTK_DEVAPC=m
CONFIG_SPI_CADENCE_QUADSPI=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_BLK_DEV_NBD=m
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
@ 2020-12-23 8:44 ` Neal Liu
0 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 8:44 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger, Catalin Marinas, Will Deacon
Cc: devicetree, wsd_upstream, Hanks Chen, lkml, linux-mediatek,
Neal Liu, Jackson-kt Chang, linux-arm-kernel
Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
Signed-off-by: Neal Liu <neal.liu@mediatek.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 17a2df6..a373776 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
CONFIG_MTD_NAND_FSL_IFC=y
CONFIG_MTD_NAND_QCOM=y
CONFIG_MTD_SPI_NOR=y
+CONFIG_MTK_DEVAPC=m
CONFIG_SPI_CADENCE_QUADSPI=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_BLK_DEV_NBD=m
--
1.7.9.5
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
@ 2020-12-23 8:44 ` Neal Liu
0 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 8:44 UTC (permalink / raw)
To: Rob Herring, Matthias Brugger, Catalin Marinas, Will Deacon
Cc: devicetree, wsd_upstream, Hanks Chen, lkml, linux-mediatek,
Neal Liu, Jackson-kt Chang, linux-arm-kernel
Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
Signed-off-by: Neal Liu <neal.liu@mediatek.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 17a2df6..a373776 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
CONFIG_MTD_NAND_FSL_IFC=y
CONFIG_MTD_NAND_QCOM=y
CONFIG_MTD_SPI_NOR=y
+CONFIG_MTK_DEVAPC=m
CONFIG_SPI_CADENCE_QUADSPI=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_BLK_DEV_NBD=m
--
1.7.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH v1 1/2] arm64: dts: mt6779: Support devapc
2020-12-23 8:44 ` Neal Liu
(?)
@ 2020-12-23 9:52 ` Neal Liu
-1 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 9:52 UTC (permalink / raw)
To: Rob Herring, Will Deacon, Catalin Marinas, Matthias Brugger
Cc: Neal Liu, devicetree, linux-arm-kernel, linux-mediatek, lkml,
Hanks Chen (陳彥廷),
Jackson-kt Chang (張國澤),
wsd_upstream
+add comments & reviewed-by Hanks
On Wed, 2020-12-23 at 16:44 +0800, Neal Liu wrote:
Support DEVAPC on MT6779 platforms by adding device node.
Reviewed-by: Hanks Chen <hanks.chen@mediatek.com>
> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> index 370f309..52ecfc7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> @@ -189,6 +189,14 @@
> #clock-cells = <1>;
> };
>
> + devapc: devapc@10207000 {
> + compatible = "mediatek,mt6779-devapc";
> + reg = <0 0x10207000 0 0x1000>;
> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&infracfg_ao CLK_INFRA_DEVICE_APC>;
> + clock-names = "devapc-infra-clock";
> + };
> +
> uart0: serial@11002000 {
> compatible = "mediatek,mt6779-uart",
> "mediatek,mt6577-uart";
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v1 1/2] arm64: dts: mt6779: Support devapc
@ 2020-12-23 9:52 ` Neal Liu
0 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 9:52 UTC (permalink / raw)
To: Rob Herring, Will Deacon, Catalin Marinas, Matthias Brugger
Cc: devicetree, wsd_upstream, Hanks Chen (陳彥廷),
lkml, linux-mediatek, Neal Liu,
Jackson-kt Chang (張國澤),
linux-arm-kernel
+add comments & reviewed-by Hanks
On Wed, 2020-12-23 at 16:44 +0800, Neal Liu wrote:
Support DEVAPC on MT6779 platforms by adding device node.
Reviewed-by: Hanks Chen <hanks.chen@mediatek.com>
> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> index 370f309..52ecfc7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> @@ -189,6 +189,14 @@
> #clock-cells = <1>;
> };
>
> + devapc: devapc@10207000 {
> + compatible = "mediatek,mt6779-devapc";
> + reg = <0 0x10207000 0 0x1000>;
> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&infracfg_ao CLK_INFRA_DEVICE_APC>;
> + clock-names = "devapc-infra-clock";
> + };
> +
> uart0: serial@11002000 {
> compatible = "mediatek,mt6779-uart",
> "mediatek,mt6577-uart";
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v1 1/2] arm64: dts: mt6779: Support devapc
@ 2020-12-23 9:52 ` Neal Liu
0 siblings, 0 replies; 20+ messages in thread
From: Neal Liu @ 2020-12-23 9:52 UTC (permalink / raw)
To: Rob Herring, Will Deacon, Catalin Marinas, Matthias Brugger
Cc: devicetree, wsd_upstream, Hanks Chen (陳彥廷),
lkml, linux-mediatek, Neal Liu,
Jackson-kt Chang (張國澤),
linux-arm-kernel
+add comments & reviewed-by Hanks
On Wed, 2020-12-23 at 16:44 +0800, Neal Liu wrote:
Support DEVAPC on MT6779 platforms by adding device node.
Reviewed-by: Hanks Chen <hanks.chen@mediatek.com>
> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> index 370f309..52ecfc7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> @@ -189,6 +189,14 @@
> #clock-cells = <1>;
> };
>
> + devapc: devapc@10207000 {
> + compatible = "mediatek,mt6779-devapc";
> + reg = <0 0x10207000 0 0x1000>;
> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&infracfg_ao CLK_INFRA_DEVICE_APC>;
> + clock-names = "devapc-infra-clock";
> + };
> +
> uart0: serial@11002000 {
> compatible = "mediatek,mt6779-uart",
> "mediatek,mt6577-uart";
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
2020-12-23 8:44 ` Neal Liu
(?)
(?)
@ 2021-01-31 14:07 ` Matthias Brugger
2021-01-31 22:23 ` Arnd Bergmann
-1 siblings, 1 reply; 20+ messages in thread
From: Matthias Brugger @ 2021-01-31 14:07 UTC (permalink / raw)
To: Neal Liu, Rob Herring, Catalin Marinas, Will Deacon, SoC Team
Cc: devicetree, linux-arm-kernel, linux-mediatek, lkml, Hanks Chen,
Jackson-kt Chang, wsd_upstream
On 23/12/2020 09:44, Neal Liu wrote:
> Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
>
> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> ---
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 17a2df6..a373776 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
> CONFIG_MTD_NAND_FSL_IFC=y
> CONFIG_MTD_NAND_QCOM=y
> CONFIG_MTD_SPI_NOR=y
> +CONFIG_MTK_DEVAPC=m
> CONFIG_SPI_CADENCE_QUADSPI=y
> CONFIG_BLK_DEV_LOOP=y
> CONFIG_BLK_DEV_NBD=m
>
From my understanding, defconfig is for a minimal config that allows to boot a
machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
violations, I think it's not a good candidate for inclusion in defconfig.
In any case, I added the SoC maintainer, so that they can correct me, if I'm
wrong :)
Regards,
Matthias
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
@ 2021-01-31 22:23 ` Arnd Bergmann
0 siblings, 0 replies; 20+ messages in thread
From: Arnd Bergmann @ 2021-01-31 22:23 UTC (permalink / raw)
To: Matthias Brugger
Cc: Neal Liu, Rob Herring, Catalin Marinas, Will Deacon, SoC Team,
DTML, wsd_upstream, Hanks Chen, lkml,
moderated list:ARM/Mediatek SoC...,
Jackson-kt Chang, Linux ARM
On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> On 23/12/2020 09:44, Neal Liu wrote:
> > Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
> >
> > Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 17a2df6..a373776 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
> > CONFIG_MTD_NAND_FSL_IFC=y
> > CONFIG_MTD_NAND_QCOM=y
> > CONFIG_MTD_SPI_NOR=y
> > +CONFIG_MTK_DEVAPC=m
> > CONFIG_SPI_CADENCE_QUADSPI=y
> > CONFIG_BLK_DEV_LOOP=y
> > CONFIG_BLK_DEV_NBD=m
> >
>
> From my understanding, defconfig is for a minimal config that allows to boot a
> machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
> violations, I think it's not a good candidate for inclusion in defconfig.
>
> In any case, I added the SoC maintainer, so that they can correct me, if I'm
> wrong :)
I generally don't mind adding platform specific drivers as loadable modules
even if they are somewhat obscure. For built-in drivers, this is
different though,
as those have a noticeable impact on other platforms.
I haven't kept track of what this particular driver does, but from the Kconfig
description, I'd say it should get enabled in defconfig.
Arnd
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
@ 2021-01-31 22:23 ` Arnd Bergmann
0 siblings, 0 replies; 20+ messages in thread
From: Arnd Bergmann @ 2021-01-31 22:23 UTC (permalink / raw)
To: Matthias Brugger
Cc: DTML, wsd_upstream, Catalin Marinas, Hanks Chen, lkml, SoC Team,
Rob Herring, Neal Liu, Linux ARM,
moderated list:ARM/Mediatek SoC...,
Will Deacon, Jackson-kt Chang
On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> On 23/12/2020 09:44, Neal Liu wrote:
> > Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
> >
> > Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 17a2df6..a373776 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
> > CONFIG_MTD_NAND_FSL_IFC=y
> > CONFIG_MTD_NAND_QCOM=y
> > CONFIG_MTD_SPI_NOR=y
> > +CONFIG_MTK_DEVAPC=m
> > CONFIG_SPI_CADENCE_QUADSPI=y
> > CONFIG_BLK_DEV_LOOP=y
> > CONFIG_BLK_DEV_NBD=m
> >
>
> From my understanding, defconfig is for a minimal config that allows to boot a
> machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
> violations, I think it's not a good candidate for inclusion in defconfig.
>
> In any case, I added the SoC maintainer, so that they can correct me, if I'm
> wrong :)
I generally don't mind adding platform specific drivers as loadable modules
even if they are somewhat obscure. For built-in drivers, this is
different though,
as those have a noticeable impact on other platforms.
I haven't kept track of what this particular driver does, but from the Kconfig
description, I'd say it should get enabled in defconfig.
Arnd
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
@ 2021-01-31 22:23 ` Arnd Bergmann
0 siblings, 0 replies; 20+ messages in thread
From: Arnd Bergmann @ 2021-01-31 22:23 UTC (permalink / raw)
To: Matthias Brugger
Cc: DTML, wsd_upstream, Catalin Marinas, Hanks Chen, lkml, SoC Team,
Rob Herring, Neal Liu, Linux ARM,
moderated list:ARM/Mediatek SoC...,
Will Deacon, Jackson-kt Chang
On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> On 23/12/2020 09:44, Neal Liu wrote:
> > Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
> >
> > Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 17a2df6..a373776 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
> > CONFIG_MTD_NAND_FSL_IFC=y
> > CONFIG_MTD_NAND_QCOM=y
> > CONFIG_MTD_SPI_NOR=y
> > +CONFIG_MTK_DEVAPC=m
> > CONFIG_SPI_CADENCE_QUADSPI=y
> > CONFIG_BLK_DEV_LOOP=y
> > CONFIG_BLK_DEV_NBD=m
> >
>
> From my understanding, defconfig is for a minimal config that allows to boot a
> machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
> violations, I think it's not a good candidate for inclusion in defconfig.
>
> In any case, I added the SoC maintainer, so that they can correct me, if I'm
> wrong :)
I generally don't mind adding platform specific drivers as loadable modules
even if they are somewhat obscure. For built-in drivers, this is
different though,
as those have a noticeable impact on other platforms.
I haven't kept track of what this particular driver does, but from the Kconfig
description, I'd say it should get enabled in defconfig.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
2021-01-31 22:23 ` Arnd Bergmann
(?)
(?)
@ 2021-02-01 8:50 ` Matthias Brugger
-1 siblings, 0 replies; 20+ messages in thread
From: Matthias Brugger @ 2021-02-01 8:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Neal Liu, Rob Herring, Catalin Marinas, Will Deacon, SoC Team,
DTML, wsd_upstream, Hanks Chen, lkml,
moderated list:ARM/Mediatek SoC...,
Jackson-kt Chang, Linux ARM
On 31/01/2021 23:23, Arnd Bergmann wrote:
> On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>> On 23/12/2020 09:44, Neal Liu wrote:
>>> Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
>>>
>>> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
>>> ---
>>> arch/arm64/configs/defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 17a2df6..a373776 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
>>> CONFIG_MTD_NAND_FSL_IFC=y
>>> CONFIG_MTD_NAND_QCOM=y
>>> CONFIG_MTD_SPI_NOR=y
>>> +CONFIG_MTK_DEVAPC=m
>>> CONFIG_SPI_CADENCE_QUADSPI=y
>>> CONFIG_BLK_DEV_LOOP=y
>>> CONFIG_BLK_DEV_NBD=m
>>>
>>
>> From my understanding, defconfig is for a minimal config that allows to boot a
>> machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
>> violations, I think it's not a good candidate for inclusion in defconfig.
>>
>> In any case, I added the SoC maintainer, so that they can correct me, if I'm
>> wrong :)
>
> I generally don't mind adding platform specific drivers as loadable modules
> even if they are somewhat obscure. For built-in drivers, this is
> different though,
> as those have a noticeable impact on other platforms.
>
> I haven't kept track of what this particular driver does, but from the Kconfig
> description, I'd say it should get enabled in defconfig.
>
Thanks for the feedback Arnd.
Applied now to v5.11-next/defconfig
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
@ 2021-02-01 8:50 ` Matthias Brugger
0 siblings, 0 replies; 20+ messages in thread
From: Matthias Brugger @ 2021-02-01 8:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Neal Liu, Rob Herring, Catalin Marinas, Will Deacon, SoC Team,
DTML, wsd_upstream, Hanks Chen, lkml,
moderated list:ARM/Mediatek SoC...,
Jackson-kt Chang, Linux ARM
On 31/01/2021 23:23, Arnd Bergmann wrote:
> On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>> On 23/12/2020 09:44, Neal Liu wrote:
>>> Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
>>>
>>> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
>>> ---
>>> arch/arm64/configs/defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 17a2df6..a373776 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
>>> CONFIG_MTD_NAND_FSL_IFC=y
>>> CONFIG_MTD_NAND_QCOM=y
>>> CONFIG_MTD_SPI_NOR=y
>>> +CONFIG_MTK_DEVAPC=m
>>> CONFIG_SPI_CADENCE_QUADSPI=y
>>> CONFIG_BLK_DEV_LOOP=y
>>> CONFIG_BLK_DEV_NBD=m
>>>
>>
>> From my understanding, defconfig is for a minimal config that allows to boot a
>> machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
>> violations, I think it's not a good candidate for inclusion in defconfig.
>>
>> In any case, I added the SoC maintainer, so that they can correct me, if I'm
>> wrong :)
>
> I generally don't mind adding platform specific drivers as loadable modules
> even if they are somewhat obscure. For built-in drivers, this is
> different though,
> as those have a noticeable impact on other platforms.
>
> I haven't kept track of what this particular driver does, but from the Kconfig
> description, I'd say it should get enabled in defconfig.
>
Thanks for the feedback Arnd.
Applied now to v5.11-next/defconfig
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
@ 2021-02-01 8:50 ` Matthias Brugger
0 siblings, 0 replies; 20+ messages in thread
From: Matthias Brugger @ 2021-02-01 8:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: DTML, wsd_upstream, Catalin Marinas, Hanks Chen, lkml, SoC Team,
Rob Herring, Neal Liu, Linux ARM,
moderated list:ARM/Mediatek SoC...,
Will Deacon, Jackson-kt Chang
On 31/01/2021 23:23, Arnd Bergmann wrote:
> On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>> On 23/12/2020 09:44, Neal Liu wrote:
>>> Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
>>>
>>> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
>>> ---
>>> arch/arm64/configs/defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 17a2df6..a373776 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
>>> CONFIG_MTD_NAND_FSL_IFC=y
>>> CONFIG_MTD_NAND_QCOM=y
>>> CONFIG_MTD_SPI_NOR=y
>>> +CONFIG_MTK_DEVAPC=m
>>> CONFIG_SPI_CADENCE_QUADSPI=y
>>> CONFIG_BLK_DEV_LOOP=y
>>> CONFIG_BLK_DEV_NBD=m
>>>
>>
>> From my understanding, defconfig is for a minimal config that allows to boot a
>> machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
>> violations, I think it's not a good candidate for inclusion in defconfig.
>>
>> In any case, I added the SoC maintainer, so that they can correct me, if I'm
>> wrong :)
>
> I generally don't mind adding platform specific drivers as loadable modules
> even if they are somewhat obscure. For built-in drivers, this is
> different though,
> as those have a noticeable impact on other platforms.
>
> I haven't kept track of what this particular driver does, but from the Kconfig
> description, I'd say it should get enabled in defconfig.
>
Thanks for the feedback Arnd.
Applied now to v5.11-next/defconfig
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms
@ 2021-02-01 8:50 ` Matthias Brugger
0 siblings, 0 replies; 20+ messages in thread
From: Matthias Brugger @ 2021-02-01 8:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: DTML, wsd_upstream, Catalin Marinas, Hanks Chen, lkml, SoC Team,
Rob Herring, Neal Liu, Linux ARM,
moderated list:ARM/Mediatek SoC...,
Will Deacon, Jackson-kt Chang
On 31/01/2021 23:23, Arnd Bergmann wrote:
> On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>> On 23/12/2020 09:44, Neal Liu wrote:
>>> Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
>>>
>>> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
>>> ---
>>> arch/arm64/configs/defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 17a2df6..a373776 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
>>> CONFIG_MTD_NAND_FSL_IFC=y
>>> CONFIG_MTD_NAND_QCOM=y
>>> CONFIG_MTD_SPI_NOR=y
>>> +CONFIG_MTK_DEVAPC=m
>>> CONFIG_SPI_CADENCE_QUADSPI=y
>>> CONFIG_BLK_DEV_LOOP=y
>>> CONFIG_BLK_DEV_NBD=m
>>>
>>
>> From my understanding, defconfig is for a minimal config that allows to boot a
>> machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
>> violations, I think it's not a good candidate for inclusion in defconfig.
>>
>> In any case, I added the SoC maintainer, so that they can correct me, if I'm
>> wrong :)
>
> I generally don't mind adding platform specific drivers as loadable modules
> even if they are somewhat obscure. For built-in drivers, this is
> different though,
> as those have a noticeable impact on other platforms.
>
> I haven't kept track of what this particular driver does, but from the Kconfig
> description, I'd say it should get enabled in defconfig.
>
Thanks for the feedback Arnd.
Applied now to v5.11-next/defconfig
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2021-02-01 8:51 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23 8:44 [PATCH v1 0/2] arm64: Support devapc on MediaTek MT6779 platform Neal Liu
2020-12-23 8:44 ` Neal Liu
2020-12-23 8:44 ` Neal Liu
2020-12-23 8:44 ` [PATCH v1 1/2] arm64: dts: mt6779: Support devapc Neal Liu
2020-12-23 8:44 ` Neal Liu
2020-12-23 8:44 ` Neal Liu
2020-12-23 9:52 ` Neal Liu
2020-12-23 9:52 ` Neal Liu
2020-12-23 9:52 ` Neal Liu
2020-12-23 8:44 ` [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms Neal Liu
2020-12-23 8:44 ` Neal Liu
2020-12-23 8:44 ` Neal Liu
2021-01-31 14:07 ` Matthias Brugger
2021-01-31 22:23 ` Arnd Bergmann
2021-01-31 22:23 ` Arnd Bergmann
2021-01-31 22:23 ` Arnd Bergmann
2021-02-01 8:50 ` Matthias Brugger
2021-02-01 8:50 ` Matthias Brugger
2021-02-01 8:50 ` Matthias Brugger
2021-02-01 8:50 ` Matthias Brugger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.