* [PATCH] spmi: pmic-arb: Add sid and address to error messages
@ 2021-09-20 23:48 Stephen Boyd
2021-09-21 1:45 ` Subbaraman Narayanamurthy
2021-09-21 8:53 ` skakit
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-09-20 23:48 UTC (permalink / raw)
To: Stephen Boyd; +Cc: linux-kernel, Subbaraman Narayanamurthy, satya priya
It's useful to know what particular device/component is having trouble
accessing the bus. Add the sid and address to error messages here so
that debugging is a little simpler.
Cc: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
Cc: satya priya <skakit@codeaurora.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
drivers/spmi/spmi-pmic-arb.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index bbbd311eda03..e397c2532c8d 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -261,20 +261,21 @@ static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
if (status & PMIC_ARB_STATUS_DONE) {
if (status & PMIC_ARB_STATUS_DENIED) {
- dev_err(&ctrl->dev, "%s: transaction denied (0x%x)\n",
- __func__, status);
+ dev_err(&ctrl->dev, "%s: %#x %#x: transaction denied (%#x)\n",
+ __func__, sid, addr, status);
return -EPERM;
}
if (status & PMIC_ARB_STATUS_FAILURE) {
- dev_err(&ctrl->dev, "%s: transaction failed (0x%x)\n",
- __func__, status);
+ dev_err(&ctrl->dev, "%s: %#x %#x: transaction failed (%#x)\n",
+ __func__, sid, addr, status);
+ WARN_ON(1);
return -EIO;
}
if (status & PMIC_ARB_STATUS_DROPPED) {
- dev_err(&ctrl->dev, "%s: transaction dropped (0x%x)\n",
- __func__, status);
+ dev_err(&ctrl->dev, "%s: %#x %#x: transaction dropped (%#x)\n",
+ __func__, sid, addr, status);
return -EIO;
}
@@ -283,8 +284,8 @@ static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
udelay(1);
}
- dev_err(&ctrl->dev, "%s: timeout, status 0x%x\n",
- __func__, status);
+ dev_err(&ctrl->dev, "%s: %#x %#x: timeout, status %#x\n",
+ __func__, sid, addr, status);
return -ETIMEDOUT;
}
--
https://chromeos.dev
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] spmi: pmic-arb: Add sid and address to error messages
2021-09-20 23:48 [PATCH] spmi: pmic-arb: Add sid and address to error messages Stephen Boyd
@ 2021-09-21 1:45 ` Subbaraman Narayanamurthy
2021-09-21 8:53 ` skakit
1 sibling, 0 replies; 3+ messages in thread
From: Subbaraman Narayanamurthy @ 2021-09-21 1:45 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Stephen Boyd, linux-kernel, satya priya, David Collins
On 9/20/21 4:48 PM, Stephen Boyd wrote:
> It's useful to know what particular device/component is having trouble
> accessing the bus. Add the sid and address to error messages here so
> that debugging is a little simpler.
>
> Cc: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
> Cc: satya priya <skakit@codeaurora.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
> ---
> drivers/spmi/spmi-pmic-arb.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> index bbbd311eda03..e397c2532c8d 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -261,20 +261,21 @@ static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
>
> if (status & PMIC_ARB_STATUS_DONE) {
> if (status & PMIC_ARB_STATUS_DENIED) {
> - dev_err(&ctrl->dev, "%s: transaction denied (0x%x)\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: transaction denied (%#x)\n",
> + __func__, sid, addr, status);
> return -EPERM;
> }
>
> if (status & PMIC_ARB_STATUS_FAILURE) {
> - dev_err(&ctrl->dev, "%s: transaction failed (0x%x)\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: transaction failed (%#x)\n",
> + __func__, sid, addr, status);
> + WARN_ON(1);
> return -EIO;
> }
>
> if (status & PMIC_ARB_STATUS_DROPPED) {
> - dev_err(&ctrl->dev, "%s: transaction dropped (0x%x)\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: transaction dropped (%#x)\n",
> + __func__, sid, addr, status);
> return -EIO;
> }
>
> @@ -283,8 +284,8 @@ static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
> udelay(1);
> }
>
> - dev_err(&ctrl->dev, "%s: timeout, status 0x%x\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: timeout, status %#x\n",
> + __func__, sid, addr, status);
> return -ETIMEDOUT;
> }
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] spmi: pmic-arb: Add sid and address to error messages
2021-09-20 23:48 [PATCH] spmi: pmic-arb: Add sid and address to error messages Stephen Boyd
2021-09-21 1:45 ` Subbaraman Narayanamurthy
@ 2021-09-21 8:53 ` skakit
1 sibling, 0 replies; 3+ messages in thread
From: skakit @ 2021-09-21 8:53 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Stephen Boyd, linux-kernel, Subbaraman Narayanamurthy
On 2021-09-21 05:18, Stephen Boyd wrote:
> It's useful to know what particular device/component is having trouble
> accessing the bus. Add the sid and address to error messages here so
> that debugging is a little simpler.
>
> Cc: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
> Cc: satya priya <skakit@codeaurora.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
Reviewed-by: Satya Priya <skakit@codeaurora.org>
> drivers/spmi/spmi-pmic-arb.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/spmi/spmi-pmic-arb.c
> b/drivers/spmi/spmi-pmic-arb.c
> index bbbd311eda03..e397c2532c8d 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -261,20 +261,21 @@ static int pmic_arb_wait_for_done(struct
> spmi_controller *ctrl,
>
> if (status & PMIC_ARB_STATUS_DONE) {
> if (status & PMIC_ARB_STATUS_DENIED) {
> - dev_err(&ctrl->dev, "%s: transaction denied (0x%x)\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: transaction denied (%#x)\n",
> + __func__, sid, addr, status);
> return -EPERM;
> }
>
> if (status & PMIC_ARB_STATUS_FAILURE) {
> - dev_err(&ctrl->dev, "%s: transaction failed (0x%x)\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: transaction failed (%#x)\n",
> + __func__, sid, addr, status);
> + WARN_ON(1);
> return -EIO;
> }
>
> if (status & PMIC_ARB_STATUS_DROPPED) {
> - dev_err(&ctrl->dev, "%s: transaction dropped (0x%x)\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: transaction dropped (%#x)\n",
> + __func__, sid, addr, status);
> return -EIO;
> }
>
> @@ -283,8 +284,8 @@ static int pmic_arb_wait_for_done(struct
> spmi_controller *ctrl,
> udelay(1);
> }
>
> - dev_err(&ctrl->dev, "%s: timeout, status 0x%x\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: timeout, status %#x\n",
> + __func__, sid, addr, status);
> return -ETIMEDOUT;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-21 8:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20 23:48 [PATCH] spmi: pmic-arb: Add sid and address to error messages Stephen Boyd
2021-09-21 1:45 ` Subbaraman Narayanamurthy
2021-09-21 8:53 ` skakit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.