From: Stephen Boyd <sboyd@kernel.org> To: Andy Gross <agross@kernel.org>, Bartosz Golaszewski <brgl@bgdev.pl>, Bjorn Andersson <andersson@kernel.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Shazad Hussain <quic_shazhuss@quicinc.com>, Michael Turquette <mturquette@baylibre.com>, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Subject: Re: [PATCH 2/7] clk: qcom: add the GPUCC driver for sa8775p Date: Tue, 28 Mar 2023 19:15:08 -0700 [thread overview] Message-ID: <72286603300630b890705c99b42f05a4.sboyd@kernel.org> (raw) In-Reply-To: <20230328193632.226095-3-brgl@bgdev.pl> Quoting Bartosz Golaszewski (2023-03-28 12:36:27) > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index 449bc8314d21..5e1919738aeb 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -437,6 +437,14 @@ config SA_GCC_8775P > Say Y if you want to use peripheral devices such as UART, SPI, > I2C, USB, UFS, SDCC, etc. > > +config SA_GPUCC_8775P > + tristate "SA8775P Graphics clock controller" > + select SA_GCC_8775P Should select QCOM_GDSC as well. > + help > + Support for the graphics clock controller on SA8775P devices. > + Say Y if you want to support graphics controller devices and > + functionality such as 3D graphics. > + > config SC_GCC_7180 > tristate "SC7180 Global Clock Controller" > select QCOM_GDSC > diff --git a/drivers/clk/qcom/gpucc-sa8775p.c b/drivers/clk/qcom/gpucc-sa8775p.c > new file mode 100644 > index 000000000000..46d73bd0199b > --- /dev/null > +++ b/drivers/clk/qcom/gpucc-sa8775p.c > @@ -0,0 +1,633 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2021-2022, Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2023, Linaro Limited > + */ > + > +#include <linux/clk.h> Is this include used? If not, remove it as this is a clk provider and not a clk consumer.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org> To: Andy Gross <agross@kernel.org>, Bartosz Golaszewski <brgl@bgdev.pl>, Bjorn Andersson <andersson@kernel.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Shazad Hussain <quic_shazhuss@quicinc.com>, Michael Turquette <mturquette@baylibre.com>, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Subject: Re: [PATCH 2/7] clk: qcom: add the GPUCC driver for sa8775p Date: Tue, 28 Mar 2023 19:15:08 -0700 [thread overview] Message-ID: <72286603300630b890705c99b42f05a4.sboyd@kernel.org> (raw) In-Reply-To: <20230328193632.226095-3-brgl@bgdev.pl> Quoting Bartosz Golaszewski (2023-03-28 12:36:27) > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index 449bc8314d21..5e1919738aeb 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -437,6 +437,14 @@ config SA_GCC_8775P > Say Y if you want to use peripheral devices such as UART, SPI, > I2C, USB, UFS, SDCC, etc. > > +config SA_GPUCC_8775P > + tristate "SA8775P Graphics clock controller" > + select SA_GCC_8775P Should select QCOM_GDSC as well. > + help > + Support for the graphics clock controller on SA8775P devices. > + Say Y if you want to support graphics controller devices and > + functionality such as 3D graphics. > + > config SC_GCC_7180 > tristate "SC7180 Global Clock Controller" > select QCOM_GDSC > diff --git a/drivers/clk/qcom/gpucc-sa8775p.c b/drivers/clk/qcom/gpucc-sa8775p.c > new file mode 100644 > index 000000000000..46d73bd0199b > --- /dev/null > +++ b/drivers/clk/qcom/gpucc-sa8775p.c > @@ -0,0 +1,633 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2021-2022, Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2023, Linaro Limited > + */ > + > +#include <linux/clk.h> Is this include used? If not, remove it as this is a clk provider and not a clk consumer. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-29 2:15 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-28 19:36 [PATCH 0/7] arm64: dts: qcom: sa8775p: add more IOMMUs Bartosz Golaszewski 2023-03-28 19:36 ` Bartosz Golaszewski 2023-03-28 19:36 ` [PATCH 1/7] dt-bindings: clock: qcom: describe the GPUCC clock for SA8775P Bartosz Golaszewski 2023-03-28 19:36 ` Bartosz Golaszewski 2023-03-29 8:30 ` Krzysztof Kozlowski 2023-03-29 8:30 ` Krzysztof Kozlowski 2023-03-28 19:36 ` [PATCH 2/7] clk: qcom: add the GPUCC driver for sa8775p Bartosz Golaszewski 2023-03-28 19:36 ` Bartosz Golaszewski 2023-03-29 2:15 ` Stephen Boyd [this message] 2023-03-29 2:15 ` Stephen Boyd 2023-04-06 11:20 ` Bartosz Golaszewski 2023-04-06 11:20 ` Bartosz Golaszewski 2023-04-10 19:09 ` Stephen Boyd 2023-04-10 19:09 ` Stephen Boyd 2023-03-29 11:30 ` Konrad Dybcio 2023-03-29 11:30 ` Konrad Dybcio 2023-03-28 19:36 ` [PATCH 3/7] arm64: defconfig: enable the SA8775P GPUCC driver Bartosz Golaszewski 2023-03-28 19:36 ` Bartosz Golaszewski 2023-03-29 8:33 ` Krzysztof Kozlowski 2023-03-29 8:33 ` Krzysztof Kozlowski 2023-04-06 13:28 ` Dmitry Baryshkov 2023-04-06 13:28 ` Dmitry Baryshkov 2023-03-28 19:36 ` [PATCH 4/7] dt-bindings: iommu: arm,smmu: enable clocks for sa8775p Bartosz Golaszewski 2023-03-28 19:36 ` Bartosz Golaszewski 2023-03-29 8:31 ` Krzysztof Kozlowski 2023-03-29 8:31 ` Krzysztof Kozlowski 2023-04-03 20:41 ` Rob Herring 2023-04-03 20:41 ` Rob Herring 2023-04-03 22:38 ` Konrad Dybcio 2023-04-03 22:38 ` Konrad Dybcio 2023-03-28 19:36 ` [PATCH 5/7] arm64: dts: qcom: sa8775p: add the pcie smmu node Bartosz Golaszewski 2023-03-28 19:36 ` Bartosz Golaszewski 2023-03-29 11:33 ` Konrad Dybcio 2023-03-29 11:33 ` Konrad Dybcio 2023-03-28 19:36 ` [PATCH 6/7] arm64: dts: qcom: sa8775p: add the GPU clock controller node Bartosz Golaszewski 2023-03-28 19:36 ` Bartosz Golaszewski 2023-03-29 11:31 ` Konrad Dybcio 2023-03-29 11:31 ` Konrad Dybcio 2023-03-28 19:36 ` [PATCH 7/7] arm64: dts: qcom: sa8775p: add the GPU IOMMU node Bartosz Golaszewski 2023-03-28 19:36 ` Bartosz Golaszewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=72286603300630b890705c99b42f05a4.sboyd@kernel.org \ --to=sboyd@kernel.org \ --cc=agross@kernel.org \ --cc=andersson@kernel.org \ --cc=bartosz.golaszewski@linaro.org \ --cc=brgl@bgdev.pl \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=iommu@lists.linux.dev \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=quic_shazhuss@quicinc.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.