From: "Benoît Thébaudeau" <benoit@wsystem.com> To: Michael Nazzareno Trimarchi <michael@amarulasolutions.com> Cc: Fabio Estevam <festevam@gmail.com>, Fabio Estevam <fabio.estevam@nxp.com>, Peter Chen <peter.chen@nxp.com>, U-Boot-Denx <u-boot@lists.denx.de>, USB list <linux-usb@vger.kernel.org> Subject: imx: mx25: Remove SION bit in all pin-mux Date: Wed, 24 Jan 2018 17:03:38 +0100 [thread overview] Message-ID: <72f8d88e-5f6d-1412-e790-c53b35e8b100@wsystem.com> (raw) On 24/01/2018 at 16:43, Michael Nazzareno Trimarchi wrote: > On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau <benoit@wsystem.com> wrote: >> On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: >>> On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: >>>> On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam <festevam@gmail.com> wrote: >>>>> On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi >>>>> <michael@amarulasolutions.com> wrote: >>>>>> SION bit should be used in the situation that we need >>>>>> to read back the value of a pin and should be set by >>>>>> default. >>> >>> You remove this bit because it should be set by default? This sentence is >>> confusing. > > English is wrong ;) > > SION bit as a specific purpose to read back value that is set in > output. You don't need > and it's not set in any freescale board. If you need to set you need > to add to your peripheral. Unless there is a NEW_PAD_CTRL()-like mechanism for SION, all these definitions should be kept in iomux-mx25.h in order not to redefine the register offsets everywhere. AFAIK, all the Freescale boards use the definitions from iomux-mx25.h too. > The only case you need maybe is the data[0] of sdcard. And eSDHC CMD, and I²C probably too. Yet, you are also removing SION in these cases. I have 3 i.M25-based boards working fine with SION. ;) Can you explain the precise issue that you are trying to fix (which pin)? Best regards, Benoît --- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Benoît Thébaudeau" <benoit@wsystem.com> To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux Date: Wed, 24 Jan 2018 17:03:38 +0100 [thread overview] Message-ID: <72f8d88e-5f6d-1412-e790-c53b35e8b100@wsystem.com> (raw) In-Reply-To: <CAOf5uwmK9v92HrdPHmnJBvk+tjYkihTmUnUv_1ppWpR7eB_5xw@mail.gmail.com> On 24/01/2018 at 16:43, Michael Nazzareno Trimarchi wrote: > On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau <benoit@wsystem.com> wrote: >> On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: >>> On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: >>>> On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam <festevam@gmail.com> wrote: >>>>> On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi >>>>> <michael@amarulasolutions.com> wrote: >>>>>> SION bit should be used in the situation that we need >>>>>> to read back the value of a pin and should be set by >>>>>> default. >>> >>> You remove this bit because it should be set by default? This sentence is >>> confusing. > > English is wrong ;) > > SION bit as a specific purpose to read back value that is set in > output. You don't need > and it's not set in any freescale board. If you need to set you need > to add to your peripheral. Unless there is a NEW_PAD_CTRL()-like mechanism for SION, all these definitions should be kept in iomux-mx25.h in order not to redefine the register offsets everywhere. AFAIK, all the Freescale boards use the definitions from iomux-mx25.h too. > The only case you need maybe is the data[0] of sdcard. And eSDHC CMD, and I²C probably too. Yet, you are also removing SION in these cases. I have 3 i.M25-based boards working fine with SION. ;) Can you explain the precise issue that you are trying to fix (which pin)? Best regards, Benoît
next reply other threads:[~2018-01-24 16:03 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-24 16:03 Benoît Thébaudeau [this message] 2018-01-24 16:03 ` [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux Benoît Thébaudeau -- strict thread matches above, loose matches on Subject: below -- 2018-01-24 16:37 Benoît Thébaudeau 2018-01-24 16:37 ` [U-Boot] [PATCH] " Benoît Thébaudeau 2018-01-24 16:17 Michael Trimarchi 2018-01-24 16:17 ` [U-Boot] [PATCH] " Michael Nazzareno Trimarchi 2018-01-24 15:43 Michael Trimarchi 2018-01-24 15:43 ` [U-Boot] [PATCH] " Michael Nazzareno Trimarchi 2018-01-24 15:39 Benoît Thébaudeau 2018-01-24 15:39 ` [U-Boot] [PATCH] " Benoît Thébaudeau 2018-01-24 15:34 Benoît Thébaudeau 2018-01-24 15:34 ` [U-Boot] [PATCH] " Benoît Thébaudeau 2018-01-24 14:56 Michael Trimarchi 2018-01-24 14:56 ` [U-Boot] [PATCH] " Michael Trimarchi 2018-01-24 15:14 ` Fabio Estevam 2018-01-24 15:14 ` [U-Boot] [PATCH] " Fabio Estevam 2018-01-24 15:26 ` Michael Trimarchi 2018-01-24 15:26 ` [U-Boot] [PATCH] " Michael Nazzareno Trimarchi 2018-01-24 16:31 ` Michael Trimarchi 2018-01-24 16:31 ` [U-Boot] [PATCH] " Michael Nazzareno Trimarchi 2018-01-24 16:38 ` Fabio Estevam 2018-01-24 16:46 ` Michael Nazzareno Trimarchi 2018-01-24 17:05 ` Benoît Thébaudeau 2018-01-24 17:12 ` Michael Nazzareno Trimarchi 2018-01-24 17:19 ` Benoît Thébaudeau 2018-01-24 17:21 ` Fabio Estevam 2018-01-24 17:29 ` Benoît Thébaudeau 2018-01-24 17:33 ` Michael Nazzareno Trimarchi 2018-01-24 17:36 ` Fabio Estevam 2018-01-24 17:46 ` Michael Nazzareno Trimarchi 2018-01-24 23:07 ` Fabio Estevam 2018-01-25 5:47 ` Michael Nazzareno Trimarchi 2018-01-25 10:02 ` Benoît Thébaudeau 2018-01-25 10:17 ` Michael Nazzareno Trimarchi 2018-01-25 10:36 ` Benoît Thébaudeau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=72f8d88e-5f6d-1412-e790-c53b35e8b100@wsystem.com \ --to=benoit@wsystem.com \ --cc=fabio.estevam@nxp.com \ --cc=festevam@gmail.com \ --cc=linux-usb@vger.kernel.org \ --cc=michael@amarulasolutions.com \ --cc=peter.chen@nxp.com \ --cc=u-boot@lists.denx.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.