From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Sameer Pujar <spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
perex-/Fr2/VpizcU@public.gmane.org,
tiwai-IBi9RG/b67k@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver
Date: Fri, 24 Jan 2020 04:28:26 +0300 [thread overview]
Message-ID: <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> (raw)
In-Reply-To: <1579530198-13431-8-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
20.01.2020 17:23, Sameer Pujar пишет:
[snip]
> +static bool tegra_admaif_wr_reg(struct device *dev, unsigned int reg)
> +{
> + struct tegra_admaif *admaif = dev_get_drvdata(dev);
> + unsigned int ch_stride = TEGRA_ADMAIF_CHANNEL_REG_STRIDE;
> + unsigned int num_ch = admaif->soc_data->num_ch;
> + unsigned int rx_base = admaif->soc_data->rx_base;
> + unsigned int tx_base = admaif->soc_data->tx_base;
> + unsigned int global_base = admaif->soc_data->global_base;
> + unsigned int reg_max = admaif->soc_data->regmap_conf->max_register;
> + unsigned int rx_max = rx_base + (num_ch * ch_stride);
> + unsigned int tx_max = tx_base + (num_ch * ch_stride);
> +
> + if ((reg >= rx_base) && (reg < rx_max)) {
The braces are not needed around the comparisons because they precede
the AND. Same for all other similar occurrences in the code.
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Sameer Pujar <spujar@nvidia.com>,
perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
atalambedu@nvidia.com, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com,
sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com,
linux-tegra@vger.kernel.org, rlokhande@nvidia.com,
mkumard@nvidia.com, dramesh@nvidia.com
Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver
Date: Fri, 24 Jan 2020 04:28:26 +0300 [thread overview]
Message-ID: <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> (raw)
In-Reply-To: <1579530198-13431-8-git-send-email-spujar@nvidia.com>
20.01.2020 17:23, Sameer Pujar пишет:
[snip]
> +static bool tegra_admaif_wr_reg(struct device *dev, unsigned int reg)
> +{
> + struct tegra_admaif *admaif = dev_get_drvdata(dev);
> + unsigned int ch_stride = TEGRA_ADMAIF_CHANNEL_REG_STRIDE;
> + unsigned int num_ch = admaif->soc_data->num_ch;
> + unsigned int rx_base = admaif->soc_data->rx_base;
> + unsigned int tx_base = admaif->soc_data->tx_base;
> + unsigned int global_base = admaif->soc_data->global_base;
> + unsigned int reg_max = admaif->soc_data->regmap_conf->max_register;
> + unsigned int rx_max = rx_base + (num_ch * ch_stride);
> + unsigned int tx_max = tx_base + (num_ch * ch_stride);
> +
> + if ((reg >= rx_base) && (reg < rx_max)) {
The braces are not needed around the comparisons because they precede
the AND. Same for all other similar occurrences in the code.
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Sameer Pujar <spujar@nvidia.com>,
perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
jonathanh@nvidia.com, viswanathl@nvidia.com,
linux-tegra@vger.kernel.org, broonie@kernel.org,
atalambedu@nvidia.com, sharadg@nvidia.com,
thierry.reding@gmail.com, rlokhande@nvidia.com,
mkumard@nvidia.com, dramesh@nvidia.com
Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver
Date: Fri, 24 Jan 2020 04:28:26 +0300 [thread overview]
Message-ID: <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> (raw)
In-Reply-To: <1579530198-13431-8-git-send-email-spujar@nvidia.com>
20.01.2020 17:23, Sameer Pujar пишет:
[snip]
> +static bool tegra_admaif_wr_reg(struct device *dev, unsigned int reg)
> +{
> + struct tegra_admaif *admaif = dev_get_drvdata(dev);
> + unsigned int ch_stride = TEGRA_ADMAIF_CHANNEL_REG_STRIDE;
> + unsigned int num_ch = admaif->soc_data->num_ch;
> + unsigned int rx_base = admaif->soc_data->rx_base;
> + unsigned int tx_base = admaif->soc_data->tx_base;
> + unsigned int global_base = admaif->soc_data->global_base;
> + unsigned int reg_max = admaif->soc_data->regmap_conf->max_register;
> + unsigned int rx_max = rx_base + (num_ch * ch_stride);
> + unsigned int tx_max = tx_base + (num_ch * ch_stride);
> +
> + if ((reg >= rx_base) && (reg < rx_max)) {
The braces are not needed around the comparisons because they precede
the AND. Same for all other similar occurrences in the code.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-24 1:28 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 14:23 [PATCH 0/9] add ASoC components for AHUB Sameer Pujar
2020-01-20 14:23 ` [alsa-devel] " Sameer Pujar
2020-01-20 14:23 ` Sameer Pujar
2020-01-20 14:23 ` [PATCH 5/9] ASoC: tegra: add Tegra210 based AHUB driver Sameer Pujar
2020-01-20 14:23 ` [alsa-devel] " Sameer Pujar
2020-01-20 14:23 ` Sameer Pujar
[not found] ` <1579530198-13431-6-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-24 1:18 ` [alsa-devel] " Dmitry Osipenko
2020-01-24 1:18 ` Dmitry Osipenko
2020-01-24 1:18 ` Dmitry Osipenko
[not found] ` <5ed7482e-e874-9e11-c84e-7418e4b5162e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-24 3:39 ` Sameer Pujar
2020-01-24 3:39 ` Sameer Pujar
2020-01-24 3:39 ` Sameer Pujar
[not found] ` <d160fa01-27d0-6290-cb16-07d159d6fbb2-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-24 4:28 ` Dmitry Osipenko
2020-01-24 4:28 ` Dmitry Osipenko
2020-01-24 4:28 ` Dmitry Osipenko
2020-01-27 9:45 ` Jon Hunter
2020-01-27 9:45 ` Jon Hunter
2020-01-27 9:45 ` Jon Hunter
[not found] ` <1579530198-13431-1-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-20 14:23 ` [PATCH 1/9] dt-bindings: sound: tegra: add DT binding for AHUB Sameer Pujar
2020-01-20 14:23 ` [alsa-devel] " Sameer Pujar
2020-01-20 14:23 ` Sameer Pujar
2020-01-20 14:23 ` [PATCH 2/9] ASoC: tegra: add support for CIF programming Sameer Pujar
2020-01-20 14:23 ` [alsa-devel] " Sameer Pujar
2020-01-20 14:23 ` Sameer Pujar
[not found] ` <1579530198-13431-3-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-20 15:58 ` [alsa-devel] " Dmitry Osipenko
2020-01-20 15:58 ` Dmitry Osipenko
2020-01-20 15:58 ` Dmitry Osipenko
[not found] ` <d01ed171-d949-19b2-3390-ee30eada2779-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-21 4:41 ` Sameer Pujar
2020-01-21 4:41 ` Sameer Pujar
2020-01-21 4:41 ` Sameer Pujar
[not found] ` <a8409b81-7c6b-37a9-81fd-772eb2eca185-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-21 16:04 ` Dmitry Osipenko
2020-01-21 16:04 ` Dmitry Osipenko
2020-01-21 16:04 ` Dmitry Osipenko
[not found] ` <229def08-6bd4-30d7-056b-92329e48c699-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-27 5:11 ` Sameer Pujar
2020-01-27 5:11 ` Sameer Pujar
2020-01-27 5:11 ` Sameer Pujar
[not found] ` <34917b2d-064f-44a9-4548-ae857e8ea29b-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-28 22:40 ` Dmitry Osipenko
2020-01-28 22:40 ` Dmitry Osipenko
2020-01-28 22:40 ` Dmitry Osipenko
2020-01-20 14:23 ` [PATCH 3/9] ASoC: tegra: add Tegra210 based DMIC driver Sameer Pujar
2020-01-20 14:23 ` [alsa-devel] " Sameer Pujar
2020-01-20 14:23 ` Sameer Pujar
2020-01-20 14:23 ` [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver Sameer Pujar
2020-01-20 14:23 ` [alsa-devel] " Sameer Pujar
2020-01-20 14:23 ` Sameer Pujar
2020-01-21 5:15 ` [alsa-devel] " Dmitry Osipenko
2020-01-21 5:15 ` Dmitry Osipenko
[not found] ` <a440d105-8db9-ecf1-3718-e58804ce14b8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-21 14:21 ` Sameer Pujar
2020-01-21 14:21 ` Sameer Pujar
2020-01-21 14:21 ` Sameer Pujar
[not found] ` <0c571858-d72c-97c2-2d6a-ead6fdde06eb-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-21 16:03 ` Dmitry Osipenko
2020-01-21 16:03 ` Dmitry Osipenko
2020-01-21 16:03 ` Dmitry Osipenko
[not found] ` <444731da-c4cd-8578-a732-c803eef31ef0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-22 4:32 ` Sameer Pujar
2020-01-22 4:32 ` Sameer Pujar
2020-01-22 4:32 ` Sameer Pujar
[not found] ` <bdc749bc-b62c-a041-c17c-33fd49fe8e2e-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-22 6:23 ` Dmitry Osipenko
2020-01-22 6:23 ` Dmitry Osipenko
2020-01-22 6:23 ` Dmitry Osipenko
[not found] ` <598fe377-5b95-d30a-eb64-89a645166d42-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-22 7:16 ` Sameer Pujar
2020-01-22 7:16 ` Sameer Pujar
2020-01-22 7:16 ` Sameer Pujar
[not found] ` <3f51939d-cf4b-f69b-728a-7eb99bbae458-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-22 11:52 ` Jon Hunter
2020-01-22 11:52 ` Jon Hunter
2020-01-22 11:52 ` Jon Hunter
[not found] ` <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-22 16:27 ` Dmitry Osipenko
2020-01-22 16:27 ` Dmitry Osipenko
2020-01-22 16:27 ` Dmitry Osipenko
2020-01-23 9:22 ` Sameer Pujar
2020-01-23 9:22 ` Sameer Pujar
2020-01-23 9:22 ` Sameer Pujar
2020-01-23 15:16 ` Dmitry Osipenko
2020-01-23 15:16 ` Dmitry Osipenko
[not found] ` <b5c581b9-17af-d004-33fb-2cc782ab820a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-24 9:07 ` Jon Hunter
2020-01-24 9:07 ` Jon Hunter
2020-01-24 9:07 ` Jon Hunter
2020-01-24 9:51 ` Jon Hunter
2020-01-24 9:51 ` Jon Hunter
2020-01-24 9:51 ` Jon Hunter
[not found] ` <264d3354-8a2e-ee12-44ae-aff69213d551-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-24 14:04 ` Dmitry Osipenko
2020-01-24 14:04 ` Dmitry Osipenko
2020-01-24 14:04 ` Dmitry Osipenko
[not found] ` <075e476a-36bb-5fee-15bc-76af4474a797-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-27 5:22 ` Sameer Pujar
2020-01-27 5:22 ` Sameer Pujar
2020-01-27 5:22 ` Sameer Pujar
[not found] ` <c6022a93-b79a-c691-1d75-d007d0b64ead-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-29 3:41 ` Dmitry Osipenko
2020-01-29 3:41 ` Dmitry Osipenko
2020-01-29 3:41 ` Dmitry Osipenko
[not found] ` <3b42c858-733b-0d17-f457-8043d97f5058-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-14 14:05 ` Jon Hunter
2020-02-14 14:05 ` Jon Hunter
2020-02-14 14:05 ` Jon Hunter
[not found] ` <62b8ffbc-aa32-ae44-6cb4-b176b8ba9b0e-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-18 1:00 ` Dmitry Osipenko
2020-02-18 1:00 ` Dmitry Osipenko
2020-02-18 1:00 ` Dmitry Osipenko
[not found] ` <847739f8-6f54-cf64-54b8-94707944850b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-19 16:10 ` Sameer Pujar
2020-02-19 16:10 ` Sameer Pujar
2020-02-19 16:10 ` Sameer Pujar
2020-01-22 16:26 ` Dmitry Osipenko
2020-01-22 16:26 ` Dmitry Osipenko
2020-01-22 16:26 ` Dmitry Osipenko
2020-01-20 14:23 ` [PATCH 6/9] ASoC: tegra: add Tegra186 based DSPK driver Sameer Pujar
2020-01-20 14:23 ` [alsa-devel] " Sameer Pujar
2020-01-20 14:23 ` Sameer Pujar
2020-01-20 14:23 ` [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver Sameer Pujar
2020-01-20 14:23 ` [alsa-devel] " Sameer Pujar
2020-01-20 14:23 ` Sameer Pujar
[not found] ` <1579530198-13431-8-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-01-24 1:28 ` Dmitry Osipenko [this message]
2020-01-24 1:28 ` [alsa-devel] " Dmitry Osipenko
2020-01-24 1:28 ` Dmitry Osipenko
[not found] ` <743d6d7d-f29c-191a-853b-414250ca38df-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-24 3:27 ` Sameer Pujar
2020-01-24 3:27 ` Sameer Pujar
2020-01-24 3:27 ` Sameer Pujar
2020-01-24 4:25 ` Dmitry Osipenko
2020-01-24 4:25 ` Dmitry Osipenko
[not found] ` <8a3259b7-6875-236a-b16c-cd8e023cc8b2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-01-27 5:08 ` Sameer Pujar
2020-01-27 5:08 ` Sameer Pujar
2020-01-27 5:08 ` Sameer Pujar
2020-01-20 14:23 ` [PATCH 9/9] arm64: tegra: enable AHUB modules for few Tegra chips Sameer Pujar
2020-01-20 14:23 ` [alsa-devel] " Sameer Pujar
2020-01-20 14:23 ` Sameer Pujar
2020-01-28 10:49 ` [PATCH 0/9] add ASoC components for AHUB Sameer Pujar
2020-01-28 10:49 ` [alsa-devel] " Sameer Pujar
2020-01-28 10:49 ` Sameer Pujar
2020-01-20 14:23 ` [PATCH 8/9] arm64: tegra: add AHUB components for few Tegra chips Sameer Pujar
2020-01-20 14:23 ` [alsa-devel] " Sameer Pujar
2020-01-20 14:23 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=743d6d7d-f29c-191a-853b-414250ca38df@gmail.com \
--to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
--cc=viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.