All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Vinod Koul <vinod.koul@intel.com>, Moritz Fischer <mdf@kernel.org>
Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	dan.j.williams@intel.com
Subject: [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
Date: Fri, 27 Apr 2018 08:53:39 +0200	[thread overview]
Message-ID: <748ffc14-de12-c11e-eb12-65c599fe5f4e@metafoo.de> (raw)

On 04/27/2018 07:11 AM, Vinod Koul wrote:
> On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
>> Request IRQ with IRQF_SHARED flag. This works since the interrupt
>> handler already checks if there is an actual IRQ pending and returns
>> IRQ_NONE otherwise.
> 
> hmmm what are we trying to fix here? Is your device on a shared line or not?

IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
the driver can handle it if the IRQ is on a shared line. Since the driver
can handle it setting the flag is a good idea since this enables usecases
where the line is shared.

> 
>>
>> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>> ---
>> Changes from v1:
>> - Added Lars' Acked-by
>> - Dropped patch [1/2] and changed accordingly
>> ---
>>  drivers/dma/dma-axi-dmac.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
>> index 2419fe524daa..15b2453d2647 100644
>> --- a/drivers/dma/dma-axi-dmac.c
>> +++ b/drivers/dma/dma-axi-dmac.c
>> @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
>>  	if (ret)
>>  		goto err_unregister_device;
>>  
>> -	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
>> +	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
>>  		dev_name(&pdev->dev), dmac);
>>  	if (ret)
>>  		goto err_unregister_of;
>> -- 
>> 2.17.0
>>
>
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID
From: Lars-Peter Clausen <lars@metafoo.de>
To: Vinod Koul <vinod.koul@intel.com>, Moritz Fischer <mdf@kernel.org>
Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	dan.j.williams@intel.com
Subject: Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
Date: Fri, 27 Apr 2018 08:53:39 +0200	[thread overview]
Message-ID: <748ffc14-de12-c11e-eb12-65c599fe5f4e@metafoo.de> (raw)
In-Reply-To: <20180427051115.GX6014@localhost>

On 04/27/2018 07:11 AM, Vinod Koul wrote:
> On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
>> Request IRQ with IRQF_SHARED flag. This works since the interrupt
>> handler already checks if there is an actual IRQ pending and returns
>> IRQ_NONE otherwise.
> 
> hmmm what are we trying to fix here? Is your device on a shared line or not?

IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
the driver can handle it if the IRQ is on a shared line. Since the driver
can handle it setting the flag is a good idea since this enables usecases
where the line is shared.

> 
>>
>> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>> ---
>> Changes from v1:
>> - Added Lars' Acked-by
>> - Dropped patch [1/2] and changed accordingly
>> ---
>>  drivers/dma/dma-axi-dmac.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
>> index 2419fe524daa..15b2453d2647 100644
>> --- a/drivers/dma/dma-axi-dmac.c
>> +++ b/drivers/dma/dma-axi-dmac.c
>> @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
>>  	if (ret)
>>  		goto err_unregister_device;
>>  
>> -	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
>> +	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
>>  		dev_name(&pdev->dev), dmac);
>>  	if (ret)
>>  		goto err_unregister_of;
>> -- 
>> 2.17.0
>>
> 

             reply	other threads:[~2018-04-27  6:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27  6:53 Lars-Peter Clausen [this message]
2018-04-27  6:53 ` [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Lars-Peter Clausen
  -- strict thread matches above, loose matches on Subject: below --
2018-04-28 19:31 [v2] " mdf
2018-04-28 19:31 ` [PATCH v2] " Moritz Fischer
2018-04-28  5:10 [v2] " Vinod Koul
2018-04-28  5:10 ` [PATCH v2] " Vinod Koul
2018-04-27 15:18 [v2] " Lars-Peter Clausen
2018-04-27 15:18 ` [PATCH v2] " Lars-Peter Clausen
2018-04-27 15:15 [v2] " Moritz Fischer
2018-04-27 15:15 ` [PATCH v2] " Moritz Fischer
2018-04-27  7:08 [v2] " Vinod Koul
2018-04-27  7:08 ` [PATCH v2] " Vinod Koul
2018-04-27  5:11 [v2] " Vinod Koul
2018-04-27  5:11 ` [PATCH v2] " Vinod Koul
2018-04-26 17:40 [v2] " mdf
2018-04-26 17:40 ` [PATCH v2] " Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=748ffc14-de12-c11e-eb12-65c599fe5f4e@metafoo.de \
    --to=lars@metafoo.de \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.