All of lore.kernel.org
 help / color / mirror / Atom feed
* R: Re: PCI device not working
@ 2012-10-04 12:24 Davide Viti
  2012-10-04 13:14 ` Kumar Gala
  0 siblings, 1 reply; 17+ messages in thread
From: Davide Viti @ 2012-10-04 12:24 UTC (permalink / raw)
  To: galak; +Cc: linuxppc-dev

Hi,
it turns out that if define CONFIG_PCI_NOSCAN in u-boot (as per [1]), the=
=20
devide behind the second controller is detected by the  Linux kernel.

Would=20
you suggest any particular patch I should apply to fix this (I'm using kern=
el=20
2.6.34)

thanx alot in advance
Davide

[1] http://permalink.gmane.org/gmane.
linux.ports.ppc.embedded/20140

>----Messaggio originale----
>Da:=20
zinosat@tiscali.it
>Data: 28/09/2012 16.48
>A: <galak@kernel.crashing.org>
>Cc:=20
<linuxppc-dev@lists.ozlabs.org>
>Ogg: R: Re: PCI device not working
>
>Hi=20
Kumar,
>
>>
>>It was, can you figure out in u-boot what exact config read on=20

>the bus would return the correct thing.
>>
>>The fact that when we probe the=20

>device at 0001:03 we should get back something like cfg_data=3D0xabba1b65
>>
>

>here=20
>follow some details about what is going on inside u-boot; verbosity=20
increases=20
>from [1] to [3]
>
> [1] PCI printouts when the board come up
> [2]=20
output of "pci=20
>[0-3] long" u-boot command
> [3] same as [1] but with debug=20
print inside=20
>indirect_read_config_##size() [drivers/pci/pci_indirect.c]
>
>if=20
you were curious=20
>about our u-boot board settings, please refer to:
>http:
//www.mail-archive.
>com/linuxppc-dev@lists.ozlabs.org/msg62007.html
>
>thanx=20
alot,
>Davide
>
>
>
>*************
>*    [1]    *
>*************
>    PCIE1=20
used as Root Complex (base=20
>addr ffe09000)
>               Scanning PCI bus 01

>        01  00  1b65  abba =20
>0280  00
>        cfg_addr:ffe09000  cfg_data:
ffe09004  indirect_type:0
>   =20
>PCIE1 on bus 00 - 01
>
>
>    PCIE2 used as=20
Root Complex (base addr ffe0a000)
>
>               Scanning PCI bus 03

>        03  00  1b65  abba  0280  00
>       =20
>cfg_addr:ffe0a000  cfg_data:
ffe0a004  indirect_type:0
>    PCIE2 on bus 02 - 03
>
>
>*************
>*   =20
[2]    *
>*************
>
>=3D> pci 0 long
>Scanning PCI devices=20
>on bus 0
>

>Found PCI device 00.00.00:
>  vendor ID =3D                   0x1957
> =20
>device=20
ID =3D                   0x0100
>  command register =3D            0x0006
> =20

>status register =3D             0x0010
>  revision ID =3D                 0x11
> =20

>class code =3D                  0x0b (Processor)
>  sub class code=20
=3D             =20
>0x20
>  programming interface =3D       0x00
>  cache line=20
=3D                  0x08
>
>  latency time =3D                0x00
>  header type=20
=3D                 0x01
> =20
>BIST =3D                        0x00
>  base address=20
0 =3D              0xfff00000
> =20
>base address 1 =3D              0x00000000
> =20
primary bus number =3D          0x00
> =20
>secondary bus number =3D        0x01
> =20
subordinate bus number =3D      0x01
> =20
>secondary latency timer =3D     0x00
> =20
IO base =3D                     0x00
>  IO=20
>limit =3D                    0x00
> =20
secondary status =3D            0x0000
>  memory=20
>base =3D                 0xa000

>  memory limit =3D                0xa000
>  prefetch=20
>memory base =3D       =20
0x1001
>  prefetch memory limit =3D       0x0001
>  prefetch=20
>memory base upper=20
=3D  0x00000000
>  prefetch memory limit upper =3D 0x00000000
>  IO=20
>base upper 16=20
bits =3D       0x0000
>  IO limit upper 16 bits =3D      0x0000
> =20
>expansion ROM=20
base address =3D  0x00000000
>  interrupt line =3D              0x00
> =20
>interrupt=20
pin =3D               0x00
>  bridge control =3D              0x0000
>
>=3D>=20
>pci 1=20
long
>Scanning PCI devices on bus 1
>
>Found PCI device 01.00.00:kk
>  vendor=20

>ID =3D                   0x1b65
>  device ID =3D                   0xabba
> =20
command=20
>register =3D            0x0006
>  status register =3D             0x0010

>  revision=20
>ID =3D                 0x01
>  class code =3D                  0x02=20
(Network=20
>controller)
>  sub class code =3D              0x80
>  programming=20
interface=20
>=3D       0x00
>  cache line =3D                  0x08
>  latency time=20

>=3D                0x00
>  header type =3D                 0x00
>  BIST=20

>=3D                        0x00
>  base address 0 =3D              0xa0000000
> =20
base=20
>address 1 =3D              0xa0010000
>  base address 2 =3D             =20
0x00000000
>
>  base address 3 =3D              0x00000000
>  base address 4=20
=3D             =20
>0x00000000
>  base address 5 =3D              0x00000000
> =20
cardBus CIS pointer=20
>=3D         0x00000000
>  sub system vendor ID =3D       =20
0x0000
>  sub system ID=20
>=3D               0x0000
>  expansion ROM base address=20
=3D  0x00000000
>  interrupt=20
>line =3D              0x00
>  interrupt pin=20
=3D               0x01
>  min Grant=20
>=3D                   0x00
>  max Latency=20
=3D                 0x00
>
>=3D> pci 2 long
>
>Scanning PCI devices on bus 2
>

>Found PCI device 02.00.00:
>  vendor ID=20
>=3D                   0x1957
>  device=20
ID =3D                   0x0100
>  command=20
>register =3D            0x0006
> =20
status register =3D             0x0010
>  revision=20
>ID =3D                 0x11
> =20
class code =3D                  0x0b (Processor)
> =20
>sub class code=20
=3D              0x20
>  programming interface =3D       0x00
>  cache=20
>line=20
=3D                  0x08
>  latency time =3D                0x00
>  header type=20

>=3D                 0x01
>  BIST =3D                        0x00
>  base address=20
0=20
>=3D              0xfff00000
>  base address 1 =3D              0x00000000
> =20
primary=20
>bus number =3D          0x00
>  secondary bus number =3D        0x01
> =20
subordinate=20
>bus number =3D      0x01
>  secondary latency timer =3D     0x00
> =20
IO base=20
>=3D                     0x00
>  IO limit =3D                    0x00
> =20
secondary=20
>status =3D            0x0000
>  memory base =3D                 0xb000

>  memory=20
>limit =3D                0xb000
>  prefetch memory base =3D       =20
0x1001
>  prefetch=20
>memory limit =3D       0x0001
>  prefetch memory base upper=20
=3D  0x00000000
> =20
>prefetch memory limit upper =3D 0x00000000
>  IO base upper 16=20
bits =3D       0x0000
>
>  IO limit upper 16 bits =3D      0x0000
>  expansion ROM=20
base address =3D =20
>0x00000000
>  interrupt line =3D              0x00
>  interrupt=20
pin =3D              =20
>0x00
>  bridge control =3D              0x0000
>
>=3D> pci 3=20
long
>Scanning PCI devices=20
>on bus 3
>
>Found PCI device 03.00.00:
>  vendor=20
ID =3D                   0x1b65
> =20
>device ID =3D                   0xabba
> =20
command register =3D            0x0006
> =20
>status register =3D             0x0010

>  revision ID =3D                 0x01
> =20
>class code =3D                  0x02=20
(Network controller)
>  sub class code=20
>=3D              0x80
>  programming=20
interface =3D       0x00
>  cache line=20
>=3D                  0x08
>  latency time=20
=3D                0x00
>  header type=20
>=3D                 0x00
>  BIST=20
=3D                        0x00
>  base address 0=20
>=3D              0xb0000000
> =20
base address 1 =3D              0xb0010000
>  base=20
>address 2 =3D             =20
0x00000000
>  base address 3 =3D              0x00000000
>
>  base address 4=20
=3D              0x00000000
>  base address 5 =3D             =20
>0x00000000
> =20
cardBus CIS pointer =3D         0x00000000
>  sub system vendor ID=20
>=3D       =20
0x0000
>  sub system ID =3D               0x0000
>  expansion ROM base=20
>address=20
=3D  0x00000000
>  interrupt line =3D              0x00
>  interrupt pin=20

>=3D               0x01
>  min Grant =3D                   0x00
>  max Latency=20

>=3D                 0x00
>
>
>*************
>*    [3]    *
>*************
>
>   =20
PCIE1=20
>used as Root Complex (base addr ffe09000)
>b=3D0 d=3D0 f=3D0 (fbusno=3D0=20
itype=3D0=20
>cfg_adr=3Dffe09000 cfg_data=3Dffe09004) ofs=3D10 mask=3D0
>...

>               Scanning=20
>PCI bus 01
>b=3D1 d=3D0 f=3D0 (fbusno=3D0 itype=3D0=20
cfg_adr=3Dffe09000 cfg_data=3Dffe09004)=20
>ofs=3De mask=3D3
>...
>b=3D1 d=3D0 f=3D0 (fbusno=3D0=20
itype=3D0 cfg_adr=3Dffe09000=20
>cfg_data=3Dffe09004) ofs=3D3c mask=3D3
>        01  00 =20
1b65  abba  0280  00
>b=3D1 d=3D1=20
>f=3D0 (fbusno=3D0 itype=3D0 cfg_adr=3Dffe09000=20
cfg_data=3Dffe09004) ofs=3De mask=3D3
>b=3D1 d=3D1=20
>f=3D0 (fbusno=3D0 itype=3D0=20
cfg_adr=3Dffe09000 cfg_data=3Dffe09004) ofs=3D0 mask=3D2
>...
>b=3D0=20
>d=3D0 f=3D0 (fbusno=3D0=20
itype=3D0 cfg_adr=3Dffe09000 cfg_data=3Dffe09004) ofs=3D9 mask=3D3
>   =20
>PCIE1 on bus 00=20
- 01
>
>    PCIE2 used as Root Complex (base addr ffe0a000)
>b=3D0=20
>d=3D0 f=3D0=20
(fbusno=3D2 itype=3D0 cfg_adr=3Dffe0a000 cfg_data=3Dffe0a004) ofs=3D10 mask=
=3D0
>b=3D0=20
>d=3D0=20
f=3D0 (fbusno=3D2 itype=3D0 cfg_adr=3Dffe0a000 cfg_data=3Dffe0a004) ofs=3D1=
0 mask=3D0
>...
>

>b=3D0 d=3D0 f=3D0 (fbusno=3D2 itype=3D0 cfg_adr=3Dffe0a000 cfg_data=3Dffe0=
a004) ofs=3D9 mask=3D3

>
>               Scanning PCI bus 03
>b=3D1 d=3D0 f=3D0 (fbusno=3D2 itype=3D0=20

>cfg_adr=3Dffe0a000 cfg_data=3Dffe0a004) ofs=3De mask=3D3
>b=3D1 d=3D0 f=3D0 (fbusno=3D2=20
itype=3D0=20
>cfg_adr=3Dffe0a000 cfg_data=3Dffe0a004) ofs=3D0 mask=3D2
>...
>b=3D1 d=3D0 f=3D0=20
(fbusno=3D2=20
>itype=3D0 cfg_adr=3Dffe0a000 cfg_data=3Dffe0a004) ofs=3D3c mask=3D3
>       =20
03  00  1b65 =20
>abba  0280  00
>        cfg_addr:ffe0a000  cfg_data:ffe0a004 =20
indirect_type:0
>
>b=3D1 d=3D1 f=3D0 (fbusno=3D2 itype=3D0 cfg_adr=3Dffe0a000=20
cfg_data=3Dffe0a004) ofs=3De mask=3D3
>
>...
>b=3D0 d=3D0 f=3D0 (fbusno=3D2 itype=3D0=20
cfg_adr=3Dffe0a000 cfg_data=3Dffe0a004) ofs=3D9=20
>mask=3D3
>    PCIE2 on bus 02 - 03
>

>
>
>Invita i tuoi amici e Tiscali ti premia! Il consiglio di un amico vale pi=
=C3=B9=20
di uno spot in TV. Per ogni nuovo abbonato 30 =E2=82=AC di premio per te e =
per lui! Un=20
amico al mese e parli e navighi sempre gratis: http://freelosophy.tiscali.i=
t/



Invita i tuoi amici e Tiscali ti premia! Il consiglio di un amico vale pi=
=C3=B9 di uno spot in TV. Per ogni nuovo abbonato 30 =E2=82=AC di premio pe=
r te e per lui! Un amico al mese e parli e navighi sempre gratis: http://fr=
eelosophy.tiscali.it/

^ permalink raw reply	[flat|nested] 17+ messages in thread
* R: Re: PCI device not working
@ 2012-09-27 13:14 Davide Viti
  2012-09-27 16:06 ` Kumar Gala
  0 siblings, 1 reply; 17+ messages in thread
From: Davide Viti @ 2012-09-27 13:14 UTC (permalink / raw)
  To: galak; +Cc: linuxppc-dev

Hi Kumar,

>----Messaggio originale----
>Da: galak@kernel.crashing.org
>Data:=20
27/09/2012 14.27
>A: "Davide Viti"<zinosat@tiscali.it>
>Cc: <linuxppc-dev@lists.
ozlabs.org>
>Ogg: Re: PCI device not working
>
...
>Can you see what bus_no=20
actually gets set to in the case we scan 0001:03 ?
>
>If its set to 03, can you=20
try hack it to 1.

is this what you mean?

---=20
a/arch/powerpc/sysdev/indirect_pci.c
+++ b/arch/powerpc/sysdev/indirect_pci.c


        bus_no =3D (bus->number =3D=3D hose->first_busno) ?
                       =20
hose->self_busno : bus->number;

+       if (bus_no =3D=3D 3) {
+         printk
("*** force bus_no 3 -> 1 ***\n");
+         bus_no =3D 1;
+       }
+


I've=20
tested a kernel with the above patch and this is what is printed on the log=
:


pci_bus 0001:03: scanning bus
-> ind_r_config - [/pcie@ffe0a000] devfn=3D0x0=20
offset=3D0x0 len=3D0x4 hose->indirect_type=3D0x16 hose->first_busno=3D0x2 b=
us-
>number=3D0x3
*** force bus_no 3 -> 1 ***
 -> ind_r_config [/pcie@ffe0a000] -=20
(bus_no=3D0x1 reg=3D0x0 cfg_data=3D0xff7eb004 len=3D0x4 hose->cfg_addr=3D0x=
ff7eb000)=20
val=3D0xffffffff PCIBIOS_SUCCESSFUL

the entire log (132Kb) is available in [1]=20
and [2]

thanx for your help,
Davide

[1] http://pastebin.com/3mcbDzwY
[2] http:
//paste2.org/p/2274032



Invita i tuoi amici e Tiscali ti premia! Il consiglio di un amico vale pi=
=C3=B9 di uno spot in TV. Per ogni nuovo abbonato 30 =E2=82=AC di premio pe=
r te e per lui! Un amico al mese e parli e navighi sempre gratis: http://fr=
eelosophy.tiscali.it/

^ permalink raw reply	[flat|nested] 17+ messages in thread
* R: Re: PCI device not working
@ 2012-09-27 11:43 Davide Viti
  2012-09-27 12:27 ` Kumar Gala
  0 siblings, 1 reply; 17+ messages in thread
From: Davide Viti @ 2012-09-27 11:43 UTC (permalink / raw)
  To: galak; +Cc: linuxppc-dev

Hi,

>So its odd that scanning of the second bus didn't report any devices.  Do=
=20
you have code that implements ppc_md.pci_exclude_device ?

not that I'm aware=20
of

>You might also want to put some code in the indirect PCI ops (indirect.c)=
=20
to see what actual values you are getting from various indirect_read_config=
()=20
calls.

To make sure that  ppc_md.pci_exclude_device is not implemented, I've=20
put some printouts inside  indirect_read_config(): I print various paramete=
rs=20
when the function is called, and when it returns and note that:

 1.=20
indirect_read_config() is called 422 times:=20
     174 times for=20
[/pcie@ffe0a000] (controller where the device is not detected)
     248 times=20
for [/pcie@ffe09000]=20
 2. ppc_md.pci_exclude_device is always NULL
 3. the=20
function always returns with PCIBIOS_SUCCESSFUL
 4. the only call to =20
indirect_read_config() inside which  bus_no=3D0x3, returns with the followi=
ng=20
log:

pci_bus 0001:03: scanning bus
-> ind_r_config - [/pcie@ffe0a000]=20
devfn=3D0x0 len=3D0x4 hose->indirect_type=3D0x16 hose->first_busno=3D0x2 bu=
s-
>number=3D0x3
 -> ind_r_config [/pcie@ffe0a000] - (bus_no=3D0x3 reg=3D0x0=20
cfg_data=3D0xffffffff len=3D0xff7eb004) val=3D0x4 PCIBIOS_SUCCESSFUL =20

the entire=20
log is about 116Kb and is available in [1] or [2] (didn't feel like pasting=
 so=20
much data on the ML)
thanx alot,

Davide

[1] http://pastebin.com/JaPGmmfs
[2]=20
http://paste2.org/p/2273728


Invita i tuoi amici e Tiscali ti premia! Il consiglio di un amico vale pi=
=C3=B9 di uno spot in TV. Per ogni nuovo abbonato 30 =E2=82=AC di premio pe=
r te e per lui! Un amico al mese e parli e navighi sempre gratis: http://fr=
eelosophy.tiscali.it/

^ permalink raw reply	[flat|nested] 17+ messages in thread
* PCI device not working
@ 2012-09-21 11:33 Davide Viti
  2012-09-21 13:17 ` Kumar Gala
  0 siblings, 1 reply; 17+ messages in thread
From: Davide Viti @ 2012-09-21 11:33 UTC (permalink / raw)
  To: linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

Hi,
I'm working on a custom board based on P1020 with two (identical) PCI
devices attached;
The work is derived from another board with a single instance of that
device.
The system is based on u-boot-2009.11 and Linux 2.6.34.6

The "pci" command on u-boot, shows me both the PCI controllers and
the attached devices:

Scanning PCI devices on bus 0
BusDevFun  VendorId   DeviceId   Device Class       Sub-Class
_____________________________________________________________
00.00.00   0x1957     0x0100     Processor               0x20

Scanning PCI devices on bus 1
BusDevFun  VendorId   DeviceId   Device Class       Sub-Class
_____________________________________________________________
01.00.00   0x1b65     0xabba     Network controller      0x80

Scanning PCI devices on bus 2
BusDevFun  VendorId   DeviceId   Device Class       Sub-Class
_____________________________________________________________
02.00.00   0x1957     0x0100     Processor               0x20

Scanning PCI devices on bus 3
BusDevFun  VendorId   DeviceId   Device Class       Sub-Class
_____________________________________________________________
03.00.00   0x1b65     0xabba     Network controller      0x80

The kernel detects only the first instance of the device.

Didn't get very far while looking at dts file and kernel logs, so I'm
asking for some help on narrowing down the problem.

I'm wondering if I can assume that the problem is restricted to
kernel/dts and avoid concentrating on uboot.
I can provide any log (didn't want to post tons of details on the first
message)

Thanx in advance for your help,
regards

Davide

[-- Attachment #2: Type: text/html, Size: 2117 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2012-10-31  8:53 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-04 12:24 R: Re: PCI device not working Davide Viti
2012-10-04 13:14 ` Kumar Gala
     [not found]   ` <CAKpAL0m3YnsbbGxL+ejfyE4zfGE5LD9Qxb7oobHVaAZGE1_Jnw@mail.gmail.com>
2012-10-05  8:54     ` Fwd: " Davide Viti
2012-10-05 12:47       ` Kumar Gala
2012-10-25  8:21         ` Davide
2012-10-31  8:52         ` Davide
  -- strict thread matches above, loose matches on Subject: below --
2012-09-27 13:14 R: " Davide Viti
2012-09-27 16:06 ` Kumar Gala
2012-09-27 11:43 R: " Davide Viti
2012-09-27 12:27 ` Kumar Gala
2012-09-21 11:33 Davide Viti
2012-09-21 13:17 ` Kumar Gala
2012-09-21 14:06   ` Davide Viti
2012-09-24 13:25     ` Davide Viti
2012-09-24 13:27     ` Davide Viti
2012-09-24 20:59       ` Davide Viti
2012-09-26 13:44         ` Kumar Gala
2012-09-26 15:25           ` Davide Viti
2012-09-27  2:30             ` Kumar Gala

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.