From: James Tai <james.tai@realtek.com> To: "Andreas Färber" <afaerber@suse.de> Cc: "linux-realtek-soc@lists.infradead.org" <linux-realtek-soc@lists.infradead.org>, Mark Rutland <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH 5/7] ARM: dts: rtd1195: Introduce r-bus Date: Mon, 18 Nov 2019 06:53:39 +0000 [thread overview] Message-ID: <753c18eee3fb4e9ea25d42798542b3dd@realtek.com> (raw) In-Reply-To: <960a80b9-b1bf-3709-bbb7-fc2a3c3ae1da@suse.de> Hi Andreas, > > Fixed, also further above for the soc node. This now leaves a gap until > 0x18100000 - is that gap RAM or non-r-bus registers then? > > ranges = <0x18000000 0x18000000 0x00070000>, > <0x18100000 0x18100000 0x01000000>, > <0x40000000 0x40000000 0xc0000000>; > > Did you also review the other two ranges? The middle one was labeled NOR > flash somewhere - are start and size correct? The final one depends on the > maximum RAM size - does RTD1195 allow more than 1 GiB RAM? All > non-RAM regions should be covered here. > It is reserved for NOR flash. The start and size is correct. The rtd1195 can support to 2GiB RAM. > So another question, applicable to all SoCs: This reserved Boot ROM area at > the start of the address space, here of size 0xa800, is that copied into RAM, or > is that the actual ROM overlapping RAM? If the latter, we should exclude it > from /memory@0's reg (making it /memory@a800), and add it to soc's ranges > here for correctness. > Yes, we should exclude it from /memory@0's reg. > With the follow-up question: Is it correct that, given the size 0xa800, I have a > gap between /memreserve/s from 0xa800 to 0xc000, or should we reserve that > gap by extending the next /memreserve/ or inserting one? We should reserve memory address from 0x0000 to 0xa800 for the internal ROM. Regards, James
WARNING: multiple messages have this Message-ID (diff)
From: James Tai <james.tai@realtek.com> To: "Andreas Färber" <afaerber@suse.de> Cc: Mark Rutland <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-realtek-soc@lists.infradead.org" <linux-realtek-soc@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH 5/7] ARM: dts: rtd1195: Introduce r-bus Date: Mon, 18 Nov 2019 06:53:39 +0000 [thread overview] Message-ID: <753c18eee3fb4e9ea25d42798542b3dd@realtek.com> (raw) In-Reply-To: <960a80b9-b1bf-3709-bbb7-fc2a3c3ae1da@suse.de> Hi Andreas, > > Fixed, also further above for the soc node. This now leaves a gap until > 0x18100000 - is that gap RAM or non-r-bus registers then? > > ranges = <0x18000000 0x18000000 0x00070000>, > <0x18100000 0x18100000 0x01000000>, > <0x40000000 0x40000000 0xc0000000>; > > Did you also review the other two ranges? The middle one was labeled NOR > flash somewhere - are start and size correct? The final one depends on the > maximum RAM size - does RTD1195 allow more than 1 GiB RAM? All > non-RAM regions should be covered here. > It is reserved for NOR flash. The start and size is correct. The rtd1195 can support to 2GiB RAM. > So another question, applicable to all SoCs: This reserved Boot ROM area at > the start of the address space, here of size 0xa800, is that copied into RAM, or > is that the actual ROM overlapping RAM? If the latter, we should exclude it > from /memory@0's reg (making it /memory@a800), and add it to soc's ranges > here for correctness. > Yes, we should exclude it from /memory@0's reg. > With the follow-up question: Is it correct that, given the size 0xa800, I have a > gap between /memreserve/s from 0xa800 to 0xc000, or should we reserve that > gap by extending the next /memreserve/ or inserting one? We should reserve memory address from 0x0000 to 0xa800 for the internal ROM. Regards, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-18 6:54 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-11 3:04 [PATCH 0/7] arm64: dts: Initial RTD1395 and BPi-M4 support Andreas Färber 2019-11-11 3:04 ` Andreas Färber 2019-11-11 3:04 ` [PATCH 1/7] arm64: dts: realtek: rtd129x: Fix GIC CPU masks for RTD1293 Andreas Färber 2019-11-11 3:04 ` Andreas Färber 2019-11-11 3:04 ` [PATCH 2/7] arm64: dts: realtek: rtd129x: Use reserved-memory for RPC regions Andreas Färber 2019-11-11 3:04 ` Andreas Färber 2019-12-02 8:15 ` Andreas Färber 2019-12-02 8:15 ` Andreas Färber 2019-12-02 9:49 ` James Tai 2019-12-02 9:49 ` James Tai 2019-11-11 3:04 ` [PATCH 3/7] arm64: dts: realtek: rtd129x: Introduce r-bus Andreas Färber 2019-11-11 3:04 ` Andreas Färber 2019-11-13 2:42 ` James Tai 2019-11-13 2:42 ` James Tai 2019-11-13 3:02 ` James Tai 2019-11-13 3:02 ` James Tai 2019-11-14 23:23 ` Andreas Färber 2019-11-14 23:23 ` Andreas Färber 2019-11-11 3:04 ` [PATCH 4/7] ARM: dts: rtd1195: Fix GIC CPU mask Andreas Färber 2019-11-11 3:04 ` Andreas Färber 2019-11-11 3:04 ` [PATCH 5/7] ARM: dts: rtd1195: Introduce r-bus Andreas Färber 2019-11-11 3:04 ` Andreas Färber 2019-11-13 2:53 ` James Tai 2019-11-13 2:53 ` James Tai 2019-11-15 0:16 ` Andreas Färber 2019-11-15 0:16 ` Andreas Färber 2019-11-18 6:53 ` James Tai [this message] 2019-11-18 6:53 ` James Tai 2019-11-19 11:15 ` Andreas Färber 2019-11-19 11:15 ` Andreas Färber 2019-11-20 9:20 ` James Tai 2019-11-20 9:20 ` James Tai 2019-11-15 1:34 ` Rob Herring 2019-11-15 1:34 ` Rob Herring 2019-11-15 1:51 ` Andreas Färber 2019-11-15 1:51 ` Andreas Färber 2019-11-11 3:04 ` [PATCH 6/7] dt-bindings: arm: realtek: Add RTD1395 and Banana Pi BPI-M4 Andreas Färber 2019-11-11 3:04 ` Andreas Färber 2019-11-14 19:14 ` Rob Herring 2019-11-14 19:14 ` Rob Herring 2019-11-11 3:04 ` [PATCH 7/7] arm64: dts: realtek: Add RTD1395 and BPi-M4 Andreas Färber 2019-11-11 3:04 ` Andreas Färber 2019-11-13 2:57 ` James Tai 2019-11-13 2:57 ` James Tai 2019-11-15 1:17 ` Andreas Färber 2019-11-15 1:17 ` Andreas Färber
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=753c18eee3fb4e9ea25d42798542b3dd@realtek.com \ --to=james.tai@realtek.com \ --cc=afaerber@suse.de \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-realtek-soc@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.