RE: [PATCH 2/7] arm64: dts: realtek: rtd129x: Use reserved-memory for RPC regions

From: James Tai <james.tai@realtek.com>
To: "Andreas Färber" <afaerber@suse.de>,
	"linux-realtek-soc@lists.infradead.org"
	<linux-realtek-soc@lists.infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/7] arm64: dts: realtek: rtd129x: Use reserved-memory for RPC regions
Date: Mon, 2 Dec 2019 09:49:56 +0000	[thread overview]
Message-ID: <a511b94a991946a1b3f26dcdc485d4fa@realtek.com> (raw)
In-Reply-To: <1f25f2fc-5d31-1d74-b730-78ad7861ffce@suse.de>

Hi Andreas,

> >  /memreserve/	0x0000000000000000 0x0000000000030000;
> > -/memreserve/	0x000000000001f000 0x0000000000001000;
> >  /memreserve/	0x0000000000030000 0x00000000000d0000;
> >  /memreserve/	0x0000000001b00000 0x00000000004be000;
> > -/memreserve/	0x0000000001ffe000 0x0000000000004000;
> >

> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> >  #include <dt-bindings/reset/realtek,rtd1295.h>
> > @@ -19,6 +17,25 @@
> >  	#address-cells = <1>;
> >  	#size-cells = <1>;
> >
> > +	reserved-memory {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges;
> > +
> > +		rpc_comm: rpc@1f000 {
> > +			reg = <0x1f000 0x1000>;
> > +		};
> > +
> > +		rpc_ringbuf: rpc@1ffe000 {
> > +			reg = <0x1ffe000 0x4000>;
> > +		};
> 
> Have you reviewed this patch to be correct? I.e., are the above two regions
> reserved RAM (assumption above), or is this rather MMIO shadowing RAM?
> (then we would need to update the /memory reg and /soc ranges properties)
> 
> That also affects RTD1619, which currently has neither.
> 
The RPC common buffer and RPC ring buffer address is correct.

Regards,
James