All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai3@huawei.com>
To: "Michal Koutný" <mkoutny@suse.com>, tj@kernel.org
Cc: <axboe@kernel.dk>, <ming.lei@redhat.com>,
	<cgroups@vger.kernel.org>, <linux-block@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <yi.zhang@huawei.com>
Subject: Re: [PATCH -next v5 4/8] blk-throttle: fix io hung due to config updates
Date: Sat, 25 Jun 2022 16:36:34 +0800	[thread overview]
Message-ID: <75b3cdcc-1aa3-7259-4900-f09a2a081716@huawei.com> (raw)
In-Reply-To: <20220623162620.GB16004@blackbody.suse.cz>

在 2022/06/24 0:26, Michal Koutný 写道:
> On Thu, Jun 23, 2022 at 08:27:11PM +0800, Yu Kuai <yukuai3@huawei.com> wrote:
>>> Here we may allow to dispatch a bio above current slice's
>>> calculate_bytes_allowed() if bytes_skipped is already >0.
>>
>> Hi, I don't expect that to happen. For example, if a bio is still
>> throttled, then old slice is keeped with proper 'bytes_skipped',
>> then new wait time is caculated based on (bio_size - bytes_skipped).
>>
>> After the bio is dispatched(I assum that other bios can't preempt),
> 
> With this assumptions it adds up as you write. I believe we're in
> agreement.
> 
> It's the same assumption I made below (FIFO everywhere, i.e. no
> reordering). So the discussed difference shouldn't really be negative
> (and if the assumption didn't hold, so the modular arithmetic yields
> corerct bytes_skipped value).
Yes, nice that we're in aggreement.

I'll wait to see if Tejun has any suggestions.

Thanks,
Kuai
> 
> Michal
> .
> 

WARNING: multiple messages have this Message-ID (diff)
From: Yu Kuai <yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>,
	tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
	ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH -next v5 4/8] blk-throttle: fix io hung due to config updates
Date: Sat, 25 Jun 2022 16:36:34 +0800	[thread overview]
Message-ID: <75b3cdcc-1aa3-7259-4900-f09a2a081716@huawei.com> (raw)
In-Reply-To: <20220623162620.GB16004-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>

在 2022/06/24 0:26, Michal Koutný 写道:
> On Thu, Jun 23, 2022 at 08:27:11PM +0800, Yu Kuai <yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>>> Here we may allow to dispatch a bio above current slice's
>>> calculate_bytes_allowed() if bytes_skipped is already >0.
>>
>> Hi, I don't expect that to happen. For example, if a bio is still
>> throttled, then old slice is keeped with proper 'bytes_skipped',
>> then new wait time is caculated based on (bio_size - bytes_skipped).
>>
>> After the bio is dispatched(I assum that other bios can't preempt),
> 
> With this assumptions it adds up as you write. I believe we're in
> agreement.
> 
> It's the same assumption I made below (FIFO everywhere, i.e. no
> reordering). So the discussed difference shouldn't really be negative
> (and if the assumption didn't hold, so the modular arithmetic yields
> corerct bytes_skipped value).
Yes, nice that we're in aggreement.

I'll wait to see if Tejun has any suggestions.

Thanks,
Kuai
> 
> Michal
> .
> 

  reply	other threads:[~2022-06-25  8:36 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-28  6:43 [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle Yu Kuai
2022-05-28  6:43 ` Yu Kuai
2022-05-28  6:43 ` [PATCH -next v5 1/8] blk-throttle: fix that io throttle can only work for single bio Yu Kuai
2022-05-28  6:43   ` Yu Kuai
2022-05-28  6:43 ` [PATCH -next v5 2/8] blk-throttle: prevent overflow while calculating wait time Yu Kuai
2022-05-28  6:43   ` Yu Kuai
2022-05-28  6:43 ` [PATCH -next v5 3/8] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai
2022-05-28  6:43   ` Yu Kuai
2022-06-22 17:27   ` Michal Koutný
2022-06-23 12:03     ` Yu Kuai
2022-06-23 12:03       ` Yu Kuai
2022-05-28  6:43 ` [PATCH -next v5 4/8] blk-throttle: fix io hung due to config updates Yu Kuai
2022-05-28  6:43   ` Yu Kuai
2022-06-22 17:26   ` Michal Koutný
2022-06-23 12:27     ` Yu Kuai
2022-06-23 12:27       ` Yu Kuai
2022-06-23 16:26       ` Michal Koutný
2022-06-25  8:36         ` Yu Kuai [this message]
2022-06-25  8:36           ` Yu Kuai
2022-06-25 16:41           ` Jens Axboe
2022-06-25 16:41             ` Jens Axboe
2022-06-26  2:39             ` Yu Kuai
2022-06-26  2:39               ` Yu Kuai
2022-07-05 11:42             ` Yu Kuai
2022-07-05 11:42               ` Yu Kuai
2022-05-28  6:43 ` [PATCH -next v5 5/8] blk-throttle: use 'READ/WRITE' instead of '0/1' Yu Kuai
2022-05-28  6:43   ` Yu Kuai
2022-05-28  6:43 ` [PATCH -next v5 6/8] blk-throttle: calling throtl_dequeue/enqueue_tg in pairs Yu Kuai
2022-05-28  6:43   ` Yu Kuai
2022-05-28  6:43 ` [PATCH -next v5 7/8] blk-throttle: cleanup tg_update_disptime() Yu Kuai
2022-05-28  6:43   ` Yu Kuai
2022-05-28  6:43 ` [PATCH -next v5 8/8] blk-throttle: clean up flag 'THROTL_TG_PENDING' Yu Kuai
2022-05-28  6:43   ` Yu Kuai
2022-06-02 11:14 ` [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle Yu Kuai
2022-06-02 11:14   ` Yu Kuai
2022-06-09  0:59   ` Yu Kuai
2022-06-09  0:59     ` Yu Kuai
2022-06-17  1:15     ` Yu Kuai
2022-06-17  1:15       ` Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75b3cdcc-1aa3-7259-4900-f09a2a081716@huawei.com \
    --to=yukuai3@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=tj@kernel.org \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.