All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Neil Armstrong <narmstrong@baylibre.com>,
	dri-devel@lists.freedesktop.org,
	laurent.pinchart+renesas@ideasonboard.com,
	architt@codeaurora.org, mchehab@kernel.org
Cc: Jose.Abreu@synopsys.com, kieran.bingham@ideasonboard.com,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-media@vger.kernel.org,
	hans.verkuil@cisco.com, sakari.ailus@linux.intel.com
Subject: Re: [PATCH v5 3/6] documentation: media: Add documentation for new RGB and YUV bus formats
Date: Fri, 31 Mar 2017 15:14:35 +0200	[thread overview]
Message-ID: <75ede5b8-ad35-c23f-2f02-c206df379357@xs4all.nl> (raw)
In-Reply-To: <1490864675-17336-4-git-send-email-narmstrong@baylibre.com>

On 30/03/17 11:04, Neil Armstrong wrote:
> Add documentation for added Bus Formats to describe RGB and YUV formats used
> as input to the Synopsys DesignWare HDMI TX Controller.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  Documentation/media/uapi/v4l/subdev-formats.rst | 871 +++++++++++++++++++++++-
>  1 file changed, 857 insertions(+), 14 deletions(-)

This looks good, but the "Packed YUV Formats" documentation should be updated.

Currently this says:

-  The number of bus samples per pixel. Pixels that are wider than the
   bus width must be transferred in multiple samples. Common values are
   1, 1.5 (encoded as 1_5) and 2.

I propose this change:

-  The number of bus samples per pixel. Pixels that are wider than the
   bus width must be transferred in multiple samples. Common values are
   0.5 (encoded as 0_5; in this case two pixels are transferred per bus
   sample), 1, 1.5 (encoded as 1_5) and 2.

With that additional change you can add my:

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

Regards,

	Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Neil Armstrong <narmstrong@baylibre.com>,
	dri-devel@lists.freedesktop.org,
	laurent.pinchart+renesas@ideasonboard.com,
	architt@codeaurora.org, mchehab@kernel.org
Cc: Jose.Abreu@synopsys.com, linux-doc@vger.kernel.org,
	kieran.bingham@ideasonboard.com, linux-kernel@vger.kernel.org,
	hans.verkuil@cisco.com, sakari.ailus@linux.intel.com,
	linux-amlogic@lists.infradead.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v5 3/6] documentation: media: Add documentation for new RGB and YUV bus formats
Date: Fri, 31 Mar 2017 15:14:35 +0200	[thread overview]
Message-ID: <75ede5b8-ad35-c23f-2f02-c206df379357@xs4all.nl> (raw)
In-Reply-To: <1490864675-17336-4-git-send-email-narmstrong@baylibre.com>

On 30/03/17 11:04, Neil Armstrong wrote:
> Add documentation for added Bus Formats to describe RGB and YUV formats used
> as input to the Synopsys DesignWare HDMI TX Controller.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  Documentation/media/uapi/v4l/subdev-formats.rst | 871 +++++++++++++++++++++++-
>  1 file changed, 857 insertions(+), 14 deletions(-)

This looks good, but the "Packed YUV Formats" documentation should be updated.

Currently this says:

-  The number of bus samples per pixel. Pixels that are wider than the
   bus width must be transferred in multiple samples. Common values are
   1, 1.5 (encoded as 1_5) and 2.

I propose this change:

-  The number of bus samples per pixel. Pixels that are wider than the
   bus width must be transferred in multiple samples. Common values are
   0.5 (encoded as 0_5; in this case two pixels are transferred per bus
   sample), 1, 1.5 (encoded as 1_5) and 2.

With that additional change you can add my:

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

Regards,

	Hans
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: hverkuil@xs4all.nl (Hans Verkuil)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v5 3/6] documentation: media: Add documentation for new RGB and YUV bus formats
Date: Fri, 31 Mar 2017 15:14:35 +0200	[thread overview]
Message-ID: <75ede5b8-ad35-c23f-2f02-c206df379357@xs4all.nl> (raw)
In-Reply-To: <1490864675-17336-4-git-send-email-narmstrong@baylibre.com>

On 30/03/17 11:04, Neil Armstrong wrote:
> Add documentation for added Bus Formats to describe RGB and YUV formats used
> as input to the Synopsys DesignWare HDMI TX Controller.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  Documentation/media/uapi/v4l/subdev-formats.rst | 871 +++++++++++++++++++++++-
>  1 file changed, 857 insertions(+), 14 deletions(-)

This looks good, but the "Packed YUV Formats" documentation should be updated.

Currently this says:

-  The number of bus samples per pixel. Pixels that are wider than the
   bus width must be transferred in multiple samples. Common values are
   1, 1.5 (encoded as 1_5) and 2.

I propose this change:

-  The number of bus samples per pixel. Pixels that are wider than the
   bus width must be transferred in multiple samples. Common values are
   0.5 (encoded as 0_5; in this case two pixels are transferred per bus
   sample), 1, 1.5 (encoded as 1_5) and 2.

With that additional change you can add my:

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

Regards,

	Hans

  reply	other threads:[~2017-03-31 13:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30  9:04 [PATCH v5 0/6] drm: bridge: dw-hdmi: Add support for Custom PHYs Neil Armstrong
2017-03-30  9:04 ` Neil Armstrong
2017-03-30  9:04 ` Neil Armstrong
2017-03-30  9:04 ` [PATCH v5 1/6] drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong
2017-03-30  9:04 ` [PATCH v5 2/6] media: uapi: Add RGB and YUV bus formats for Synopsys HDMI TX Controller Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong
2017-03-31 13:06   ` Hans Verkuil
2017-03-31 13:06     ` Hans Verkuil
2017-03-30  9:04 ` [PATCH v5 3/6] documentation: media: Add documentation for new RGB and YUV bus formats Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong
2017-03-31 13:14   ` Hans Verkuil [this message]
2017-03-31 13:14     ` Hans Verkuil
2017-03-31 13:14     ` Hans Verkuil
2017-03-31 13:45     ` Neil Armstrong
2017-03-31 13:45       ` Neil Armstrong
2017-03-30  9:04 ` [PATCH v5 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong
2017-03-30  9:04 ` [PATCH v5 5/6] drm: bridge: dw-hdmi: Add Documentation on supported input formats Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong
2017-03-30  9:04 ` [PATCH v5 6/6] drm: bridge: dw-hdmi: Move HPD handling to PHY operations Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong
2017-03-30  9:04   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75ede5b8-ad35-c23f-2f02-c206df379357@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=Jose.Abreu@synopsys.com \
    --cc=architt@codeaurora.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hans.verkuil@cisco.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.