All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: Sean Anderson <sean.anderson@seco.com>,
	u-boot@lists.denx.de, Peng Fan <peng.fan@nxp.com>
Cc: Haibo Chen <haibo.chen@nxp.com>,
	Fabio Estevam <festevam@gmail.com>, Yangbo Lu <yangbo.lu@nxp.com>,
	Michael Walle <michael@walle.cc>, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v3 00/12] fsl_esdhc_imx: port several patches from fsl_esdhc
Date: Tue, 4 Jan 2022 08:19:38 +0900	[thread overview]
Message-ID: <765880ba-c7a5-4128-1f1a-ecd3564021dd@samsung.com> (raw)
In-Reply-To: <20211123200347.3772343-1-sean.anderson@seco.com>

Dear Sean,

On 11/24/21 5:03 AM, Sean Anderson wrote:
> This series ports some of the patches from fsl_esdhc to fsl_esdhc_imx.
> Because these drivers share a common lineage, many of these patches
> apply with minor changes. For each one, I have noted the originating
> commit in the style of linux stable backports. Where I have had to
> modify patches, I have noted the changes I have made before my SoB.
> 
> In fa33d20749 ("mmc: split fsl_esdhc driver for i.MX"), Yangbo says
> 
>> For the two series processors, the eSDHCs are becoming more and more
>> different
> 
> However, these drivers are still extremely similar; the differences
> between them are not major. NXP has not done a good job of porting
> patches which apply to both drivers. This causes the fsl_esdhc_imx
> driver to rot, as the fsl_esdhc gets more general fixes.  For this
> reason, I think that the fsl_esdhc_imx driver should be removed unless
> NXP can commit to creating series like this which port patches which
> apply to both drivers.

Sorry for too late.
I had been tried to applied this series from patchwork, but i can't see [PATCH v3 01/12].

Best Regards,
Jaehoon Chung

> 
> Changes in v3:
> - Drop Kconfig BLK dependency
> - Fix build error caused by unconverted OF_PLATDATA code
> - Replace more #ifdefs by if
> 
> Changes in v2:
> - Use a switch statement instead of ifs for max_bus_width
> - Only default to 8 bit width when max_bus_width is not set
> 
> Sean Anderson (12):
>   mmc: fsl_esdhc_imx: make BLK as hard requirement of DM_MMC
>   mmc: fsl_esdhc_imx: remove redundant DM_MMC checking
>   mmc: fsl_esdhc_imx: fix voltage validation
>   mmc: fsl_esdhc_imx: clean up bus width configuration code
>   mmc: fsl_esdhc_imx: drop redundant code for non-removable feature
>   mmc: fsl_esdhc_imx: fix mmc->clock with actual clock
>   mmc: fsl_esdhc_imx: simplify 64bit check for SDMA transfers
>   mmc: fsl_esdhc_imx: use dma-mapping API
>   mmc: fsl_esdhc_imx: simplify esdhc_setup_data()
>   mmc: fsl_esdhc_imx: replace most #ifdefs by IS_ENABLED()
>   mmc: fsl_esdhc_imx: Replace more #ifdefs by if
>   mmc: fsl_esdhc_imx: set sysctl register for clock initialization
> 
>  drivers/mmc/fsl_esdhc_imx.c | 643 ++++++++++++++----------------------
>  include/fsl_esdhc_imx.h     |  14 +-
>  2 files changed, 263 insertions(+), 394 deletions(-)
> 


  parent reply	other threads:[~2022-01-03 23:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20211123200412epcas1p32bd625558b9aa40fa49cd0b23039e59a@epcas1p3.samsung.com>
2021-11-23 20:03 ` [PATCH v3 00/12] fsl_esdhc_imx: port several patches from fsl_esdhc Sean Anderson
2021-11-23 20:03   ` [PATCH v3 01/12] mmc: fsl_esdhc_imx: make BLK as hard requirement of DM_MMC Sean Anderson
2021-11-23 20:03   ` [PATCH v3 02/12] mmc: fsl_esdhc_imx: remove redundant DM_MMC checking Sean Anderson
2021-11-23 20:03   ` [PATCH v3 03/12] mmc: fsl_esdhc_imx: fix voltage validation Sean Anderson
2021-11-23 20:03   ` [PATCH v3 04/12] mmc: fsl_esdhc_imx: clean up bus width configuration code Sean Anderson
2021-11-23 20:03   ` [PATCH v3 05/12] mmc: fsl_esdhc_imx: drop redundant code for non-removable feature Sean Anderson
2021-11-23 20:03   ` [PATCH v3 06/12] mmc: fsl_esdhc_imx: fix mmc->clock with actual clock Sean Anderson
2021-11-23 20:03   ` [PATCH v3 07/12] mmc: fsl_esdhc_imx: simplify 64bit check for SDMA transfers Sean Anderson
2021-11-23 20:03   ` [PATCH v3 08/12] mmc: fsl_esdhc_imx: use dma-mapping API Sean Anderson
2021-11-23 20:03   ` [PATCH v3 09/12] mmc: fsl_esdhc_imx: simplify esdhc_setup_data() Sean Anderson
2021-11-23 20:03   ` [PATCH v3 10/12] mmc: fsl_esdhc_imx: replace most #ifdefs by IS_ENABLED() Sean Anderson
2021-11-23 20:03   ` [PATCH v3 11/12] mmc: fsl_esdhc_imx: Replace more #ifdefs by if Sean Anderson
2021-11-23 20:03   ` [PATCH v3 12/12] mmc: fsl_esdhc_imx: set sysctl register for clock initialization Sean Anderson
2022-01-03 23:19   ` Jaehoon Chung [this message]
2022-01-04 16:16   ` [RESEND PATCH v3 01/12] mmc: fsl_esdhc_imx: make BLK as hard requirement of DM_MMC Sean Anderson
2022-01-11  1:14     ` Jaehoon Chung
2022-01-11 16:15       ` Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=765880ba-c7a5-4128-1f1a-ecd3564021dd@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=michael@walle.cc \
    --cc=peng.fan@nxp.com \
    --cc=sean.anderson@seco.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=yangbo.lu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.