* [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
@ 2018-04-27 19:12 ` Sergei Shtylyov
0 siblings, 0 replies; 24+ messages in thread
From: Sergei Shtylyov @ 2018-04-27 19:12 UTC (permalink / raw)
To: linux-arm-kernel
Define the generic R8A77980 part of the CAN-FD device node.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 31 ++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -38,6 +38,13 @@
};
};
+ /* External CAN clock - to be overridden by boards that provide it */
+ can_clk: can {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <0>;
+ };
+
extal_clk: extal {
compatible = "fixed-clock";
#clock-cells = <0>;
@@ -170,6 +177,30 @@
status = "disabled";
};
+ canfd: can at e66c0000 {
+ compatible = "renesas,r8a77980-canfd",
+ "renesas,rcar-gen3-canfd";
+ reg = <0 0xe66c0000 0 0x8000>;
+ interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 914>,
+ <&cpg CPG_CORE R8A77980_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "fck", "canfd", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
+ status = "disabled";
+
+ channel0 {
+ status = "disabled";
+ };
+
+ channel1 {
+ status = "disabled";
+ };
+ };
+
avb: ethernet at e6800000 {
compatible = "renesas,etheravb-r8a77980",
"renesas,etheravb-rcar-gen3";
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
@ 2018-04-27 19:12 ` Sergei Shtylyov
0 siblings, 0 replies; 24+ messages in thread
From: Sergei Shtylyov @ 2018-04-27 19:12 UTC (permalink / raw)
To: Simon Horman, Rob Herring, Catalin Marinas, Will Deacon,
linux-renesas-soc, devicetree
Cc: Magnus Damm, Mark Rutland, linux-arm-kernel
Define the generic R8A77980 part of the CAN-FD device node.
Based on the original (and large) patch by Vladimir Barinov.
Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 31 ++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -38,6 +38,13 @@
};
};
+ /* External CAN clock - to be overridden by boards that provide it */
+ can_clk: can {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <0>;
+ };
+
extal_clk: extal {
compatible = "fixed-clock";
#clock-cells = <0>;
@@ -170,6 +177,30 @@
status = "disabled";
};
+ canfd: can@e66c0000 {
+ compatible = "renesas,r8a77980-canfd",
+ "renesas,rcar-gen3-canfd";
+ reg = <0 0xe66c0000 0 0x8000>;
+ interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 914>,
+ <&cpg CPG_CORE R8A77980_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "fck", "canfd", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
+ status = "disabled";
+
+ channel0 {
+ status = "disabled";
+ };
+
+ channel1 {
+ status = "disabled";
+ };
+ };
+
avb: ethernet@e6800000 {
compatible = "renesas,etheravb-r8a77980",
"renesas,etheravb-rcar-gen3";
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
2018-04-27 19:12 ` Sergei Shtylyov
(?)
@ 2018-05-02 9:36 ` Simon Horman
-1 siblings, 0 replies; 24+ messages in thread
From: Simon Horman @ 2018-05-02 9:36 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Mark Rutland, devicetree, Magnus Damm, Catalin Marinas,
Will Deacon, linux-renesas-soc, Rob Herring, linux-arm-kernel
On Fri, Apr 27, 2018 at 10:12:51PM +0300, Sergei Shtylyov wrote:
> Define the generic R8A77980 part of the CAN-FD device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks applied with the minor update noted below.
>
> ---
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 31 ++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> ===================================================================
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -38,6 +38,13 @@
> };
> };
>
> + /* External CAN clock - to be overridden by boards that provide it */
> + can_clk: can {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <0>;
> + };
> +
> extal_clk: extal {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> @@ -170,6 +177,30 @@
> status = "disabled";
> };
>
> + canfd: can@e66c0000 {
> + compatible = "renesas,r8a77980-canfd",
> + "renesas,rcar-gen3-canfd";
> + reg = <0 0xe66c0000 0 0x8000>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 914>,
> + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
checkpatch tells me that line above uses spaces for indentation where
a tab could be used. I fixed that up when applying the patch.
> + <&can_clk>;
> + clock-names = "fck", "canfd", "can_clk";
> + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>;
> + assigned-clock-rates = <40000000>;
> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> + status = "disabled";
> +
> + channel0 {
> + status = "disabled";
> + };
> +
> + channel1 {
> + status = "disabled";
> + };
> + };
> +
> avb: ethernet@e6800000 {
> compatible = "renesas,etheravb-r8a77980",
> "renesas,etheravb-rcar-gen3";
>
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
@ 2018-05-02 9:36 ` Simon Horman
0 siblings, 0 replies; 24+ messages in thread
From: Simon Horman @ 2018-05-02 9:36 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Apr 27, 2018 at 10:12:51PM +0300, Sergei Shtylyov wrote:
> Define the generic R8A77980 part of the CAN-FD device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks applied with the minor update noted below.
>
> ---
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 31 ++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> ===================================================================
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -38,6 +38,13 @@
> };
> };
>
> + /* External CAN clock - to be overridden by boards that provide it */
> + can_clk: can {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <0>;
> + };
> +
> extal_clk: extal {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> @@ -170,6 +177,30 @@
> status = "disabled";
> };
>
> + canfd: can at e66c0000 {
> + compatible = "renesas,r8a77980-canfd",
> + "renesas,rcar-gen3-canfd";
> + reg = <0 0xe66c0000 0 0x8000>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 914>,
> + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
checkpatch tells me that line above uses spaces for indentation where
a tab could be used. I fixed that up when applying the patch.
> + <&can_clk>;
> + clock-names = "fck", "canfd", "can_clk";
> + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>;
> + assigned-clock-rates = <40000000>;
> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> + status = "disabled";
> +
> + channel0 {
> + status = "disabled";
> + };
> +
> + channel1 {
> + status = "disabled";
> + };
> + };
> +
> avb: ethernet at e6800000 {
> compatible = "renesas,etheravb-r8a77980",
> "renesas,etheravb-rcar-gen3";
>
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
@ 2018-05-02 9:36 ` Simon Horman
0 siblings, 0 replies; 24+ messages in thread
From: Simon Horman @ 2018-05-02 9:36 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Rob Herring, Catalin Marinas, Will Deacon, linux-renesas-soc,
devicetree, Magnus Damm, Mark Rutland, linux-arm-kernel
On Fri, Apr 27, 2018 at 10:12:51PM +0300, Sergei Shtylyov wrote:
> Define the generic R8A77980 part of the CAN-FD device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks applied with the minor update noted below.
>
> ---
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 31 ++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> ===================================================================
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -38,6 +38,13 @@
> };
> };
>
> + /* External CAN clock - to be overridden by boards that provide it */
> + can_clk: can {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <0>;
> + };
> +
> extal_clk: extal {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> @@ -170,6 +177,30 @@
> status = "disabled";
> };
>
> + canfd: can@e66c0000 {
> + compatible = "renesas,r8a77980-canfd",
> + "renesas,rcar-gen3-canfd";
> + reg = <0 0xe66c0000 0 0x8000>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 914>,
> + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
checkpatch tells me that line above uses spaces for indentation where
a tab could be used. I fixed that up when applying the patch.
> + <&can_clk>;
> + clock-names = "fck", "canfd", "can_clk";
> + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>;
> + assigned-clock-rates = <40000000>;
> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
> + status = "disabled";
> +
> + channel0 {
> + status = "disabled";
> + };
> +
> + channel1 {
> + status = "disabled";
> + };
> + };
> +
> avb: ethernet@e6800000 {
> compatible = "renesas,etheravb-r8a77980",
> "renesas,etheravb-rcar-gen3";
>
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
2018-05-02 9:36 ` Simon Horman
(?)
@ 2018-05-02 9:41 ` Sergei Shtylyov
-1 siblings, 0 replies; 24+ messages in thread
From: Sergei Shtylyov @ 2018-05-02 9:41 UTC (permalink / raw)
To: Simon Horman
Cc: Mark Rutland, devicetree, Magnus Damm, Catalin Marinas,
Will Deacon, linux-renesas-soc, Rob Herring, linux-arm-kernel
Hello!
On 5/2/2018 12:36 PM, Simon Horman wrote:
>> Define the generic R8A77980 part of the CAN-FD device node.
>>
>> Based on the original (and large) patch by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Thanks applied with the minor update noted below.
Thank you!
>> ---
>> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 31 ++++++++++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
[...]
>> @@ -170,6 +177,30 @@
>> status = "disabled";
>> };
>>
>> + canfd: can@e66c0000 {
>> + compatible = "renesas,r8a77980-canfd",
>> + "renesas,rcar-gen3-canfd";
>> + reg = <0 0xe66c0000 0 0x8000>;
>> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 914>,
>> + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
>
> checkpatch tells me that line above uses spaces for indentation where
> a tab could be used. I fixed that up when applying the patch.
Hum, I thought I fixed that... :-/
MBR, Sergei
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
@ 2018-05-02 9:41 ` Sergei Shtylyov
0 siblings, 0 replies; 24+ messages in thread
From: Sergei Shtylyov @ 2018-05-02 9:41 UTC (permalink / raw)
To: linux-arm-kernel
Hello!
On 5/2/2018 12:36 PM, Simon Horman wrote:
>> Define the generic R8A77980 part of the CAN-FD device node.
>>
>> Based on the original (and large) patch by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Thanks applied with the minor update noted below.
Thank you!
>> ---
>> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 31 ++++++++++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
[...]
>> @@ -170,6 +177,30 @@
>> status = "disabled";
>> };
>>
>> + canfd: can at e66c0000 {
>> + compatible = "renesas,r8a77980-canfd",
>> + "renesas,rcar-gen3-canfd";
>> + reg = <0 0xe66c0000 0 0x8000>;
>> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 914>,
>> + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
>
> checkpatch tells me that line above uses spaces for indentation where
> a tab could be used. I fixed that up when applying the patch.
Hum, I thought I fixed that... :-/
MBR, Sergei
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
@ 2018-05-02 9:41 ` Sergei Shtylyov
0 siblings, 0 replies; 24+ messages in thread
From: Sergei Shtylyov @ 2018-05-02 9:41 UTC (permalink / raw)
To: Simon Horman
Cc: Rob Herring, Catalin Marinas, Will Deacon, linux-renesas-soc,
devicetree, Magnus Damm, Mark Rutland, linux-arm-kernel
Hello!
On 5/2/2018 12:36 PM, Simon Horman wrote:
>> Define the generic R8A77980 part of the CAN-FD device node.
>>
>> Based on the original (and large) patch by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Thanks applied with the minor update noted below.
Thank you!
>> ---
>> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 31 ++++++++++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
[...]
>> @@ -170,6 +177,30 @@
>> status = "disabled";
>> };
>>
>> + canfd: can@e66c0000 {
>> + compatible = "renesas,r8a77980-canfd",
>> + "renesas,rcar-gen3-canfd";
>> + reg = <0 0xe66c0000 0 0x8000>;
>> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 914>,
>> + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
>
> checkpatch tells me that line above uses spaces for indentation where
> a tab could be used. I fixed that up when applying the patch.
Hum, I thought I fixed that... :-/
MBR, Sergei
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
2018-04-27 19:12 ` Sergei Shtylyov
(?)
@ 2018-05-04 7:52 ` Geert Uytterhoeven
-1 siblings, 0 replies; 24+ messages in thread
From: Geert Uytterhoeven @ 2018-05-04 7:52 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Catalin Marinas, Will Deacon, Rob Herring,
Linux-Renesas, Simon Horman, Linux ARM
Hi Sergei,
On Fri, Apr 27, 2018 at 9:12 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Define the generic R8A77980 part of the CAN-FD device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks for your patch!
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
=
> @@ -170,6 +177,30 @@
> status = "disabled";
> };
>
> + canfd: can@e66c0000 {
> + compatible = "renesas,r8a77980-canfd",
> + "renesas,rcar-gen3-canfd";
> + reg = <0 0xe66c0000 0 0x8000>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 914>,
> + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
> + <&can_clk>;
> + clock-names = "fck", "canfd", "can_clk";
> + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>;
> + assigned-clock-rates = <40000000>;
> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
You forgot the resets property.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
@ 2018-05-04 7:52 ` Geert Uytterhoeven
0 siblings, 0 replies; 24+ messages in thread
From: Geert Uytterhoeven @ 2018-05-04 7:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Fri, Apr 27, 2018 at 9:12 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Define the generic R8A77980 part of the CAN-FD device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks for your patch!
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
=
> @@ -170,6 +177,30 @@
> status = "disabled";
> };
>
> + canfd: can at e66c0000 {
> + compatible = "renesas,r8a77980-canfd",
> + "renesas,rcar-gen3-canfd";
> + reg = <0 0xe66c0000 0 0x8000>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 914>,
> + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
> + <&can_clk>;
> + clock-names = "fck", "canfd", "can_clk";
> + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>;
> + assigned-clock-rates = <40000000>;
> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
You forgot the resets property.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
@ 2018-05-04 7:52 ` Geert Uytterhoeven
0 siblings, 0 replies; 24+ messages in thread
From: Geert Uytterhoeven @ 2018-05-04 7:52 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Simon Horman, Rob Herring, Catalin Marinas, Will Deacon,
Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Mark Rutland, Linux ARM
Hi Sergei,
On Fri, Apr 27, 2018 at 9:12 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Define the generic R8A77980 part of the CAN-FD device node.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thanks for your patch!
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
=
> @@ -170,6 +177,30 @@
> status = "disabled";
> };
>
> + canfd: can@e66c0000 {
> + compatible = "renesas,r8a77980-canfd",
> + "renesas,rcar-gen3-canfd";
> + reg = <0 0xe66c0000 0 0x8000>;
> + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 914>,
> + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
> + <&can_clk>;
> + clock-names = "fck", "canfd", "can_clk";
> + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>;
> + assigned-clock-rates = <40000000>;
> + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
You forgot the resets property.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
2018-05-04 7:52 ` Geert Uytterhoeven
(?)
@ 2018-05-09 17:54 ` Simon Horman
-1 siblings, 0 replies; 24+ messages in thread
From: Simon Horman @ 2018-05-09 17:54 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Sergei Shtylyov, Catalin Marinas, Will Deacon,
Linux-Renesas, Rob Herring, Linux ARM
On Fri, May 04, 2018 at 09:52:38AM +0200, Geert Uytterhoeven wrote:
> Hi Sergei,
>
> On Fri, Apr 27, 2018 at 9:12 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Define the generic R8A77980 part of the CAN-FD device node.
> >
> > Based on the original (and large) patch by Vladimir Barinov.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Thanks for your patch!
>
> > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> =
> > @@ -170,6 +177,30 @@
> > status = "disabled";
> > };
> >
> > + canfd: can@e66c0000 {
> > + compatible = "renesas,r8a77980-canfd",
> > + "renesas,rcar-gen3-canfd";
> > + reg = <0 0xe66c0000 0 0x8000>;
> > + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 914>,
> > + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
> > + <&can_clk>;
> > + clock-names = "fck", "canfd", "can_clk";
> > + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>;
> > + assigned-clock-rates = <40000000>;
> > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
>
> You forgot the resets property.
Thanks, I have sent a follow-up patch.
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
@ 2018-05-09 17:54 ` Simon Horman
0 siblings, 0 replies; 24+ messages in thread
From: Simon Horman @ 2018-05-09 17:54 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 04, 2018 at 09:52:38AM +0200, Geert Uytterhoeven wrote:
> Hi Sergei,
>
> On Fri, Apr 27, 2018 at 9:12 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Define the generic R8A77980 part of the CAN-FD device node.
> >
> > Based on the original (and large) patch by Vladimir Barinov.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Thanks for your patch!
>
> > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> =
> > @@ -170,6 +177,30 @@
> > status = "disabled";
> > };
> >
> > + canfd: can at e66c0000 {
> > + compatible = "renesas,r8a77980-canfd",
> > + "renesas,rcar-gen3-canfd";
> > + reg = <0 0xe66c0000 0 0x8000>;
> > + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 914>,
> > + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
> > + <&can_clk>;
> > + clock-names = "fck", "canfd", "can_clk";
> > + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>;
> > + assigned-clock-rates = <40000000>;
> > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
>
> You forgot the resets property.
Thanks, I have sent a follow-up patch.
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add CAN-FD support
@ 2018-05-09 17:54 ` Simon Horman
0 siblings, 0 replies; 24+ messages in thread
From: Simon Horman @ 2018-05-09 17:54 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Sergei Shtylyov, Rob Herring, Catalin Marinas, Will Deacon,
Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm, Mark Rutland, Linux ARM
On Fri, May 04, 2018 at 09:52:38AM +0200, Geert Uytterhoeven wrote:
> Hi Sergei,
>
> On Fri, Apr 27, 2018 at 9:12 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Define the generic R8A77980 part of the CAN-FD device node.
> >
> > Based on the original (and large) patch by Vladimir Barinov.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Thanks for your patch!
>
> > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> =
> > @@ -170,6 +177,30 @@
> > status = "disabled";
> > };
> >
> > + canfd: can@e66c0000 {
> > + compatible = "renesas,r8a77980-canfd",
> > + "renesas,rcar-gen3-canfd";
> > + reg = <0 0xe66c0000 0 0x8000>;
> > + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 914>,
> > + <&cpg CPG_CORE R8A77980_CLK_CANFD>,
> > + <&can_clk>;
> > + clock-names = "fck", "canfd", "can_clk";
> > + assigned-clocks = <&cpg CPG_CORE R8A77980_CLK_CANFD>;
> > + assigned-clock-rates = <40000000>;
> > + power-domains = <&sysc R8A77980_PD_ALWAYS_ON>;
>
> You forgot the resets property.
Thanks, I have sent a follow-up patch.
^ permalink raw reply [flat|nested] 24+ messages in thread