From: Ludovic BARRE <ludovic.barre@st.com>
To: Mark Brown <broonie@kernel.org>
Cc: Marek Vasut <marek.vasut@gmail.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
<linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] spi: stm32-qspi: add spi_master_put in release function
Date: Mon, 25 Mar 2019 17:19:44 +0100 [thread overview]
Message-ID: <7742cae8-3fcf-a3ba-2807-d5ed100cd8a4@st.com> (raw)
In-Reply-To: <20190325160313.GJ7284@sirena.org.uk>
hi Mark
On 3/25/19 5:03 PM, Mark Brown wrote:
> On Fri, Mar 22, 2019 at 03:35:53PM +0100, Ludovic Barre wrote:
>> From: Ludovic Barre <ludovic.barre@st.com>
>>
>> This patch adds spi_master_put in release function
>> to drop the controller's refcount.
>
> I'm getting build errors with this:
>
> CC drivers/spi/spi-stm32-qspi.o
> drivers/spi/spi-stm32-qspi.c: In function ‘stm32_qspi_probe’:
> drivers/spi/spi-stm32-qspi.c:430:8: error: ‘struct stm32_qspi’ has no member named ‘phys_base’; did you mean ‘io_base’?
> qspi->phys_base = res->start;
> ^~~~~~~~~
> io_base
>
I was sure I built each patch, but the fact is there an error :-(
I resend a serie with this line in the second patch
Regards
Ludo
WARNING: multiple messages have this Message-ID (diff)
From: Ludovic BARRE <ludovic.barre@st.com>
To: Mark Brown <broonie@kernel.org>
Cc: Marek Vasut <marek.vasut@gmail.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: stm32-qspi: add spi_master_put in release function
Date: Mon, 25 Mar 2019 17:19:44 +0100 [thread overview]
Message-ID: <7742cae8-3fcf-a3ba-2807-d5ed100cd8a4@st.com> (raw)
In-Reply-To: <20190325160313.GJ7284@sirena.org.uk>
hi Mark
On 3/25/19 5:03 PM, Mark Brown wrote:
> On Fri, Mar 22, 2019 at 03:35:53PM +0100, Ludovic Barre wrote:
>> From: Ludovic Barre <ludovic.barre@st.com>
>>
>> This patch adds spi_master_put in release function
>> to drop the controller's refcount.
>
> I'm getting build errors with this:
>
> CC drivers/spi/spi-stm32-qspi.o
> drivers/spi/spi-stm32-qspi.c: In function ‘stm32_qspi_probe’:
> drivers/spi/spi-stm32-qspi.c:430:8: error: ‘struct stm32_qspi’ has no member named ‘phys_base’; did you mean ‘io_base’?
> qspi->phys_base = res->start;
> ^~~~~~~~~
> io_base
>
I was sure I built each patch, but the fact is there an error :-(
I resend a serie with this line in the second patch
Regards
Ludo
WARNING: multiple messages have this Message-ID (diff)
From: Ludovic BARRE <ludovic.barre@st.com>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
Boris Brezillon <bbrezillon@kernel.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Marek Vasut <marek.vasut@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] spi: stm32-qspi: add spi_master_put in release function
Date: Mon, 25 Mar 2019 17:19:44 +0100 [thread overview]
Message-ID: <7742cae8-3fcf-a3ba-2807-d5ed100cd8a4@st.com> (raw)
In-Reply-To: <20190325160313.GJ7284@sirena.org.uk>
hi Mark
On 3/25/19 5:03 PM, Mark Brown wrote:
> On Fri, Mar 22, 2019 at 03:35:53PM +0100, Ludovic Barre wrote:
>> From: Ludovic Barre <ludovic.barre@st.com>
>>
>> This patch adds spi_master_put in release function
>> to drop the controller's refcount.
>
> I'm getting build errors with this:
>
> CC drivers/spi/spi-stm32-qspi.o
> drivers/spi/spi-stm32-qspi.c: In function ‘stm32_qspi_probe’:
> drivers/spi/spi-stm32-qspi.c:430:8: error: ‘struct stm32_qspi’ has no member named ‘phys_base’; did you mean ‘io_base’?
> qspi->phys_base = res->start;
> ^~~~~~~~~
> io_base
>
I was sure I built each patch, but the fact is there an error :-(
I resend a serie with this line in the second patch
Regards
Ludo
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Ludovic BARRE <ludovic.barre@st.com>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
Boris Brezillon <bbrezillon@kernel.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Marek Vasut <marek.vasut@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] spi: stm32-qspi: add spi_master_put in release function
Date: Mon, 25 Mar 2019 17:19:44 +0100 [thread overview]
Message-ID: <7742cae8-3fcf-a3ba-2807-d5ed100cd8a4@st.com> (raw)
In-Reply-To: <20190325160313.GJ7284@sirena.org.uk>
hi Mark
On 3/25/19 5:03 PM, Mark Brown wrote:
> On Fri, Mar 22, 2019 at 03:35:53PM +0100, Ludovic Barre wrote:
>> From: Ludovic Barre <ludovic.barre@st.com>
>>
>> This patch adds spi_master_put in release function
>> to drop the controller's refcount.
>
> I'm getting build errors with this:
>
> CC drivers/spi/spi-stm32-qspi.o
> drivers/spi/spi-stm32-qspi.c: In function ‘stm32_qspi_probe’:
> drivers/spi/spi-stm32-qspi.c:430:8: error: ‘struct stm32_qspi’ has no member named ‘phys_base’; did you mean ‘io_base’?
> qspi->phys_base = res->start;
> ^~~~~~~~~
> io_base
>
I was sure I built each patch, but the fact is there an error :-(
I resend a serie with this line in the second patch
Regards
Ludo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-25 16:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 14:35 [PATCH 0/2] spi: stm32-qspi: add dma support Ludovic Barre
2019-03-22 14:35 ` Ludovic Barre
2019-03-22 14:35 ` Ludovic Barre
2019-03-22 14:35 ` Ludovic Barre
2019-03-22 14:35 ` [PATCH 1/2] spi: stm32-qspi: add spi_master_put in release function Ludovic Barre
2019-03-22 14:35 ` Ludovic Barre
2019-03-22 14:35 ` Ludovic Barre
2019-03-22 14:35 ` Ludovic Barre
2019-03-25 16:03 ` Mark Brown
2019-03-25 16:03 ` Mark Brown
2019-03-25 16:03 ` Mark Brown
2019-03-25 16:19 ` Ludovic BARRE [this message]
2019-03-25 16:19 ` Ludovic BARRE
2019-03-25 16:19 ` Ludovic BARRE
2019-03-25 16:19 ` Ludovic BARRE
2019-03-22 14:35 ` [PATCH 2/2] spi: stm32-qspi: add dma support Ludovic Barre
2019-03-22 14:35 ` Ludovic Barre
2019-03-22 14:35 ` Ludovic Barre
2019-03-22 14:35 ` Ludovic Barre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7742cae8-3fcf-a3ba-2807-d5ed100cd8a4@st.com \
--to=ludovic.barre@st.com \
--cc=alexandre.torgue@st.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marek.vasut@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.