From: Neil Armstrong <narmstrong@baylibre.com>
To: "Carlo Caione" <carlo@caione.org>, "Andreas Färber" <afaerber@suse.de>
Cc: Kevin Hilman <khilman@baylibre.com>,
devicetree <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-amlogic <linux-amlogic@lists.infradead.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X
Date: Tue, 13 Sep 2016 09:36:01 +0200 [thread overview]
Message-ID: <7755ed8c-6083-4e2a-620c-85f55ca1d16e@baylibre.com> (raw)
In-Reply-To: <CAOQ7t2ZjDjZbUfCKwUf4PHywOZx-UiQmy37TEQhWDNYRg0BOag@mail.gmail.com>
On 09/13/2016 08:14 AM, Carlo Caione wrote:
> On Mon, Sep 12, 2016 at 11:43 PM, Andreas Färber <afaerber@suse.de> wrote:
>
> [cut]
>> I'm not arguing over the file name, where it perfectly makes sense to
>> have a meson-gxl- prefix (already discussed), just about the compatible
>> string where we don't have "amlogic,meson-gxl-s905x-p231" either because
>> it is completely unnecessary and does _not_ add any value.
>>
>> Not that we're checking this string anywhere anyway... If you want to
>> check for the GXL family you have to use "amlogic,meson-gxl"; if you
>> want to check for the specific SoC you use "amlogic,s905x". Simple. We
>> never match partial strings, so there is no sense in a hardcoded prefix
>> that is duplicating information already available.
>
> Ok, then. Fine with me.
>
> Neil, do you want to resend my patch or you can take care of the fixes
> for the whole patchset?
>
> Thanks,
>
Ok, I still need to synchronize with kevin for when and where to rebase from.
Neil
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X
Date: Tue, 13 Sep 2016 09:36:01 +0200 [thread overview]
Message-ID: <7755ed8c-6083-4e2a-620c-85f55ca1d16e@baylibre.com> (raw)
In-Reply-To: <CAOQ7t2ZjDjZbUfCKwUf4PHywOZx-UiQmy37TEQhWDNYRg0BOag@mail.gmail.com>
On 09/13/2016 08:14 AM, Carlo Caione wrote:
> On Mon, Sep 12, 2016 at 11:43 PM, Andreas F?rber <afaerber@suse.de> wrote:
>
> [cut]
>> I'm not arguing over the file name, where it perfectly makes sense to
>> have a meson-gxl- prefix (already discussed), just about the compatible
>> string where we don't have "amlogic,meson-gxl-s905x-p231" either because
>> it is completely unnecessary and does _not_ add any value.
>>
>> Not that we're checking this string anywhere anyway... If you want to
>> check for the GXL family you have to use "amlogic,meson-gxl"; if you
>> want to check for the specific SoC you use "amlogic,s905x". Simple. We
>> never match partial strings, so there is no sense in a hardcoded prefix
>> that is duplicating information already available.
>
> Ok, then. Fine with me.
>
> Neil, do you want to resend my patch or you can take care of the fixes
> for the whole patchset?
>
> Thanks,
>
Ok, I still need to synchronize with kevin for when and where to rebase from.
Neil
WARNING: multiple messages have this Message-ID (diff)
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X
Date: Tue, 13 Sep 2016 09:36:01 +0200 [thread overview]
Message-ID: <7755ed8c-6083-4e2a-620c-85f55ca1d16e@baylibre.com> (raw)
In-Reply-To: <CAOQ7t2ZjDjZbUfCKwUf4PHywOZx-UiQmy37TEQhWDNYRg0BOag@mail.gmail.com>
On 09/13/2016 08:14 AM, Carlo Caione wrote:
> On Mon, Sep 12, 2016 at 11:43 PM, Andreas F?rber <afaerber@suse.de> wrote:
>
> [cut]
>> I'm not arguing over the file name, where it perfectly makes sense to
>> have a meson-gxl- prefix (already discussed), just about the compatible
>> string where we don't have "amlogic,meson-gxl-s905x-p231" either because
>> it is completely unnecessary and does _not_ add any value.
>>
>> Not that we're checking this string anywhere anyway... If you want to
>> check for the GXL family you have to use "amlogic,meson-gxl"; if you
>> want to check for the specific SoC you use "amlogic,s905x". Simple. We
>> never match partial strings, so there is no sense in a hardcoded prefix
>> that is duplicating information already available.
>
> Ok, then. Fine with me.
>
> Neil, do you want to resend my patch or you can take care of the fixes
> for the whole patchset?
>
> Thanks,
>
Ok, I still need to synchronize with kevin for when and where to rebase from.
Neil
next prev parent reply other threads:[~2016-09-13 7:36 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 8:22 [PATCH 0/3] ARM64: amlogic: Add support for GXL SoC Family Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-03 8:22 ` [PATCH 1/3] ARM64: dts: amlogic: Add Meson GX dtsi from GXBB Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-12 15:46 ` Andreas Färber
2016-09-12 15:46 ` Andreas Färber
2016-09-12 15:46 ` Andreas Färber
2016-09-03 8:22 ` [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-12 16:28 ` Andreas Färber
2016-09-12 16:28 ` Andreas Färber
2016-09-12 16:28 ` Andreas Färber
2016-09-12 16:28 ` Andreas Färber
2016-09-12 17:18 ` Carlo Caione
2016-09-12 17:18 ` Carlo Caione
2016-09-12 17:18 ` Carlo Caione
2016-09-12 17:18 ` Carlo Caione
2016-09-12 20:43 ` Kevin Hilman
2016-09-12 20:43 ` Kevin Hilman
2016-09-12 20:43 ` Kevin Hilman
2016-09-12 21:43 ` Andreas Färber
2016-09-12 21:43 ` Andreas Färber
2016-09-12 21:43 ` Andreas Färber
2016-09-13 4:43 ` Kevin Hilman
2016-09-13 4:43 ` Kevin Hilman
2016-09-13 4:43 ` Kevin Hilman
2016-09-13 6:14 ` Carlo Caione
2016-09-13 6:14 ` Carlo Caione
2016-09-13 6:14 ` Carlo Caione
2016-09-13 6:14 ` Carlo Caione
2016-09-13 7:36 ` Neil Armstrong [this message]
2016-09-13 7:36 ` Neil Armstrong
2016-09-13 7:36 ` Neil Armstrong
2016-09-03 8:22 ` [PATCH 3/3] ARM64: dts: amlogic: Add basic support for Amlogic S905D Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-03 8:22 ` Neil Armstrong
2016-09-12 15:42 ` Rob Herring
2016-09-12 15:42 ` Rob Herring
2016-09-12 15:42 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7755ed8c-6083-4e2a-620c-85f55ca1d16e@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=afaerber@suse.de \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.