All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Carlo Caione <carlo@caione.org>
Cc: "Andreas Färber" <afaerber@suse.de>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	devicetree <devicetree@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	"Carlo Caione" <carlo@endlessm.com>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X
Date: Mon, 12 Sep 2016 13:43:39 -0700	[thread overview]
Message-ID: <7ha8fcq26c.fsf@baylibre.com> (raw)
In-Reply-To: <CAOQ7t2bWLq2XP2rKx3msf=1tUfXkQuBWagun46TaKk73qXr=FQ@mail.gmail.com> (Carlo Caione's message of "Mon, 12 Sep 2016 19:18:10 +0200")

Carlo Caione <carlo@caione.org> writes:

> On Mon, Sep 12, 2016 at 6:28 PM, Andreas Färber <afaerber@suse.de> wrote:
>
>>> +Boards with the Amlogic Meson GXL SoC shall have the following properties:
>>> +  Required root node property:
>>> +    compatible: "amlogic,meson-gxl-s905x", "amlogic,meson-gxl";
>>
>> Can we please use "amlogic,s905x", "amlogic,meson-gxl"? No need to
>> complicate the name. Also affects .dtsi and .dts below.
>
> gxl != s905x.
>
> AFAWK to the GXL family belong several different SoCs, like S905X,
> S905D, etc... (see patch 3/3)
> This is why we use meson-gxl-s905x, meson-gxl-s905d, etc...

Correct.

> We could s/meson-gxl-s905x/meson-s905x/ and
> s/meson-gxl-s905d/meson-s905d/ but I honestly prefer this way because
> we can clearly see which family the SoC belongs to (the Amlogic naming
> convention is already messy enough).
> I mean, yes it's longer, but it's for the sake of documentation IMO.

+1

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X
Date: Mon, 12 Sep 2016 13:43:39 -0700	[thread overview]
Message-ID: <7ha8fcq26c.fsf@baylibre.com> (raw)
In-Reply-To: <CAOQ7t2bWLq2XP2rKx3msf=1tUfXkQuBWagun46TaKk73qXr=FQ@mail.gmail.com> (Carlo Caione's message of "Mon, 12 Sep 2016 19:18:10 +0200")

Carlo Caione <carlo@caione.org> writes:

> On Mon, Sep 12, 2016 at 6:28 PM, Andreas F?rber <afaerber@suse.de> wrote:
>
>>> +Boards with the Amlogic Meson GXL SoC shall have the following properties:
>>> +  Required root node property:
>>> +    compatible: "amlogic,meson-gxl-s905x", "amlogic,meson-gxl";
>>
>> Can we please use "amlogic,s905x", "amlogic,meson-gxl"? No need to
>> complicate the name. Also affects .dtsi and .dts below.
>
> gxl != s905x.
>
> AFAWK to the GXL family belong several different SoCs, like S905X,
> S905D, etc... (see patch 3/3)
> This is why we use meson-gxl-s905x, meson-gxl-s905d, etc...

Correct.

> We could s/meson-gxl-s905x/meson-s905x/ and
> s/meson-gxl-s905d/meson-s905d/ but I honestly prefer this way because
> we can clearly see which family the SoC belongs to (the Amlogic naming
> convention is already messy enough).
> I mean, yes it's longer, but it's for the sake of documentation IMO.

+1

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X
Date: Mon, 12 Sep 2016 13:43:39 -0700	[thread overview]
Message-ID: <7ha8fcq26c.fsf@baylibre.com> (raw)
In-Reply-To: <CAOQ7t2bWLq2XP2rKx3msf=1tUfXkQuBWagun46TaKk73qXr=FQ@mail.gmail.com> (Carlo Caione's message of "Mon, 12 Sep 2016 19:18:10 +0200")

Carlo Caione <carlo@caione.org> writes:

> On Mon, Sep 12, 2016 at 6:28 PM, Andreas F?rber <afaerber@suse.de> wrote:
>
>>> +Boards with the Amlogic Meson GXL SoC shall have the following properties:
>>> +  Required root node property:
>>> +    compatible: "amlogic,meson-gxl-s905x", "amlogic,meson-gxl";
>>
>> Can we please use "amlogic,s905x", "amlogic,meson-gxl"? No need to
>> complicate the name. Also affects .dtsi and .dts below.
>
> gxl != s905x.
>
> AFAWK to the GXL family belong several different SoCs, like S905X,
> S905D, etc... (see patch 3/3)
> This is why we use meson-gxl-s905x, meson-gxl-s905d, etc...

Correct.

> We could s/meson-gxl-s905x/meson-s905x/ and
> s/meson-gxl-s905d/meson-s905d/ but I honestly prefer this way because
> we can clearly see which family the SoC belongs to (the Amlogic naming
> convention is already messy enough).
> I mean, yes it's longer, but it's for the sake of documentation IMO.

+1

Kevin

  reply	other threads:[~2016-09-12 20:43 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-03  8:22 [PATCH 0/3] ARM64: amlogic: Add support for GXL SoC Family Neil Armstrong
2016-09-03  8:22 ` Neil Armstrong
2016-09-03  8:22 ` Neil Armstrong
2016-09-03  8:22 ` Neil Armstrong
2016-09-03  8:22 ` [PATCH 1/3] ARM64: dts: amlogic: Add Meson GX dtsi from GXBB Neil Armstrong
2016-09-03  8:22   ` Neil Armstrong
2016-09-03  8:22   ` Neil Armstrong
2016-09-03  8:22   ` Neil Armstrong
2016-09-12 15:46   ` Andreas Färber
2016-09-12 15:46     ` Andreas Färber
2016-09-12 15:46     ` Andreas Färber
2016-09-03  8:22 ` [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X Neil Armstrong
2016-09-03  8:22   ` Neil Armstrong
2016-09-03  8:22   ` Neil Armstrong
2016-09-03  8:22   ` Neil Armstrong
2016-09-12 16:28   ` Andreas Färber
2016-09-12 16:28     ` Andreas Färber
2016-09-12 16:28     ` Andreas Färber
2016-09-12 16:28     ` Andreas Färber
2016-09-12 17:18     ` Carlo Caione
2016-09-12 17:18       ` Carlo Caione
2016-09-12 17:18       ` Carlo Caione
2016-09-12 17:18       ` Carlo Caione
2016-09-12 20:43       ` Kevin Hilman [this message]
2016-09-12 20:43         ` Kevin Hilman
2016-09-12 20:43         ` Kevin Hilman
2016-09-12 21:43         ` Andreas Färber
2016-09-12 21:43           ` Andreas Färber
2016-09-12 21:43           ` Andreas Färber
2016-09-13  4:43           ` Kevin Hilman
2016-09-13  4:43             ` Kevin Hilman
2016-09-13  4:43             ` Kevin Hilman
2016-09-13  6:14           ` Carlo Caione
2016-09-13  6:14             ` Carlo Caione
2016-09-13  6:14             ` Carlo Caione
2016-09-13  6:14             ` Carlo Caione
2016-09-13  7:36             ` Neil Armstrong
2016-09-13  7:36               ` Neil Armstrong
2016-09-13  7:36               ` Neil Armstrong
2016-09-03  8:22 ` [PATCH 3/3] ARM64: dts: amlogic: Add basic support for Amlogic S905D Neil Armstrong
2016-09-03  8:22   ` Neil Armstrong
2016-09-03  8:22   ` Neil Armstrong
2016-09-03  8:22   ` Neil Armstrong
2016-09-12 15:42   ` Rob Herring
2016-09-12 15:42     ` Rob Herring
2016-09-12 15:42     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ha8fcq26c.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=afaerber@suse.de \
    --cc=carlo@caione.org \
    --cc=carlo@endlessm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.