All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Prasad J Pandit" <ppandit@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Michael Clark" <mjc@sifive.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Alberto Garcia" <berto@igalia.com>,
	"Li Zhijian" <lizhijian@cn.fujitsu.com>,
	"Alexander Graf" <agraf@suse.de>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Antony Pavlov" <antonynpavlov@gmail.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Corey Minyard" <minyard@acm.org>, "Amit Shah" <amit@kernel.org>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Fabien Chouteau" <chouteau@adacore.com>,
	"Zhang Chen" <zhangckid@gmail.com>,
	"open list:PXA2XX" <qemu-arm@nongnu.org>,
	"Peter Chubb" <peter.chubb@nicta.com.au>,
	"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"open list:X86" <xen-devel@lists.xenproject.org>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"open list:S390 Virtio-ccw" <qemu-s390x@nongnu.org>,
	"Thomas Huth" <huth@tuxfamily.org>,
	"Michael Walle" <michael@walle.cc>,
	"open list:sPAPR" <qemu-ppc@nongnu.org>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>
Subject: Re: [Qemu-devel] [PATCH] chardev: Convert IOReadHandler to read an unsigned number of bytes
Date: Thu, 11 Oct 2018 17:14:11 +0200	[thread overview]
Message-ID: <7762db82-6044-df69-a1b7-c05100a0e938@redhat.com> (raw)
In-Reply-To: <20181011131413.22208-1-philmd@redhat.com>

On 11/10/2018 15:14, Philippe Mathieu-Daudé wrote:
> The number of bytes can not be negative nor zero.
> 
> Fixed 2 format string:
> - hw/char/spapr_vty.c
> - hw/usb/ccid-card-passthru.c
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> See: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02212.html

Not that easy; you need to adjust qemu_chr_be_can_write,
qemu_chr_be_write_impl, qemu_chr_be_write (which is where the callbacks
are invoked).

On the other hand, fd_chr_read_poll is not an IOCanReadHandler, and this
patch therefore probably doesn't compile?

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Prasad J Pandit" <ppandit@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Li Zhijian" <lizhijian@cn.fujitsu.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	qemu-devel@nongnu.org, "Alexander Graf" <agraf@suse.de>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Michael Clark" <mjc@sifive.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Alberto Garcia" <berto@igalia.com>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Antony Pavlov" <antonynpavlov@gmail.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] chardev: Convert IOReadHandler to read an unsigned number of bytes
Date: Thu, 11 Oct 2018 17:14:11 +0200	[thread overview]
Message-ID: <7762db82-6044-df69-a1b7-c05100a0e938@redhat.com> (raw)
In-Reply-To: <20181011131413.22208-1-philmd@redhat.com>

On 11/10/2018 15:14, Philippe Mathieu-Daudé wrote:
> The number of bytes can not be negative nor zero.
> 
> Fixed 2 format string:
> - hw/char/spapr_vty.c
> - hw/usb/ccid-card-passthru.c
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> See: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02212.html

Not that easy; you need to adjust qemu_chr_be_can_write,
qemu_chr_be_write_impl, qemu_chr_be_write (which is where the callbacks
are invoked).

On the other hand, fd_chr_read_poll is not an IOCanReadHandler, and this
patch therefore probably doesn't compile?

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-10-11 15:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11 13:14 [Qemu-devel] [PATCH] chardev: Convert IOReadHandler to read an unsigned number of bytes Philippe Mathieu-Daudé
2018-10-11 14:08 ` Alberto Garcia
2018-10-11 14:08   ` Alberto Garcia
2018-10-11 15:14 ` Paolo Bonzini [this message]
2018-10-11 15:14   ` [Qemu-devel] " Paolo Bonzini
2018-10-11 15:24   ` Philippe Mathieu-Daudé
2018-10-11 15:24     ` Philippe Mathieu-Daudé
2018-10-11 15:34     ` Paolo Bonzini
2018-10-11 15:53       ` Philippe Mathieu-Daudé
2018-10-11 15:53         ` Philippe Mathieu-Daudé
2018-10-11 15:34     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7762db82-6044-df69-a1b7-c05100a0e938@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=alistair@alistair23.me \
    --cc=amit@kernel.org \
    --cc=anthony.perard@citrix.com \
    --cc=antonynpavlov@gmail.com \
    --cc=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=borntraeger@de.ibm.com \
    --cc=chouteau@adacore.com \
    --cc=cohuck@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgilbert@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=huth@tuxfamily.org \
    --cc=i.mitsyanko@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jasowang@redhat.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=kraxel@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=michael@walle.cc \
    --cc=minyard@acm.org \
    --cc=mjc@sifive.com \
    --cc=mst@redhat.com \
    --cc=palmer@sifive.com \
    --cc=peter.chubb@nicta.com.au \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=zhangckid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.