* ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt
@ 2022-12-27 15:23 Nick
2023-01-24 23:11 ` Nick
2023-01-24 23:28 ` Florian Fainelli
0 siblings, 2 replies; 5+ messages in thread
From: Nick @ 2022-12-27 15:23 UTC (permalink / raw)
To: netdev
Commit 1fa60003a8b8 ("misc: header includes cleanup") [0] introduces
"-D_POSIX_C_SOURCE=200809L".
However, this breaks compilation with OpenWrt resulting in following error:
> marvell.c: In function 'dump_queue':
> marvell.c:34:17: error: unknown type name 'u_int32_t'
> 34 | u_int32_t ctl;
> | ^~~~~~~~~
Not sure, why the code uses u_int32_t.
Bests
Nick
[0] -
https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=1fa60003a8b8fa25d783867967860656f593822e
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt
2022-12-27 15:23 ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt Nick
@ 2023-01-24 23:11 ` Nick
2023-01-24 23:28 ` Florian Fainelli
1 sibling, 0 replies; 5+ messages in thread
From: Nick @ 2023-01-24 23:11 UTC (permalink / raw)
To: vincent; +Cc: netdev
Any news on this?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt
2022-12-27 15:23 ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt Nick
2023-01-24 23:11 ` Nick
@ 2023-01-24 23:28 ` Florian Fainelli
2023-01-25 11:26 ` Nick
1 sibling, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2023-01-24 23:28 UTC (permalink / raw)
To: Nick, netdev
On 12/27/22 07:23, Nick wrote:
> Commit 1fa60003a8b8 ("misc: header includes cleanup") [0] introduces
> "-D_POSIX_C_SOURCE=200809L".
> However, this breaks compilation with OpenWrt resulting in following error:
>
>> marvell.c: In function 'dump_queue':
>> marvell.c:34:17: error: unknown type name 'u_int32_t'
>> 34 | u_int32_t ctl;
>> | ^~~~~~~~~
> Not sure, why the code uses u_int32_t.
Should be fixed with:
https://lore.kernel.org/netdev/20230114163411.3290201-1-f.fainelli@gmail.com/T/
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt
2023-01-24 23:28 ` Florian Fainelli
@ 2023-01-25 11:26 ` Nick
2023-01-27 0:10 ` Florian Fainelli
0 siblings, 1 reply; 5+ messages in thread
From: Nick @ 2023-01-25 11:26 UTC (permalink / raw)
To: Florian Fainelli, netdev
Indeed, it is fixed by those patches. Thanks! Why are they still not merged?
On 1/25/23 00:28, Florian Fainelli wrote:
> On 12/27/22 07:23, Nick wrote:
>> Commit 1fa60003a8b8 ("misc: header includes cleanup") [0] introduces
>> "-D_POSIX_C_SOURCE=200809L".
>> However, this breaks compilation with OpenWrt resulting in following
>> error:
>>
>>> marvell.c: In function 'dump_queue':
>>> marvell.c:34:17: error: unknown type name 'u_int32_t'
>>> 34 | u_int32_t ctl;
>>> | ^~~~~~~~~
>> Not sure, why the code uses u_int32_t.
>
> Should be fixed with:
>
> https://lore.kernel.org/netdev/20230114163411.3290201-1-f.fainelli@gmail.com/T/
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt
2023-01-25 11:26 ` Nick
@ 2023-01-27 0:10 ` Florian Fainelli
0 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2023-01-27 0:10 UTC (permalink / raw)
To: Nick, netdev
On 1/25/2023 3:26 AM, Nick wrote:
> Indeed, it is fixed by those patches. Thanks! Why are they still not
> merged?
Michal has some backlog he would like to process, he wrote he would try
to merge these patches this week:
https://lore.kernel.org/all/20230124083907.w7h6rbvh7fsq334y@lion.mk-sys.cz/
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-27 0:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-27 15:23 ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt Nick
2023-01-24 23:11 ` Nick
2023-01-24 23:28 ` Florian Fainelli
2023-01-25 11:26 ` Nick
2023-01-27 0:10 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.