ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt

ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt

[Nick]

Commit 1fa60003a8b8 ("misc: header includes cleanup") [0] introduces 
"-D_POSIX_C_SOURCE=200809L".
However, this breaks compilation with OpenWrt resulting in following error:

> marvell.c: In function 'dump_queue':
> marvell.c:34:17: error: unknown type name 'u_int32_t'
>    34 |                 u_int32_t               ctl;
>       |                 ^~~~~~~~~
Not sure, why the code uses u_int32_t.

Bests
Nick

[0] - 
https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=1fa60003a8b8fa25d783867967860656f593822e

Re: ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt

[Nick]

Any news on this?

Re: ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt

[Florian Fainelli]

On 12/27/22 07:23, Nick wrote:
> Commit 1fa60003a8b8 ("misc: header includes cleanup") [0] introduces 
> "-D_POSIX_C_SOURCE=200809L".
> However, this breaks compilation with OpenWrt resulting in following error:
> 
>> marvell.c: In function 'dump_queue':
>> marvell.c:34:17: error: unknown type name 'u_int32_t'
>>    34 |                 u_int32_t               ctl;
>>       |                 ^~~~~~~~~
> Not sure, why the code uses u_int32_t.

Should be fixed with:

https://lore.kernel.org/netdev/20230114163411.3290201-1-f.fainelli@gmail.com/T/
-- 
Florian

Re: ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt

[Nick]

Indeed, it is fixed by those patches. Thanks! Why are they still not merged?

On 1/25/23 00:28, Florian Fainelli wrote:
> On 12/27/22 07:23, Nick wrote:
>> Commit 1fa60003a8b8 ("misc: header includes cleanup") [0] introduces 
>> "-D_POSIX_C_SOURCE=200809L".
>> However, this breaks compilation with OpenWrt resulting in following 
>> error:
>>
>>> marvell.c: In function 'dump_queue':
>>> marvell.c:34:17: error: unknown type name 'u_int32_t'
>>>    34 |                 u_int32_t               ctl;
>>>       |                 ^~~~~~~~~
>> Not sure, why the code uses u_int32_t.
>
> Should be fixed with:
>
> https://lore.kernel.org/netdev/20230114163411.3290201-1-f.fainelli@gmail.com/T/ 
>

Re: ethtool: introducing "-D_POSIX_C_SOURCE=200809L" breaks compilation with OpenWrt

[Florian Fainelli]

On 1/25/2023 3:26 AM, Nick wrote:
> Indeed, it is fixed by those patches. Thanks! Why are they still not 
> merged?

Michal has some backlog he would like to process, he wrote he would try 
to merge these patches this week:

https://lore.kernel.org/all/20230124083907.w7h6rbvh7fsq334y@lion.mk-sys.cz/
-- 
Florian