All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Biao Huang <biao.huang@mediatek.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"andrew@lunn.ch" <andrew@lunn.ch>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-stm32@st-md-mailman.stormreply.com" 
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org" 
	<linux-mediatek@lists.infradead.org>,
	"yt.shen@mediatek.com" <yt.shen@mediatek.com>,
	"jianguo.zhang@mediatek.com" <jianguo.zhang@mediatek.com>,
	"boon.leong.ong@intel.com" <boon.leong.ong@intel.com>
Subject: RE: [v2, PATCH 3/4] net: stmmac: modify default value of tx-frames
Date: Mon, 3 Jun 2019 11:40:37 +0000	[thread overview]
Message-ID: <78EB27739596EE489E55E81C33FEC33A0B93B6DF@DE02WEMBXB.internal.synopsys.com> (raw)
In-Reply-To: <1559527086-7227-4-git-send-email-biao.huang@mediatek.com>

From: Biao Huang <biao.huang@mediatek.com>

> the default value of tx-frames is 25, it's too late when
> passing tstamp to stack, then the ptp4l will fail:
> 
> ptp4l -i eth0 -f gPTP.cfg -m
> ptp4l: selected /dev/ptp0 as PTP clock
> ptp4l: port 1: INITIALIZING to LISTENING on INITIALIZE
> ptp4l: port 0: INITIALIZING to LISTENING on INITIALIZE
> ptp4l: port 1: link up
> ptp4l: timed out while polling for tx timestamp
> ptp4l: increasing tx_timestamp_timeout may correct this issue,
>        but it is likely caused by a driver bug
> ptp4l: port 1: send peer delay response failed
> ptp4l: port 1: LISTENING to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED)
> 
> ptp4l tests pass when changing the tx-frames from 25 to 1 with
> ethtool -C option.
> It should be fine to set tx-frames default value to 1, so ptp4l will pass
> by default.

I'm not sure if this is the right approach ... What's the timeout value 
you have for TX Timestamp ?

Thanks,
Jose Miguel Abreu

WARNING: multiple messages have this Message-ID (diff)
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Biao Huang <biao.huang@mediatek.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"andrew@lunn.ch" <andrew@lunn.ch>
Cc: "jianguo.zhang@mediatek.com" <jianguo.zhang@mediatek.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	"boon.leong.ong@intel.com" <boon.leong.ong@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"yt.shen@mediatek.com" <yt.shen@mediatek.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [v2, PATCH 3/4] net: stmmac: modify default value of tx-frames
Date: Mon, 3 Jun 2019 11:40:37 +0000	[thread overview]
Message-ID: <78EB27739596EE489E55E81C33FEC33A0B93B6DF@DE02WEMBXB.internal.synopsys.com> (raw)
In-Reply-To: <1559527086-7227-4-git-send-email-biao.huang@mediatek.com>

From: Biao Huang <biao.huang@mediatek.com>

> the default value of tx-frames is 25, it's too late when
> passing tstamp to stack, then the ptp4l will fail:
> 
> ptp4l -i eth0 -f gPTP.cfg -m
> ptp4l: selected /dev/ptp0 as PTP clock
> ptp4l: port 1: INITIALIZING to LISTENING on INITIALIZE
> ptp4l: port 0: INITIALIZING to LISTENING on INITIALIZE
> ptp4l: port 1: link up
> ptp4l: timed out while polling for tx timestamp
> ptp4l: increasing tx_timestamp_timeout may correct this issue,
>        but it is likely caused by a driver bug
> ptp4l: port 1: send peer delay response failed
> ptp4l: port 1: LISTENING to FAULTY on FAULT_DETECTED (FT_UNSPECIFIED)
> 
> ptp4l tests pass when changing the tx-frames from 25 to 1 with
> ethtool -C option.
> It should be fine to set tx-frames default value to 1, so ptp4l will pass
> by default.

I'm not sure if this is the right approach ... What's the timeout value 
you have for TX Timestamp ?

Thanks,
Jose Miguel Abreu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-06-03 11:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03  1:58 [v2, PATCH 0/4] complete dwmac-mediatek driver and fix flow control issue Biao Huang
2019-06-03  1:58 ` Biao Huang
2019-06-03  1:58 ` Biao Huang
2019-06-03  1:58 ` [v2, PATCH 1/4] net: stmmac: dwmac-mediatek: enable Ethernet power domain Biao Huang
2019-06-03  1:58   ` Biao Huang
2019-06-03  1:58   ` Biao Huang
2019-06-03  1:58 ` [v2, PATCH 2/4] net: stmmac: dwmac-mediatek: disable rx watchdog Biao Huang
2019-06-03  1:58   ` Biao Huang
2019-06-03  1:58   ` Biao Huang
2019-06-03  1:58 ` [v2, PATCH 3/4] net: stmmac: modify default value of tx-frames Biao Huang
2019-06-03  1:58   ` Biao Huang
2019-06-03  1:58   ` Biao Huang
2019-06-03 11:40   ` Jose Abreu [this message]
2019-06-03 11:40     ` Jose Abreu
2019-06-03 11:40     ` Jose Abreu
2019-06-04  2:31     ` biao huang
2019-06-04  2:31       ` biao huang
2019-06-04  2:31       ` biao huang
2019-06-03  1:58 ` [v2, PATCH 4/4] net: stmmac: dwmac4: fix flow control issue Biao Huang
2019-06-03  1:58   ` Biao Huang
2019-06-03  1:58   ` Biao Huang
2019-06-06  0:03 ` [v2, PATCH 0/4] complete dwmac-mediatek driver and " David Miller
2019-06-06  0:03   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78EB27739596EE489E55E81C33FEC33A0B93B6DF@DE02WEMBXB.internal.synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=alexandre.torgue@st.com \
    --cc=andrew@lunn.ch \
    --cc=biao.huang@mediatek.com \
    --cc=boon.leong.ong@intel.com \
    --cc=davem@davemloft.net \
    --cc=jianguo.zhang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=yt.shen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.