From: "Hiremath, Vaibhav" <hvaibhav@ti.com> To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com> Cc: Ming Lei <tom.leiming@gmail.com>, "Hilman, Kevin" <khilman@ti.com>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "marc.zyngier@arm.com" <marc.zyngier@arm.com>, "johnstul@us.ibm.com" <johnstul@us.ibm.com>, "Balbi, Felipe" <balbi@ti.com>, "Cousson, Benoit" <b-cousson@ti.com>, Tony Lindgren <tony@atomide.com>, Paul Walmsley <paul@pwsan.com>, "DebBarma, Tarun Kanti" <tarun.kanti@ti.com> Subject: RE: [PATCH 1/3] ARM: OMAP2+: 32k-counter: Use hwmod lookup to check presence of 32k timer Date: Fri, 30 Mar 2012 09:28:08 +0000 [thread overview] Message-ID: <79CD15C6BA57404B839C016229A409A831841009@DBDE01.ent.ti.com> (raw) In-Reply-To: <CAMQu2gzOkE6LD0WZ_9bKe3J-=Dv89rWaMzvWWvJHPMSPe6MzNg@mail.gmail.com> On Fri, Mar 30, 2012 at 14:50:02, Shilimkar, Santosh wrote: > On Fri, Mar 30, 2012 at 2:42 PM, Hiremath, Vaibhav <hvaibhav@ti.com> wrote: > > On Fri, Mar 30, 2012 at 14:08:20, Shilimkar, Santosh wrote: > >> On Friday 30 March 2012 02:02 PM, Hiremath, Vaibhav wrote: > >> > On Fri, Mar 30, 2012 at 13:11:35, Shilimkar, Santosh wrote: > > [....] > > >> > > >> > With this patch, will you be able to choose gptimer as a clocksource > >> > using bootparameter (or sysfs) for given kernel uImage? > >> > > >> Why do you want that ? Look at changelog. The gptimer based clocksource > >> is useless for OMAP and for AM devices synctimer is not available. > >> > >> > >> > The answer is simply NO...as the registration of gptimer is based on > >> > failure from omap_init_clocksource_32k(). And this is nothing different > >> > than my original patch, my patch exactly does same thing. > >> > > >> I ight have missed your original patch. If that patch is similar then > >> no problems. > >> > >> > The requirement after 'ming Lie' response on my patch was, there will be > >> > usecases where we might need to use gptimer for clocksource and with > >> > the patch it is not possible, since you will only register > >> > 32k_counter here. > >> > > >> I think Ming Lie might have expected that gptimer clocksource might > >> be better which is not the case. > >> > >> > So in order to allow user to choose between 32K and gptimer, you must > >> > register both and make 32k as a default thing. > >> > > >> As described in the commit log, its not needed at all. Let's not add > >> a feature which is just useless because the gptimer based clock > >> source has no advantage against the syntimer. > >> > > > > I completely agree with you, and that is my understanding too. > > > Thanks !! > > > After Ming Lie's comment, the point that I came to my mind was, > > certainly there will be resolution difference between these two clocksources, > > if gptimer2 is sourced from sys_ck (26Mhz). > > > GPTIMER2 with sysclock is not an option. GPTIMER is not in wakeup domain > and when sysclock is cut, it stops. > > > I am quite not sure, whether will there be any practical usecase where you > > change the kernel clocksource for high resolution dynamically through sysfs > > or something. May be not....but still it is possible. > > > Even if there is a usecase, there no option with full PM. > What if before suspending the system, you switch back to 32k_counter everytime, and in resume you again switch to gp_timer? Please consider this as just a technical discussion, as I am myself quite not sure whether we have such use-case available. > > > > In that case my original patch still holds good here. I would still request > > you to review the same and give your acked-by or tested-by. > > > I just looked at that. > It looks fine to me. Can you repost that patch addressing Kevin and > Tony's comments. > Also update the change log as describe in the patch i posted. > > Once that done, will ack it. > Thanks for the review and discussion, I will submit revised version shortly. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: hvaibhav@ti.com (Hiremath, Vaibhav) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] ARM: OMAP2+: 32k-counter: Use hwmod lookup to check presence of 32k timer Date: Fri, 30 Mar 2012 09:28:08 +0000 [thread overview] Message-ID: <79CD15C6BA57404B839C016229A409A831841009@DBDE01.ent.ti.com> (raw) In-Reply-To: <CAMQu2gzOkE6LD0WZ_9bKe3J-=Dv89rWaMzvWWvJHPMSPe6MzNg@mail.gmail.com> On Fri, Mar 30, 2012 at 14:50:02, Shilimkar, Santosh wrote: > On Fri, Mar 30, 2012 at 2:42 PM, Hiremath, Vaibhav <hvaibhav@ti.com> wrote: > > On Fri, Mar 30, 2012 at 14:08:20, Shilimkar, Santosh wrote: > >> On Friday 30 March 2012 02:02 PM, Hiremath, Vaibhav wrote: > >> > On Fri, Mar 30, 2012 at 13:11:35, Shilimkar, Santosh wrote: > > [....] > > >> > > >> > With this patch, will you be able to choose gptimer as a clocksource > >> > using bootparameter (or sysfs) for given kernel uImage? > >> > > >> Why do you want that ? Look at changelog. The gptimer based clocksource > >> is useless for OMAP and for AM devices synctimer is not available. > >> > >> > >> > The answer is simply NO...as the registration of gptimer is based on > >> > failure from omap_init_clocksource_32k(). And this is nothing different > >> > than my original patch, my patch exactly does same thing. > >> > > >> I ight have missed your original patch. If that patch is similar then > >> no problems. > >> > >> > The requirement after 'ming Lie' response on my patch was, there will be > >> > usecases where we might need to use gptimer for clocksource and with > >> > the patch it is not possible, since you will only register > >> > 32k_counter here. > >> > > >> I think Ming Lie might have expected that gptimer clocksource might > >> be better which is not the case. > >> > >> > So in order to allow user to choose between 32K and gptimer, you must > >> > register both and make 32k as a default thing. > >> > > >> As described in the commit log, its not needed at all. Let's not add > >> a feature which is just useless because the gptimer based clock > >> source has no advantage against the syntimer. > >> > > > > I completely agree with you, and that is my understanding too. > > > Thanks !! > > > After Ming Lie's comment, the point that I came to my mind was, > > certainly there will be resolution difference between these two clocksources, > > if ?gptimer2 is sourced from sys_ck (26Mhz). > > > GPTIMER2 with sysclock is not an option. GPTIMER is not in wakeup domain > and when sysclock is cut, it stops. > > > I am quite not sure, whether will there be any practical usecase where you > > change the kernel clocksource for high resolution dynamically through sysfs > > or something. May be not....but still it is possible. > > > Even if there is a usecase, there no option with full PM. > What if before suspending the system, you switch back to 32k_counter everytime, and in resume you again switch to gp_timer? Please consider this as just a technical discussion, as I am myself quite not sure whether we have such use-case available. > > > > In that case my original patch still holds good here. I would still request > > you to review the same and give your acked-by ?or tested-by. > > > I just looked at that. > It looks fine to me. Can you repost that patch addressing Kevin and > Tony's comments. > Also update the change log as describe in the patch i posted. > > Once that done, will ack it. > Thanks for the review and discussion, I will submit revised version shortly. Thanks, Vaibhav
next prev parent reply other threads:[~2012-03-30 9:28 UTC|newest] Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-01-19 14:28 [PATCH 0/3] ARM: OMAP1/2+: 32k-timer: Add hwmod lookup for 32k-timer Vaibhav Hiremath 2012-01-19 14:28 ` Vaibhav Hiremath 2012-01-19 14:28 ` [PATCH 1/3] ARM: OMAP2+: 32k-counter: Use hwmod lookup to check presence of 32k timer Vaibhav Hiremath 2012-01-19 14:28 ` Vaibhav Hiremath 2012-01-23 23:38 ` Kevin Hilman 2012-01-23 23:38 ` Kevin Hilman 2012-01-24 8:53 ` Hiremath, Vaibhav 2012-01-24 8:53 ` Hiremath, Vaibhav 2012-01-24 17:47 ` Kevin Hilman 2012-01-24 17:47 ` Kevin Hilman 2012-02-01 8:00 ` Hiremath, Vaibhav 2012-02-01 8:00 ` Hiremath, Vaibhav 2012-03-13 11:37 ` Ming Lei 2012-03-13 11:37 ` Ming Lei 2012-03-19 11:11 ` Hiremath, Vaibhav 2012-03-19 11:11 ` Hiremath, Vaibhav 2012-03-19 11:44 ` Ming Lei 2012-03-19 11:44 ` Ming Lei 2012-03-19 12:15 ` Santosh Shilimkar 2012-03-19 12:15 ` Santosh Shilimkar 2012-03-21 11:42 ` Hiremath, Vaibhav 2012-03-21 11:42 ` Hiremath, Vaibhav 2012-03-21 14:00 ` Shilimkar, Santosh 2012-03-21 14:00 ` Shilimkar, Santosh 2012-03-28 14:16 ` Hiremath, Vaibhav 2012-03-28 14:16 ` Hiremath, Vaibhav 2012-03-28 14:20 ` Shilimkar, Santosh 2012-03-28 14:20 ` Shilimkar, Santosh 2012-03-28 14:37 ` Hiremath, Vaibhav 2012-03-28 14:37 ` Hiremath, Vaibhav 2012-03-28 14:49 ` Shilimkar, Santosh 2012-03-28 14:49 ` Shilimkar, Santosh 2012-03-30 6:34 ` Hiremath, Vaibhav 2012-03-30 6:34 ` Hiremath, Vaibhav 2012-03-30 7:41 ` Shilimkar, Santosh 2012-03-30 7:41 ` Shilimkar, Santosh 2012-03-30 8:32 ` Hiremath, Vaibhav 2012-03-30 8:32 ` Hiremath, Vaibhav 2012-03-30 8:38 ` Santosh Shilimkar 2012-03-30 8:38 ` Santosh Shilimkar 2012-03-30 9:12 ` Hiremath, Vaibhav 2012-03-30 9:12 ` Hiremath, Vaibhav 2012-03-30 9:20 ` Shilimkar, Santosh 2012-03-30 9:20 ` Shilimkar, Santosh 2012-03-30 9:28 ` Hiremath, Vaibhav [this message] 2012-03-30 9:28 ` Hiremath, Vaibhav 2012-03-30 9:42 ` Shilimkar, Santosh 2012-03-30 9:42 ` Shilimkar, Santosh 2012-03-30 11:29 ` Hiremath, Vaibhav 2012-03-30 11:29 ` Hiremath, Vaibhav 2012-03-30 11:35 ` Santosh Shilimkar 2012-03-30 11:35 ` Santosh Shilimkar 2012-03-31 1:30 ` Ming Lei 2012-03-31 1:30 ` Ming Lei 2012-03-31 6:30 ` Shilimkar, Santosh 2012-03-31 6:30 ` Shilimkar, Santosh 2012-03-31 8:39 ` Ming Lei 2012-03-31 8:39 ` Ming Lei 2012-03-31 19:10 ` Shilimkar, Santosh 2012-03-31 19:10 ` Shilimkar, Santosh 2012-04-01 1:39 ` Ming Lei 2012-04-01 1:39 ` Ming Lei 2012-04-01 5:53 ` Shilimkar, Santosh 2012-04-01 5:53 ` Shilimkar, Santosh 2012-04-02 18:35 ` Kevin Hilman 2012-04-02 18:35 ` Kevin Hilman 2012-04-03 5:50 ` Shilimkar, Santosh 2012-04-03 5:50 ` Shilimkar, Santosh 2012-04-03 15:35 ` Hiremath, Vaibhav 2012-04-03 15:35 ` Hiremath, Vaibhav 2012-04-04 9:04 ` Shilimkar, Santosh 2012-04-04 9:04 ` Shilimkar, Santosh 2012-04-04 10:39 ` Hiremath, Vaibhav 2012-04-04 10:39 ` Hiremath, Vaibhav 2012-04-05 9:36 ` Hiremath, Vaibhav 2012-04-05 9:36 ` Hiremath, Vaibhav 2012-04-05 9:52 ` Russell King - ARM Linux 2012-04-05 9:52 ` Russell King - ARM Linux 2012-04-05 10:31 ` Hiremath, Vaibhav 2012-04-05 10:31 ` Hiremath, Vaibhav 2012-04-05 10:46 ` Santosh Shilimkar 2012-04-05 10:46 ` Santosh Shilimkar 2012-04-05 21:33 ` Kevin Hilman 2012-04-05 21:33 ` Kevin Hilman 2012-04-06 5:21 ` Hiremath, Vaibhav 2012-04-06 5:21 ` Hiremath, Vaibhav 2012-04-06 18:04 ` Tony Lindgren 2012-04-06 18:04 ` Tony Lindgren 2012-04-09 6:19 ` Hiremath, Vaibhav 2012-04-09 6:19 ` Hiremath, Vaibhav 2012-04-09 20:18 ` Jon Hunter 2012-04-09 20:18 ` Jon Hunter 2012-04-10 5:42 ` Hiremath, Vaibhav 2012-04-10 5:42 ` Hiremath, Vaibhav 2012-04-10 8:44 ` Russell King - ARM Linux 2012-04-10 8:44 ` Russell King - ARM Linux 2012-04-10 8:57 ` Santosh Shilimkar 2012-04-10 8:57 ` Santosh Shilimkar 2012-04-10 9:29 ` Russell King - ARM Linux 2012-04-10 9:29 ` Russell King - ARM Linux 2012-04-10 9:51 ` Shilimkar, Santosh 2012-04-10 9:51 ` Shilimkar, Santosh 2012-04-10 21:03 ` Jon Hunter 2012-04-10 21:03 ` Jon Hunter 2012-04-11 1:00 ` Ming Lei 2012-04-11 1:00 ` Ming Lei 2012-04-11 7:47 ` Shilimkar, Santosh 2012-04-11 7:47 ` Shilimkar, Santosh 2012-04-06 21:18 ` Kevin Hilman 2012-04-06 21:18 ` Kevin Hilman 2012-04-09 6:25 ` Hiremath, Vaibhav 2012-04-09 6:25 ` Hiremath, Vaibhav 2012-03-21 11:29 ` Hiremath, Vaibhav 2012-03-21 11:29 ` Hiremath, Vaibhav 2012-03-23 8:20 ` Ming Lei 2012-03-23 8:20 ` Ming Lei 2012-03-30 6:39 ` Hiremath, Vaibhav 2012-03-30 6:39 ` Hiremath, Vaibhav 2012-03-05 22:55 ` Tony Lindgren 2012-03-05 22:55 ` Tony Lindgren 2012-03-07 9:48 ` Hiremath, Vaibhav 2012-03-07 9:48 ` Hiremath, Vaibhav 2012-03-09 17:58 ` Hiremath, Vaibhav 2012-03-09 17:58 ` Hiremath, Vaibhav 2012-03-12 9:39 ` Felipe Balbi 2012-03-12 9:39 ` Felipe Balbi 2012-03-12 9:48 ` Hiremath, Vaibhav 2012-03-12 9:48 ` Hiremath, Vaibhav 2012-03-12 10:17 ` Felipe Balbi 2012-03-12 10:17 ` Felipe Balbi 2012-03-12 10:39 ` Hiremath, Vaibhav 2012-03-12 10:39 ` Hiremath, Vaibhav 2012-01-19 14:28 ` [PATCH 2/3] ARM: OMAP2/3: Add idle_st bits for ST_32KSYNC timer to prcm-common header Vaibhav Hiremath 2012-01-19 14:28 ` Vaibhav Hiremath 2012-03-05 22:56 ` Tony Lindgren 2012-03-05 22:56 ` Tony Lindgren 2012-03-07 9:49 ` Hiremath, Vaibhav 2012-03-07 9:49 ` Hiremath, Vaibhav 2012-01-19 14:28 ` [PATCH 3/3] ARM: OMAP2+: hwmod data: Add 32k-sync timer data to hwmod database Vaibhav Hiremath 2012-01-19 14:28 ` Vaibhav Hiremath 2012-01-23 8:47 ` [PATCH 0/3] ARM: OMAP1/2+: 32k-timer: Add hwmod lookup for 32k-timer Hiremath, Vaibhav 2012-01-23 8:47 ` Hiremath, Vaibhav 2012-03-05 22:57 ` Tony Lindgren 2012-03-05 22:57 ` Tony Lindgren 2012-03-07 9:50 ` Hiremath, Vaibhav 2012-03-07 9:50 ` Hiremath, Vaibhav
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=79CD15C6BA57404B839C016229A409A831841009@DBDE01.ent.ti.com \ --to=hvaibhav@ti.com \ --cc=b-cousson@ti.com \ --cc=balbi@ti.com \ --cc=johnstul@us.ibm.com \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=paul@pwsan.com \ --cc=santosh.shilimkar@ti.com \ --cc=tarun.kanti@ti.com \ --cc=tom.leiming@gmail.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.