All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hiremath, Vaibhav" <hvaibhav@ti.com>
To: Paul Walmsley <paul@pwsan.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Cc: Tony Lindgren <tony@atomide.com>,
	"Hilman, Kevin" <khilman@ti.com>,
	"Cousson, Benoit" <b-cousson@ti.com>
Subject: RE: [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer
Date: Thu, 7 Jun 2012 06:59:05 +0000	[thread overview]
Message-ID: <79CD15C6BA57404B839C016229A409A83EA43E0F@DBDE01.ent.ti.com> (raw)
In-Reply-To: <20120607061309.25532.13430.stgit@dusk>

On Thu, Jun 07, 2012 at 11:43:10, Paul Walmsley wrote:
> Kevin discovered that commit c8d82ff68fb6873691536cf33021977efbf5593c
> ("ARM: OMAP2/3: hwmod data: Add 32k-sync timer data to hwmod
> database") broke CORE idle on OMAP3.  This prevents device low power
> states.
> 
> The root cause is that the 32K sync timer IP block does not support
> smart-idle mode[1], and so the hwmod code keeps the IP block in
> no-idle mode while it is active.  This in turn prevents the WKUP
> clockdomain from transitioning to idle.  There is a hardcoded sleep
> dependency that prevents the CORE_L3 and CORE_CM clockdomains from
> transitioning to idle when the WKUP clockdomain is active[2], so the
> chip cannot enter any device low power states.
> 
> It turns out that there is no need to take the 32k sync timer out of
> idle.  The IP block itself probably does not have any native idle
> handling at all, due to its simplicity.  Furthermore, the PRCM will
> never request target idle for this IP block while the kernel is
> running, due to the sleep dependency that prevents the WKUP
> clockdomain from idling while the CORE_L3 clockdomain is active.  So
> we can safely leave the 32k sync timer in target-no-idle mode, even
> while we continue to access it.
> 
> This workaround is implemented by programming the force-idle mode for
> any IP block that only supports the force-idle and no-idle modes.  If
> an IP block is ever released that doesn't support smart-idle and
> requires no-idle mode to be programmed while it's in use, we'll have
> to change this behavior.
> 

Isn't this impact AM33xx devices, where we do not support smart idle mode???
Anyway, I will also test it on both OMAP3EVM and AM33xx platform now...

Thanks,
Vaibhav


WARNING: multiple messages have this Message-ID (diff)
From: hvaibhav@ti.com (Hiremath, Vaibhav)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer
Date: Thu, 7 Jun 2012 06:59:05 +0000	[thread overview]
Message-ID: <79CD15C6BA57404B839C016229A409A83EA43E0F@DBDE01.ent.ti.com> (raw)
In-Reply-To: <20120607061309.25532.13430.stgit@dusk>

On Thu, Jun 07, 2012 at 11:43:10, Paul Walmsley wrote:
> Kevin discovered that commit c8d82ff68fb6873691536cf33021977efbf5593c
> ("ARM: OMAP2/3: hwmod data: Add 32k-sync timer data to hwmod
> database") broke CORE idle on OMAP3.  This prevents device low power
> states.
> 
> The root cause is that the 32K sync timer IP block does not support
> smart-idle mode[1], and so the hwmod code keeps the IP block in
> no-idle mode while it is active.  This in turn prevents the WKUP
> clockdomain from transitioning to idle.  There is a hardcoded sleep
> dependency that prevents the CORE_L3 and CORE_CM clockdomains from
> transitioning to idle when the WKUP clockdomain is active[2], so the
> chip cannot enter any device low power states.
> 
> It turns out that there is no need to take the 32k sync timer out of
> idle.  The IP block itself probably does not have any native idle
> handling at all, due to its simplicity.  Furthermore, the PRCM will
> never request target idle for this IP block while the kernel is
> running, due to the sleep dependency that prevents the WKUP
> clockdomain from idling while the CORE_L3 clockdomain is active.  So
> we can safely leave the 32k sync timer in target-no-idle mode, even
> while we continue to access it.
> 
> This workaround is implemented by programming the force-idle mode for
> any IP block that only supports the force-idle and no-idle modes.  If
> an IP block is ever released that doesn't support smart-idle and
> requires no-idle mode to be programmed while it's in use, we'll have
> to change this behavior.
> 

Isn't this impact AM33xx devices, where we do not support smart idle mode???
Anyway, I will also test it on both OMAP3EVM and AM33xx platform now...

Thanks,
Vaibhav

  reply	other threads:[~2012-06-07  6:59 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-07  6:13 [PATCH 00/11] ARM: OMAP: core/hwmod: first set of fixes for 3.5-rc Paul Walmsley
2012-06-07  6:13 ` Paul Walmsley
2012-06-07  6:13 ` [PATCH 01/11] ARM: OMAP2+: hwmod: add setup_preprogram hook Paul Walmsley
2012-06-07  6:13   ` Paul Walmsley
2012-06-07  6:13 ` [PATCH 02/11] ARM: OMAP4+: AESS: enable internal auto-gating during initial setup Paul Walmsley
2012-06-07  6:13   ` Paul Walmsley
2012-06-07  7:19   ` Tony Lindgren
2012-06-07  7:19     ` Tony Lindgren
2012-06-07  7:31     ` Paul Walmsley
2012-06-07  7:31       ` Paul Walmsley
2012-06-07  7:48       ` Tony Lindgren
2012-06-07  7:48         ` Tony Lindgren
2012-06-07 10:45         ` Paul Walmsley
2012-06-07 10:45           ` Paul Walmsley
2012-06-07 11:08           ` Tony Lindgren
2012-06-07 11:08             ` Tony Lindgren
2012-06-07  6:13 ` [PATCH 03/11] ARM: OMAP4: hwmod data: add SL2IF hardreset line Paul Walmsley
2012-06-07  6:13   ` Paul Walmsley
2012-06-07  6:13 ` [PATCH 04/11] ARM: OMAP2+: usb_host_fs: add custom reset for usb_host_fs (fsusb) Paul Walmsley
2012-06-07  6:13   ` Paul Walmsley
2012-06-07  7:31   ` Tony Lindgren
2012-06-07  7:31     ` Tony Lindgren
2012-06-07  7:33     ` Felipe Balbi
2012-06-07  7:33       ` Felipe Balbi
2012-06-07  8:00       ` Tony Lindgren
2012-06-07  8:00         ` Tony Lindgren
2012-06-07  7:40     ` Paul Walmsley
2012-06-07  7:40       ` Paul Walmsley
2012-06-07  7:51       ` Tony Lindgren
2012-06-07  7:51         ` Tony Lindgren
2012-06-07  7:55         ` Felipe Balbi
2012-06-07  7:55           ` Felipe Balbi
2012-06-07  8:02           ` Cousson, Benoit
2012-06-07  8:02             ` Cousson, Benoit
2012-06-07  8:10             ` Tony Lindgren
2012-06-07  8:10               ` Tony Lindgren
2012-06-07  8:14             ` Felipe Balbi
2012-06-07  8:14               ` Felipe Balbi
2012-06-07 10:52             ` Paul Walmsley
2012-06-07 10:52               ` Paul Walmsley
2012-06-07 12:30               ` Cousson, Benoit
2012-06-07 12:30                 ` Cousson, Benoit
2012-06-08  1:11                 ` Paul Walmsley
2012-06-08  1:11                   ` Paul Walmsley
2012-06-08 13:13                   ` Cousson, Benoit
2012-06-08 13:13                     ` Cousson, Benoit
2012-06-08 13:28                     ` Paul Walmsley
2012-06-08 13:28                       ` Paul Walmsley
2012-06-08 19:32                       ` Hiremath, Vaibhav
2012-06-08 19:32                         ` Hiremath, Vaibhav
2012-06-08 23:10                         ` AM335x CPSW reset (was "RE: [PATCH 04/11] ARM: OMAP2+: usb_host_fs: add custom reset for usb_host_fs (fsusb)") Paul Walmsley
2012-06-08 23:10                           ` Paul Walmsley
2012-06-09  8:39                           ` Hiremath, Vaibhav
2012-06-09  8:39                             ` Hiremath, Vaibhav
2012-06-09 16:05                             ` Paul Walmsley
2012-06-09 16:05                               ` Paul Walmsley
2012-06-11  6:15                       ` [PATCH 04/11] ARM: OMAP2+: usb_host_fs: add custom reset for usb_host_fs (fsusb) Tony Lindgren
2012-06-11  6:15                         ` Tony Lindgren
2012-06-11  8:04                         ` Paul Walmsley
2012-06-11  8:04                           ` Paul Walmsley
2012-06-11  9:24                           ` Cousson, Benoit
2012-06-11  9:24                             ` Cousson, Benoit
2012-06-11 16:20                             ` Paul Walmsley
2012-06-11 16:20                               ` Paul Walmsley
2012-06-07 10:20         ` Paul Walmsley
2012-06-07 10:20           ` Paul Walmsley
2012-06-07 10:52           ` Tony Lindgren
2012-06-07 10:52             ` Tony Lindgren
2012-06-07 22:05             ` Paul Walmsley
2012-06-07 22:05               ` Paul Walmsley
2012-06-08  6:38               ` Tony Lindgren
2012-06-08  6:38                 ` Tony Lindgren
2012-06-09  1:31                 ` Paul Walmsley
2012-06-09  1:31                   ` Paul Walmsley
2012-06-11  6:21                   ` Tony Lindgren
2012-06-11  6:21                     ` Tony Lindgren
2012-06-07  6:13 ` [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer Paul Walmsley
2012-06-07  6:13   ` Paul Walmsley
2012-06-07  6:59   ` Hiremath, Vaibhav [this message]
2012-06-07  6:59     ` Hiremath, Vaibhav
2012-06-07  7:08     ` Paul Walmsley
2012-06-07  7:08       ` Paul Walmsley
2012-06-07 18:09       ` Hiremath, Vaibhav
2012-06-07 18:09         ` Hiremath, Vaibhav
2012-06-07 20:03         ` Paul Walmsley
2012-06-07 20:03           ` Paul Walmsley
2012-06-08 19:10           ` Hiremath, Vaibhav
2012-06-08 19:10             ` Hiremath, Vaibhav
2012-06-11  9:12             ` Cousson, Benoit
2012-06-11  9:12               ` Cousson, Benoit
2012-06-08 13:22   ` Tero Kristo
2012-06-08 13:22     ` Tero Kristo
2012-06-08 23:18     ` Paul Walmsley
2012-06-08 23:18       ` Paul Walmsley
2012-06-07  6:13 ` [PATCH 06/11] ARM: OMAP4+: hwmod: fix issue causing IPs not going back to Smart-Standby Paul Walmsley
2012-06-07  6:13   ` Paul Walmsley
2012-06-07  6:13 ` [PATCH 07/11] ARM: OMAP: PM: Lock clocks list while generating summary Paul Walmsley
2012-06-07  6:13   ` Paul Walmsley
2012-06-07  6:13 ` [PATCH 08/11] ARM: OMAP2+: CM: increase the module disable timeout Paul Walmsley
2012-06-07  6:13   ` Paul Walmsley
2012-06-07  6:13 ` [PATCH 10/11] ARM: OMAP2+: hwmod: add flag to prevent hwmod code from touching IP block during init Paul Walmsley
2012-06-07  6:13   ` Paul Walmsley
2012-06-07  6:13 ` [PATCH 09/11] ARM: OMAP4: clock data: add clockdomains for clocks used as main clocks Paul Walmsley
2012-06-07  6:13   ` Paul Walmsley
2012-06-07  6:39   ` Rajendra Nayak
2012-06-07  6:39     ` Rajendra Nayak
2012-06-18 17:41     ` Paul Walmsley
2012-06-18 17:41       ` Paul Walmsley
2012-06-19  5:15       ` Rajendra Nayak
2012-06-19  5:15         ` Rajendra Nayak
2012-06-07  6:13 ` [PATCH 11/11] ARM: OMAP4: hwmod data: do not enable or reset the McPDM during kernel init Paul Walmsley
2012-06-07  6:13   ` Paul Walmsley
2012-06-08 13:30 ` [PATCH 00/11] ARM: OMAP: core/hwmod: first set of fixes for 3.5-rc Tero Kristo
2012-06-08 13:30   ` Tero Kristo
2012-06-09  1:15   ` Paul Walmsley
2012-06-09  1:15     ` Paul Walmsley
2012-06-13 23:55   ` Paul Walmsley
2012-06-13 23:55     ` Paul Walmsley
2012-06-14  7:36     ` Tero Kristo
2012-06-14  7:36       ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79CD15C6BA57404B839C016229A409A83EA43E0F@DBDE01.ent.ti.com \
    --to=hvaibhav@ti.com \
    --cc=b-cousson@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.