From: "Hiremath, Vaibhav" <hvaibhav@ti.com> To: Paul Walmsley <paul@pwsan.com> Cc: "Cousson, Benoit" <b-cousson@ti.com>, "Balbi, Felipe" <balbi@ti.com>, Tony Lindgren <tony@atomide.com>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "Kristo, Tero" <t-kristo@ti.com>, Ohad Ben-Cohen <ohad@wizery.com> Subject: RE: AM335x CPSW reset (was "RE: [PATCH 04/11] ARM: OMAP2+: usb_host_fs: add custom reset for usb_host_fs (fsusb)") Date: Sat, 9 Jun 2012 08:39:32 +0000 [thread overview] Message-ID: <79CD15C6BA57404B839C016229A409A83EA464C6@DBDE01.ent.ti.com> (raw) In-Reply-To: <alpine.DEB.2.00.1206081659230.17523@utopia.booyaka.com> On Sat, Jun 09, 2012 at 04:40:03, Paul Walmsley wrote: > Hi > > On Fri, 8 Jun 2012, Hiremath, Vaibhav wrote: > > > In case of AM33xx, recently I came across similar issue (rather more > > than this) with CPSW module. > > > > The issue is, > > > > We have observed that, in order to disable the CPSW module > > (MODULEMODE=0x0), We have to assert OCP level reset, before disabling > > it; else module enters into unknown state, where register status shows, > > MODULEMODE turns 0x0, but idlests says module is busy. > > > > This has to be done everytime you try to disable the module. > > > > The worst part here is, CPSW has 4 submodules (SS, SL1, SL2, CPDMA), > > We have to assert reset signal to each submodules. > > > > So the approach I had taken is, I had implemented almost similar > > function specific to cpsw and introduced flag called > > HWMOD_SWSUP_RESET_BEFORE_IDLE. > > Why "SWSUP" ? > Since it was SW initiated reset assertion so I added this prefix. > > Now the question here would be, should we consider this IP bug or > > integration bug? If it is integration bug, then isn't this device issue? > > I don't know if it's a bug in either place, but it sounds like something > that needs to be handled in the _am335x_disable_module() code in > mach-omap2/omap_hwmod.c. > Yes, certainly it should be part of _am335x_disable_module(). Thanks, Vaibhav
WARNING: multiple messages have this Message-ID (diff)
From: hvaibhav@ti.com (Hiremath, Vaibhav) To: linux-arm-kernel@lists.infradead.org Subject: AM335x CPSW reset (was "RE: [PATCH 04/11] ARM: OMAP2+: usb_host_fs: add custom reset for usb_host_fs (fsusb)") Date: Sat, 9 Jun 2012 08:39:32 +0000 [thread overview] Message-ID: <79CD15C6BA57404B839C016229A409A83EA464C6@DBDE01.ent.ti.com> (raw) In-Reply-To: <alpine.DEB.2.00.1206081659230.17523@utopia.booyaka.com> On Sat, Jun 09, 2012 at 04:40:03, Paul Walmsley wrote: > Hi > > On Fri, 8 Jun 2012, Hiremath, Vaibhav wrote: > > > In case of AM33xx, recently I came across similar issue (rather more > > than this) with CPSW module. > > > > The issue is, > > > > We have observed that, in order to disable the CPSW module > > (MODULEMODE=0x0), We have to assert OCP level reset, before disabling > > it; else module enters into unknown state, where register status shows, > > MODULEMODE turns 0x0, but idlests says module is busy. > > > > This has to be done everytime you try to disable the module. > > > > The worst part here is, CPSW has 4 submodules (SS, SL1, SL2, CPDMA), > > We have to assert reset signal to each submodules. > > > > So the approach I had taken is, I had implemented almost similar > > function specific to cpsw and introduced flag called > > HWMOD_SWSUP_RESET_BEFORE_IDLE. > > Why "SWSUP" ? > Since it was SW initiated reset assertion so I added this prefix. > > Now the question here would be, should we consider this IP bug or > > integration bug? If it is integration bug, then isn't this device issue? > > I don't know if it's a bug in either place, but it sounds like something > that needs to be handled in the _am335x_disable_module() code in > mach-omap2/omap_hwmod.c. > Yes, certainly it should be part of _am335x_disable_module(). Thanks, Vaibhav
next prev parent reply other threads:[~2012-06-09 8:39 UTC|newest] Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-06-07 6:13 [PATCH 00/11] ARM: OMAP: core/hwmod: first set of fixes for 3.5-rc Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-07 6:13 ` [PATCH 01/11] ARM: OMAP2+: hwmod: add setup_preprogram hook Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-07 6:13 ` [PATCH 02/11] ARM: OMAP4+: AESS: enable internal auto-gating during initial setup Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-07 7:19 ` Tony Lindgren 2012-06-07 7:19 ` Tony Lindgren 2012-06-07 7:31 ` Paul Walmsley 2012-06-07 7:31 ` Paul Walmsley 2012-06-07 7:48 ` Tony Lindgren 2012-06-07 7:48 ` Tony Lindgren 2012-06-07 10:45 ` Paul Walmsley 2012-06-07 10:45 ` Paul Walmsley 2012-06-07 11:08 ` Tony Lindgren 2012-06-07 11:08 ` Tony Lindgren 2012-06-07 6:13 ` [PATCH 03/11] ARM: OMAP4: hwmod data: add SL2IF hardreset line Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-07 6:13 ` [PATCH 04/11] ARM: OMAP2+: usb_host_fs: add custom reset for usb_host_fs (fsusb) Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-07 7:31 ` Tony Lindgren 2012-06-07 7:31 ` Tony Lindgren 2012-06-07 7:33 ` Felipe Balbi 2012-06-07 7:33 ` Felipe Balbi 2012-06-07 8:00 ` Tony Lindgren 2012-06-07 8:00 ` Tony Lindgren 2012-06-07 7:40 ` Paul Walmsley 2012-06-07 7:40 ` Paul Walmsley 2012-06-07 7:51 ` Tony Lindgren 2012-06-07 7:51 ` Tony Lindgren 2012-06-07 7:55 ` Felipe Balbi 2012-06-07 7:55 ` Felipe Balbi 2012-06-07 8:02 ` Cousson, Benoit 2012-06-07 8:02 ` Cousson, Benoit 2012-06-07 8:10 ` Tony Lindgren 2012-06-07 8:10 ` Tony Lindgren 2012-06-07 8:14 ` Felipe Balbi 2012-06-07 8:14 ` Felipe Balbi 2012-06-07 10:52 ` Paul Walmsley 2012-06-07 10:52 ` Paul Walmsley 2012-06-07 12:30 ` Cousson, Benoit 2012-06-07 12:30 ` Cousson, Benoit 2012-06-08 1:11 ` Paul Walmsley 2012-06-08 1:11 ` Paul Walmsley 2012-06-08 13:13 ` Cousson, Benoit 2012-06-08 13:13 ` Cousson, Benoit 2012-06-08 13:28 ` Paul Walmsley 2012-06-08 13:28 ` Paul Walmsley 2012-06-08 19:32 ` Hiremath, Vaibhav 2012-06-08 19:32 ` Hiremath, Vaibhav 2012-06-08 23:10 ` AM335x CPSW reset (was "RE: [PATCH 04/11] ARM: OMAP2+: usb_host_fs: add custom reset for usb_host_fs (fsusb)") Paul Walmsley 2012-06-08 23:10 ` Paul Walmsley 2012-06-09 8:39 ` Hiremath, Vaibhav [this message] 2012-06-09 8:39 ` Hiremath, Vaibhav 2012-06-09 16:05 ` Paul Walmsley 2012-06-09 16:05 ` Paul Walmsley 2012-06-11 6:15 ` [PATCH 04/11] ARM: OMAP2+: usb_host_fs: add custom reset for usb_host_fs (fsusb) Tony Lindgren 2012-06-11 6:15 ` Tony Lindgren 2012-06-11 8:04 ` Paul Walmsley 2012-06-11 8:04 ` Paul Walmsley 2012-06-11 9:24 ` Cousson, Benoit 2012-06-11 9:24 ` Cousson, Benoit 2012-06-11 16:20 ` Paul Walmsley 2012-06-11 16:20 ` Paul Walmsley 2012-06-07 10:20 ` Paul Walmsley 2012-06-07 10:20 ` Paul Walmsley 2012-06-07 10:52 ` Tony Lindgren 2012-06-07 10:52 ` Tony Lindgren 2012-06-07 22:05 ` Paul Walmsley 2012-06-07 22:05 ` Paul Walmsley 2012-06-08 6:38 ` Tony Lindgren 2012-06-08 6:38 ` Tony Lindgren 2012-06-09 1:31 ` Paul Walmsley 2012-06-09 1:31 ` Paul Walmsley 2012-06-11 6:21 ` Tony Lindgren 2012-06-11 6:21 ` Tony Lindgren 2012-06-07 6:13 ` [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-07 6:59 ` Hiremath, Vaibhav 2012-06-07 6:59 ` Hiremath, Vaibhav 2012-06-07 7:08 ` Paul Walmsley 2012-06-07 7:08 ` Paul Walmsley 2012-06-07 18:09 ` Hiremath, Vaibhav 2012-06-07 18:09 ` Hiremath, Vaibhav 2012-06-07 20:03 ` Paul Walmsley 2012-06-07 20:03 ` Paul Walmsley 2012-06-08 19:10 ` Hiremath, Vaibhav 2012-06-08 19:10 ` Hiremath, Vaibhav 2012-06-11 9:12 ` Cousson, Benoit 2012-06-11 9:12 ` Cousson, Benoit 2012-06-08 13:22 ` Tero Kristo 2012-06-08 13:22 ` Tero Kristo 2012-06-08 23:18 ` Paul Walmsley 2012-06-08 23:18 ` Paul Walmsley 2012-06-07 6:13 ` [PATCH 06/11] ARM: OMAP4+: hwmod: fix issue causing IPs not going back to Smart-Standby Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-07 6:13 ` [PATCH 07/11] ARM: OMAP: PM: Lock clocks list while generating summary Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-07 6:13 ` [PATCH 08/11] ARM: OMAP2+: CM: increase the module disable timeout Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-07 6:13 ` [PATCH 10/11] ARM: OMAP2+: hwmod: add flag to prevent hwmod code from touching IP block during init Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-07 6:13 ` [PATCH 09/11] ARM: OMAP4: clock data: add clockdomains for clocks used as main clocks Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-07 6:39 ` Rajendra Nayak 2012-06-07 6:39 ` Rajendra Nayak 2012-06-18 17:41 ` Paul Walmsley 2012-06-18 17:41 ` Paul Walmsley 2012-06-19 5:15 ` Rajendra Nayak 2012-06-19 5:15 ` Rajendra Nayak 2012-06-07 6:13 ` [PATCH 11/11] ARM: OMAP4: hwmod data: do not enable or reset the McPDM during kernel init Paul Walmsley 2012-06-07 6:13 ` Paul Walmsley 2012-06-08 13:30 ` [PATCH 00/11] ARM: OMAP: core/hwmod: first set of fixes for 3.5-rc Tero Kristo 2012-06-08 13:30 ` Tero Kristo 2012-06-09 1:15 ` Paul Walmsley 2012-06-09 1:15 ` Paul Walmsley 2012-06-13 23:55 ` Paul Walmsley 2012-06-13 23:55 ` Paul Walmsley 2012-06-14 7:36 ` Tero Kristo 2012-06-14 7:36 ` Tero Kristo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=79CD15C6BA57404B839C016229A409A83EA464C6@DBDE01.ent.ti.com \ --to=hvaibhav@ti.com \ --cc=b-cousson@ti.com \ --cc=balbi@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=ohad@wizery.com \ --cc=paul@pwsan.com \ --cc=t-kristo@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.