All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Florian Fainelli <f.fainelli@gmail.com>, <linux-kernel@vger.kernel.org>
Cc: Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	"maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..."
	<bcm-kernel-feedback-list@broadcom.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>, "Rob Herring" <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	"moderated list:ARM SUB-ARCHITECTURES"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:MIPS" <linux-mips@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE"
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 14/14] irqchip: Fix kernel-doc parameter typo for IRQCHIP_DECLARE
Date: Tue, 28 Sep 2021 21:41:29 +0300	[thread overview]
Message-ID: <79aa96aa-1c54-13ca-48ab-be00ec11bb14@omp.ru> (raw)
In-Reply-To: <20210928182139.652896-15-f.fainelli@gmail.com>

On 9/28/21 9:21 PM, Florian Fainelli wrote:

> The documentation refers to "compstr" when we have the argument named

   Nitpick: the arguments are what you pass to a function, you meant parameters.

> "compat", fix the typo.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  include/linux/irqchip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/irqchip.h b/include/linux/irqchip.h
> index 67351aac65ef..ccf32758ea85 100644
> --- a/include/linux/irqchip.h
> +++ b/include/linux/irqchip.h
> @@ -23,7 +23,7 @@
>   *
>   * @name: name that must be unique across all IRQCHIP_DECLARE of the
>   * same file.
> - * @compstr: compatible string of the irqchip driver
> + * @compat: compatible string of the irqchip driver
>   * @fn: initialization function
>   */
>  #define IRQCHIP_DECLARE(name, compat, fn) OF_DECLARE_2(irqchip, name, compat, fn)

MBR. Sergey

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Florian Fainelli <f.fainelli@gmail.com>, <linux-kernel@vger.kernel.org>
Cc: Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	"maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." 
	<bcm-kernel-feedback-list@broadcom.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>, "Rob Herring" <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	"moderated list:ARM SUB-ARCHITECTURES" 
	<linux-arm-kernel@lists.infradead.org>,
	"open list:MIPS" <linux-mips@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 14/14] irqchip: Fix kernel-doc parameter typo for IRQCHIP_DECLARE
Date: Tue, 28 Sep 2021 21:41:29 +0300	[thread overview]
Message-ID: <79aa96aa-1c54-13ca-48ab-be00ec11bb14@omp.ru> (raw)
In-Reply-To: <20210928182139.652896-15-f.fainelli@gmail.com>

On 9/28/21 9:21 PM, Florian Fainelli wrote:

> The documentation refers to "compstr" when we have the argument named

   Nitpick: the arguments are what you pass to a function, you meant parameters.

> "compat", fix the typo.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  include/linux/irqchip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/irqchip.h b/include/linux/irqchip.h
> index 67351aac65ef..ccf32758ea85 100644
> --- a/include/linux/irqchip.h
> +++ b/include/linux/irqchip.h
> @@ -23,7 +23,7 @@
>   *
>   * @name: name that must be unique across all IRQCHIP_DECLARE of the
>   * same file.
> - * @compstr: compatible string of the irqchip driver
> + * @compat: compatible string of the irqchip driver
>   * @fn: initialization function
>   */
>  #define IRQCHIP_DECLARE(name, compat, fn) OF_DECLARE_2(irqchip, name, compat, fn)

MBR. Sergey

  reply	other threads:[~2021-09-28 18:44 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 18:21 [PATCH v3 00/14] Modular Broadcom irqchip drivers Florian Fainelli
2021-09-28 18:21 ` Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 01/14] MIPS: BMIPS: Remove use of irq_cpu_offline Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-10-03 16:09   ` Thomas Bogendoerfer
2021-10-03 16:09     ` Thomas Bogendoerfer
2021-09-28 18:21 ` [PATCH v3 02/14] irqchip/irq-bcm7038-l1: Remove .irq_cpu_offline() Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 03/14] irqchip/irq-bcm7038-l1: Use irq_get_irq_data() Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 04/14] irqchip/irq-bcm7038-l1: Gate use of CPU logical map to MIPS Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 05/14] irqchip/irq-bcm7038-l1: Restrict affinity setting " Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 06/14] irqchip/irq-bcm7038-l1: Switch to IRQCHIP_PLATFORM_DRIVER Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 07/14] genirq: Export irq_gc_{unmask_enable,mask_disable}_reg Florian Fainelli
2021-09-28 18:21   ` [PATCH v3 07/14] genirq: Export irq_gc_{unmask_enable, mask_disable}_reg Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 08/14] irqchip/irq-brcmstb-l2: Switch to IRQCHIP_PLATFORM_DRIVER Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 09/14] irqchip: Provide platform_device to of_irq_init_cb_t Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 19:36   ` Rob Herring
2021-09-28 19:36     ` Rob Herring
2021-09-28 18:21 ` [PATCH v3 10/14] genirq: Export irq_gc_noop() Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 11/14] irqchip/irq-bcm7120-l2: Switch to IRQCHIP_PLATFORM_DRIVER Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 12/14] arm64: broadcom: Removed forced select of interrupt controllers Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 13/14] ARM: bcm: " Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 18:21 ` [PATCH v3 14/14] irqchip: Fix kernel-doc parameter typo for IRQCHIP_DECLARE Florian Fainelli
2021-09-28 18:21   ` Florian Fainelli
2021-09-28 18:41   ` Sergey Shtylyov [this message]
2021-09-28 18:41     ` Sergey Shtylyov
2021-10-04 17:03 ` [PATCH v3 00/14] Modular Broadcom irqchip drivers Florian Fainelli
2021-10-04 17:03   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79aa96aa-1c54-13ca-48ab-be00ec11bb14@omp.ru \
    --to=s.shtylyov@omp.ru \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=frowand.list@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maz@kernel.org \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=tglx@linutronix.de \
    --cc=tsbogend@alpha.franken.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.