All of lore.kernel.org
 help / color / mirror / Atom feed
From: guido@trentalancia.net (Guido Trentalancia)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH 2/2] system/modutils: Allow kmod to use the sys_admin cap
Date: Tue, 29 Nov 2016 00:16:35 +0100	[thread overview]
Message-ID: <7A5E57BD-A02E-4C3F-BC55-62BF20B5D762@trentalancia.net> (raw)
In-Reply-To: <20161129000359.7c70497f@gentp.lnet>

Hello. 

If you revert the getty commit that I mentioned earlier on, you get back ifdef distro_redhat, so eventually you only need to add the new ifdef grsecurity. 

Finally, as already explained, on a plain system kmod does not need sys_admin either. 

It's something related only to your specific system that requires the sys_admin capability permission.

Only you can find out whether this is due to grsecurity or other patches...

I hope it helps... 

Regards, 

Guido 

On the 29th novembre 2016 00:03:59 CET, Luis Ressel <aranea@aixah.de> wrote:
>On Mon, 28 Nov 2016 23:24:10 +0100
>Guido Trentalancia via refpolicy <refpolicy@oss.tresys.com> wrote:
>
>> It's very easy !...
>> 
>> You can create a patch that reverts
>> commit?7216d000d94342dc347a976a7a6a65f40a2f41cb and then adds an
>> "ifdef grsecurity" for such sys_admin permission (for getty and/or
>> kmod).
>
>Thanks, I'm perfectly aware of *how* to do this, but I'd like to
>achieve
>a broader consensus first (specifically, I'd really like to hear
>Dominick's and Chris' opinions).
>
>Plus, we should first find out if there actually are any other
>permissions in the refpolicy which pertain to grsec requirements. As
>I've mentioned, cap_sys_admin may actually be required for agetty even
>on non-grsec systems (I think Dominick said so, and it used to be
>granted by distro_redhat, too). And we haven't established yet whether
>kmod needing cap_sys_admin is grsec-related anyway. Therefore, we might
>perhaps be left with no grsec-specific permissions at all. :)
>
>> Enclosing them in double ifdef should not be necessary. In my
>opinion,
>> the former proposal is enough (ifdef grsecurity).
>
>Of course double ifdef's wouldn't make much sense. I was merely
>suggesting that we could use distro_gentoo for this instead of adding a
>new ifdef variable.
>
>Regards,
>Luis

  reply	other threads:[~2016-11-28 23:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-27 16:41 [refpolicy] [PATCH 1/2] system/modutils: Add kernel_search_key(kmod_t) Luis Ressel
2016-11-27 16:41 ` [refpolicy] [PATCH 2/2] system/modutils: Allow kmod to use the sys_admin cap Luis Ressel
2016-11-27 20:33   ` Guido Trentalancia
2016-11-27 21:22     ` Luis Ressel
2016-11-27 21:55       ` Luis Ressel
2016-11-27 22:30       ` Luis Ressel
2016-11-27 22:31       ` Guido Trentalancia
2016-11-27 22:50         ` Luis Ressel
2016-11-28 17:02           ` Guido Trentalancia
2016-11-28 21:48             ` Luis Ressel
2016-11-28 21:57               ` Guido Trentalancia
2016-11-28 22:14                 ` Luis Ressel
2016-11-28 22:24                   ` Guido Trentalancia
2016-11-28 23:03                     ` Luis Ressel
2016-11-28 23:16                       ` Guido Trentalancia [this message]
2016-11-29  1:55                         ` Chris PeBenito
2016-11-29  6:22                           ` Nicolas Iooss
2016-11-29 12:53                             ` [refpolicy] [PATCH] Allow getty the sys_admin capability (was Re: [PATCH 2/2] system/modutils: Allow kmod to use the sys_admin cap) Guido Trentalancia
2016-11-28 22:03             ` [refpolicy] [PATCH 2/2] system/modutils: Allow kmod to use the sys_admin cap Luis Ressel
2016-11-28 22:08               ` Guido Trentalancia
2016-12-04 23:56 ` [refpolicy] [PATCH 1/2] system/modutils: Add kernel_search_key(kmod_t) Luis Ressel
2016-12-07  0:59 ` Chris PeBenito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7A5E57BD-A02E-4C3F-BC55-62BF20B5D762@trentalancia.net \
    --to=guido@trentalancia.net \
    --cc=refpolicy@oss.tresys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.