All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.iooss@m4x.org (Nicolas Iooss)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH 2/2] system/modutils: Allow kmod to use the sys_admin cap
Date: Tue, 29 Nov 2016 07:22:07 +0100	[thread overview]
Message-ID: <CAJfZ7==gnXKBp9k_CiK5SZNfPDhVmWU_Q44fpX4Hhm_z9yjXKw@mail.gmail.com> (raw)
In-Reply-To: <7e4a1ef4-edeb-e59e-d178-5ac904d28965@ieee.org>

On Tue, Nov 29, 2016 at 2:55 AM, Chris PeBenito via refpolicy <
refpolicy@oss.tresys.com> wrote:

> On 11/28/16 18:16, Guido Trentalancia via refpolicy wrote:
> > Hello.
> >
> > If you revert the getty commit that I mentioned earlier on, you get back
> ifdef distro_redhat, so eventually you only need to add the new ifdef
> grsecurity.
> >
> > Finally, as already explained, on a plain system kmod does not need
> sys_admin either.
> >
> > It's something related only to your specific system that requires the
> sys_admin capability permission.
> >
> > Only you can find out whether this is due to grsecurity or other
> patches...
>
> If it turns out to be grsecurity, I'm not eager to add an additional
> build option to handle this situation.  It seems better fitting for
> Gentoo to carry that patch as they support SELinux with grsecurity.


By the way, I also maintain (and am using) a grsec+SELinux kernel for Arch
Linux, but as Arch Linux is currently unsupported by refpolicy I guess this
does not change anything.
Anyway, for the agetty use of TIOCSTI, when I analyzed the code back in
March [1] I found that forbidding it would only cause agetty to miss one
keypress if it went into a pause (with "[press ENTER to login]" message).
So I do not have a strong opinion on whether cap_sys_admin would be granted
or not to support TIOCSTI on grsec kernels.
For the kmod part, I do not have such an issue on my system (grepping
kmod_t AVC denials in my audit.log did not show anything relevant) but I
guess it depends on the video driver which is used.

Regards,
Nicolas

[1] http://oss.tresys.com/pipermail/refpolicy/2016-March/thread.html , more
precisely http://oss.tresys.com/pipermail/refpolicy/2016-March/007880.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.tresys.com/pipermail/refpolicy/attachments/20161129/a8d3f178/attachment.html 

  reply	other threads:[~2016-11-29  6:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-27 16:41 [refpolicy] [PATCH 1/2] system/modutils: Add kernel_search_key(kmod_t) Luis Ressel
2016-11-27 16:41 ` [refpolicy] [PATCH 2/2] system/modutils: Allow kmod to use the sys_admin cap Luis Ressel
2016-11-27 20:33   ` Guido Trentalancia
2016-11-27 21:22     ` Luis Ressel
2016-11-27 21:55       ` Luis Ressel
2016-11-27 22:30       ` Luis Ressel
2016-11-27 22:31       ` Guido Trentalancia
2016-11-27 22:50         ` Luis Ressel
2016-11-28 17:02           ` Guido Trentalancia
2016-11-28 21:48             ` Luis Ressel
2016-11-28 21:57               ` Guido Trentalancia
2016-11-28 22:14                 ` Luis Ressel
2016-11-28 22:24                   ` Guido Trentalancia
2016-11-28 23:03                     ` Luis Ressel
2016-11-28 23:16                       ` Guido Trentalancia
2016-11-29  1:55                         ` Chris PeBenito
2016-11-29  6:22                           ` Nicolas Iooss [this message]
2016-11-29 12:53                             ` [refpolicy] [PATCH] Allow getty the sys_admin capability (was Re: [PATCH 2/2] system/modutils: Allow kmod to use the sys_admin cap) Guido Trentalancia
2016-11-28 22:03             ` [refpolicy] [PATCH 2/2] system/modutils: Allow kmod to use the sys_admin cap Luis Ressel
2016-11-28 22:08               ` Guido Trentalancia
2016-12-04 23:56 ` [refpolicy] [PATCH 1/2] system/modutils: Add kernel_search_key(kmod_t) Luis Ressel
2016-12-07  0:59 ` Chris PeBenito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfZ7==gnXKBp9k_CiK5SZNfPDhVmWU_Q44fpX4Hhm_z9yjXKw@mail.gmail.com' \
    --to=nicolas.iooss@m4x.org \
    --cc=refpolicy@oss.tresys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.