From: Alexander Graf <agraf@suse.de>
To: Thomas Huth <thuth@linux.vnet.ibm.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC64: Add support for ldbrx and stdbrx instructions
Date: Thu, 9 Feb 2012 14:49:07 +0100 [thread overview]
Message-ID: <7A8FD6FF-A346-4EFB-BBE2-D28CD664283B@suse.de> (raw)
In-Reply-To: <20120209084339.79536829@BR8GGW75.de.ibm.com>
On 09.02.2012, at 08:43, Thomas Huth wrote:
> Am Thu, 9 Feb 2012 11:26:09 +1100
> schrieb David Gibson <dwg@au1.ibm.com>:
>
>> On Wed, Feb 08, 2012 at 02:27:35PM +0100, Thomas Huth wrote:
>>> Am Wed, 8 Feb 2012 21:48:40 +1100
>>> schrieb David Gibson <david@gibson.dropbear.id.au>:
>>>
>>>> On Wed, Feb 08, 2012 at 10:54:21AM +0400, malc wrote:
>>>>> On Wed, 8 Feb 2012, David Gibson wrote:
>>>>>
>>>>>> From: Thomas Huth <thuth@linux.vnet.ibm.com>
>>>>>>
>>>>>> These instructions for loading and storing byte-swapped 64-bit values have
>>>>>> been introduced in PowerISA 2.06.
>>>>>>
>>>>>> Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
>>>>>> ---
>>>>>> target-ppc/translate.c | 30 ++++++++++++++++++++++++++++++
>>>>>> 1 files changed, 30 insertions(+), 0 deletions(-)
>>>>>
>>>>> I seem to recall that POWER5 machine i had access to didn't have
>>>>> ld/stdbrx while CBE did have it (or was it the other way around?)
>>>>> so question is - is PPC_64B sufficient?
>>>>
>>>> Ah, I think it's not. I think I spotted that before, but then forgot
>>>> about it. Thanks for the reminder.
>>>
>>> Maybe it's a better idea to use PPC_64BX here? ... but that flag seems
>>> to be missing in POWERPC_INSNS_POWER7... David, could PPC_64BX also be
>>> included in that flag list?
>>
>> Um.. what exactly do you mean by 64BX?
>>
>
> There is a definition in target-ppc/cpu.h:
>
> /* New 64 bits extensions (PowerPC 2.0x) */
> PPC_64BX = 0x0000000000000040ULL,
>
> According to the comment, I thought the PPC_64BX might be designed
> for new 64-bit instructions?
Well, we need to be a bit more specific here to know what we're implementing. The flag above just indicates the lq opcode:
target-ppc/translate.c:GEN_HANDLER(lq, 0x38, 0xFF, 0xFF, 0x00000000, PPC_64BX),
So how about we create a new PPC2 flag for BRX and add that in POWER7 INSNS? If you could find out if Cell also supports these instructions, that'd be great. I don't have a 2.05 spec handy and 2.04 doesn't implement it yet.
Alex
prev parent reply other threads:[~2012-02-09 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 5:53 [Qemu-devel] [PATCH] PPC64: Add support for ldbrx and stdbrx instructions David Gibson
2012-02-08 6:54 ` malc
2012-02-08 10:48 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2012-02-08 13:27 ` Thomas Huth
2012-02-09 0:26 ` David Gibson
2012-02-09 7:43 ` Thomas Huth
2012-02-09 13:49 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7A8FD6FF-A346-4EFB-BBE2-D28CD664283B@suse.de \
--to=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.