From: David Lechner <david@lechnology.com>
To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: Axel Haslam <ahaslam@baylibre.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 5/5] ARM: DTS: da850: Add usb phy node
Date: Thu, 27 Oct 2016 10:55:42 -0500 [thread overview]
Message-ID: <7a57b179-bbe7-1412-84d4-8406981665ab@lechnology.com> (raw)
In-Reply-To: <d55f19f2-beb3-a681-a6e9-c1d2c303173c@ti.com>
On 10/26/2016 05:26 AM, Sekhar Nori wrote:
> On Wednesday 26 October 2016 08:36 AM, David Lechner wrote:
>> Add a node for the new usb phy driver.
>
> changed this to:
>
> Add a node for usb phy device. This device
> controls both the USB 1.1 and USB 2.0 PHYs.
>
> mainly because the node is for the device, not the driver.
>
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>
> Applied to v4.10/dt
>
> Thanks,
> Sekhar
>
I found a better way to represent this device as a child of the syscon
node. How should we handle the change? Should I submit a new patch that
applies on top of this one or will you drop this patch and I should send
a new one to take it's place?
Assuming that you agree that this is better:
cfgchip: cfgchip@1417c {
compatible = "ti,da830-cfgchip", "syscon", "simple-mfd";
reg = <0x1417c 0x14>;
usb_phy: usb-phy {
compatible = "ti,da830-usb-phy";
#phy-cells = <1>;
status = "disabled";
};
};
Since the phy consists entirely as registers in the syscon device, we
should make it a child of the syscon device instead of a child of the
soc node.
WARNING: multiple messages have this Message-ID (diff)
From: david@lechnology.com (David Lechner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 5/5] ARM: DTS: da850: Add usb phy node
Date: Thu, 27 Oct 2016 10:55:42 -0500 [thread overview]
Message-ID: <7a57b179-bbe7-1412-84d4-8406981665ab@lechnology.com> (raw)
In-Reply-To: <d55f19f2-beb3-a681-a6e9-c1d2c303173c@ti.com>
On 10/26/2016 05:26 AM, Sekhar Nori wrote:
> On Wednesday 26 October 2016 08:36 AM, David Lechner wrote:
>> Add a node for the new usb phy driver.
>
> changed this to:
>
> Add a node for usb phy device. This device
> controls both the USB 1.1 and USB 2.0 PHYs.
>
> mainly because the node is for the device, not the driver.
>
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>
> Applied to v4.10/dt
>
> Thanks,
> Sekhar
>
I found a better way to represent this device as a child of the syscon
node. How should we handle the change? Should I submit a new patch that
applies on top of this one or will you drop this patch and I should send
a new one to take it's place?
Assuming that you agree that this is better:
cfgchip: cfgchip at 1417c {
compatible = "ti,da830-cfgchip", "syscon", "simple-mfd";
reg = <0x1417c 0x14>;
usb_phy: usb-phy {
compatible = "ti,da830-usb-phy";
#phy-cells = <1>;
status = "disabled";
};
};
Since the phy consists entirely as registers in the syscon device, we
should make it a child of the syscon device instead of a child of the
soc node.
next prev parent reply other threads:[~2016-10-27 15:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 3:06 [PATCH v6 0/5] da8xx USB PHY platform devices and clocks David Lechner
2016-10-26 3:06 ` David Lechner
2016-10-26 3:06 ` David Lechner
2016-10-26 3:06 ` [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks David Lechner
2016-10-26 3:06 ` David Lechner
2016-10-26 7:59 ` Sekhar Nori
2016-10-26 7:59 ` Sekhar Nori
2016-10-26 7:59 ` Sekhar Nori
2016-10-26 16:37 ` David Lechner
2016-10-26 16:37 ` David Lechner
2016-10-26 16:37 ` David Lechner
2016-10-26 17:13 ` Sekhar Nori
2016-10-26 17:13 ` Sekhar Nori
2016-10-26 17:13 ` Sekhar Nori
2016-10-26 9:24 ` Sekhar Nori
2016-10-26 9:24 ` Sekhar Nori
2016-10-26 9:24 ` Sekhar Nori
2016-10-26 3:06 ` [PATCH v6 2/5] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration David Lechner
2016-10-26 3:06 ` David Lechner
2016-10-26 9:58 ` Sekhar Nori
2016-10-26 9:58 ` Sekhar Nori
2016-10-26 9:58 ` Sekhar Nori
2016-10-26 3:06 ` [PATCH v6 3/5] ARM: davinci: da8xx: Add USB PHY " David Lechner
2016-10-26 3:06 ` David Lechner
2016-10-26 3:06 ` [PATCH v6 4/5] ARM: DTS: da850: Add cfgchip syscon node David Lechner
2016-10-26 3:06 ` David Lechner
2016-10-26 3:06 ` David Lechner
2016-10-26 10:19 ` Sekhar Nori
2016-10-26 10:19 ` Sekhar Nori
2016-10-26 10:19 ` Sekhar Nori
2016-10-26 16:08 ` David Lechner
2016-10-26 16:08 ` David Lechner
2016-10-26 16:08 ` David Lechner
2016-10-28 8:21 ` Sekhar Nori
2016-10-28 8:21 ` Sekhar Nori
2016-10-28 8:21 ` Sekhar Nori
2016-10-28 17:08 ` Kevin Hilman
2016-10-28 17:08 ` Kevin Hilman
2016-10-28 17:08 ` Kevin Hilman
2016-10-28 17:24 ` David Lechner
2016-10-28 17:24 ` David Lechner
2016-10-28 17:24 ` David Lechner
2016-10-28 20:53 ` Kevin Hilman
2016-10-28 20:53 ` Kevin Hilman
2016-10-26 3:06 ` [PATCH v6 5/5] ARM: DTS: da850: Add usb phy node David Lechner
2016-10-26 3:06 ` David Lechner
2016-10-26 10:26 ` Sekhar Nori
2016-10-26 10:26 ` Sekhar Nori
2016-10-26 10:26 ` Sekhar Nori
2016-10-27 15:55 ` David Lechner [this message]
2016-10-27 15:55 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a57b179-bbe7-1412-84d4-8406981665ab@lechnology.com \
--to=david@lechnology.com \
--cc=ahaslam@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.