From: Guenter Roeck <linux@roeck-us.net>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: linux-watchdog@vger.kernel.org, Wenyou.Yang@microchip.com,
linux-kernel@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Wim Van Sebroeck <wim@iguana.be>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] watchodg: sama5d4: simplify probe
Date: Fri, 3 Mar 2017 06:14:06 -0800 [thread overview]
Message-ID: <7abe4456-6c10-55bf-ead4-7379f23e7f6e@roeck-us.net> (raw)
In-Reply-To: <20170303092958.2phrxelq3xqojns7@piout.net>
On 03/03/2017 01:29 AM, Alexandre Belloni wrote:
> On 03/03/2017 at 09:03:25 +0100, Thomas Petazzoni wrote:
>> On Thu, 2 Mar 2017 18:31:13 +0100, Alexandre Belloni wrote:
>>
>>> + irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
>>
>> Any reason to use irq_of_parse_and_map() over the more conventional
>> platform_get_irq() ?
>>
>
> No particular reason but I'm just removing the if (pdev->dev.of_node)
>
A function call change would (should) be a separate patch.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] watchodg: sama5d4: simplify probe
Date: Fri, 3 Mar 2017 06:14:06 -0800 [thread overview]
Message-ID: <7abe4456-6c10-55bf-ead4-7379f23e7f6e@roeck-us.net> (raw)
In-Reply-To: <20170303092958.2phrxelq3xqojns7@piout.net>
On 03/03/2017 01:29 AM, Alexandre Belloni wrote:
> On 03/03/2017 at 09:03:25 +0100, Thomas Petazzoni wrote:
>> On Thu, 2 Mar 2017 18:31:13 +0100, Alexandre Belloni wrote:
>>
>>> + irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
>>
>> Any reason to use irq_of_parse_and_map() over the more conventional
>> platform_get_irq() ?
>>
>
> No particular reason but I'm just removing the if (pdev->dev.of_node)
>
A function call change would (should) be a separate patch.
Guenter
next prev parent reply other threads:[~2017-03-03 15:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 17:31 [PATCH 0/4] watchdog: sama5d4: fix issues Alexandre Belloni
2017-03-02 17:31 ` Alexandre Belloni
2017-03-02 17:31 ` [PATCH 1/4] watchdog: sama5d4: fix WDDIS handling Alexandre Belloni
2017-03-02 17:31 ` Alexandre Belloni
2017-03-04 15:04 ` Guenter Roeck
2017-03-04 15:04 ` Guenter Roeck
2017-03-07 2:05 ` Wenyou.Yang
2017-03-07 2:05 ` Wenyou.Yang at microchip.com
2017-03-02 17:31 ` [PATCH 2/4] watchdog: sama5d4: fix race condition Alexandre Belloni
2017-03-02 17:31 ` Alexandre Belloni
2017-03-02 17:42 ` Guenter Roeck
2017-03-02 17:42 ` Guenter Roeck
2017-03-02 17:54 ` Alexandre Belloni
2017-03-02 17:54 ` Alexandre Belloni
2017-03-04 15:05 ` Guenter Roeck
2017-03-04 15:05 ` Guenter Roeck
2017-03-07 2:06 ` Wenyou.Yang
2017-03-07 2:06 ` Wenyou.Yang at microchip.com
2017-03-02 17:31 ` [PATCH 3/4] watchodg: sama5d4: simplify probe Alexandre Belloni
2017-03-02 17:31 ` Alexandre Belloni
2017-03-02 19:29 ` Alexander Dahl
2017-03-02 19:29 ` Alexander Dahl
2017-03-03 8:03 ` Thomas Petazzoni
2017-03-03 8:03 ` Thomas Petazzoni
2017-03-03 9:29 ` Alexandre Belloni
2017-03-03 9:29 ` Alexandre Belloni
2017-03-03 14:14 ` Guenter Roeck [this message]
2017-03-03 14:14 ` Guenter Roeck
2017-03-04 15:06 ` Guenter Roeck
2017-03-04 15:06 ` Guenter Roeck
2017-03-02 17:31 ` [PATCH 4/4] watchdog: sama5d4: Add comment explaining what happens on resume Alexandre Belloni
2017-03-02 17:31 ` Alexandre Belloni
2017-03-04 15:07 ` Guenter Roeck
2017-03-04 15:07 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7abe4456-6c10-55bf-ead4-7379f23e7f6e@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Wenyou.Yang@microchip.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.